gh-184 Fix segfault and socket fd leak #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you please edit the commit message so it starts with |
micahsnyder
reviewed
Jul 27, 2021
clamonacc/client/protocol.c
Outdated
| @@ -241,6 +241,7 @@ int onas_dsresult(CURL *curl, int scantype, uint64_t maxstream, const char *file | |||
| int sockd = -1; | |||
| int (*recv_func)(struct onas_rcvln *, char **, char **, int64_t) = NULL; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This file needs to be clang-format'ed.
|
wow, this amazing fix performs perfectly stable in my scenarios - looking forward to the merge! thanks |
This fixes a fatal issue that would occur when unable to queue events due to clamonacc improperly using all available fds. It also fixes the core fd socket leak issue at the heart of the segfault by properly cleaning up after a failed curl connection. Lastly, worst case recovery code now allows more time for consumer queue to catchup. It accomplishes this by increasing wait time and adding retry logic. More info: Cisco-Talos#184
|
Looks good to me too! |
|
Will merge into main, then cherry-pick to rel/0.104. We'll need to create a separate PR for dev/0.103.4 that includes a comment in the News about the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes a fatal issue that would occur when unable to queue events due to
clamonacc improperly using all available fds.
It also fixes the core fd socket leak issue at the heart of the segfault by
properly cleaning up after a failed curl connection.