Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENABLE_UNRAR=off build #237

Merged
merged 1 commit into from Jul 31, 2021

Conversation

ragusaa
Copy link
Contributor

@ragusaa ragusaa commented Jul 30, 2021

Cmake errors out when the ENABLE_UNRAR=off option is used. This commit
addresses that.

@ragusaa ragusaa force-pushed the CLAM-1528-FixBuildWithUnrar branch from ee8c707 to 552d7a3 Compare July 30, 2021 22:38
Cmake errors out when the ENABLE_UNRAR=off option is used.  This commit
addresses that.
@ragusaa ragusaa force-pushed the CLAM-1528-FixBuildWithUnrar branch from c70960d to 17d28b8 Compare July 30, 2021 23:14
@micahsnyder micahsnyder self-requested a review July 30, 2021 23:52
@micahsnyder
Copy link
Contributor

This fixes #225

@micahsnyder micahsnyder merged commit c4af06c into Cisco-Talos:main Jul 31, 2021
22 of 24 checks passed
@micahsnyder
Copy link
Contributor

Also cherry-picked to rel/0.104 so it gets into RC2 and release.

@DanielRuf
Copy link

Not sure if related but on current main branch I get this when I compile with this setting:

/workspaces/clamav/common/cert_util.c:42:16: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
   42 |     cl_error_t ret = CL_EFORMAT;
      |                ^~~
[ 69%] Building C object common/CMakeFiles/common.dir/actions.c.o
In file included from /workspaces/clamav/libclamav/matcher.h:29,
                 from /workspaces/clamav/libclamav/others.h:22,
                 from /workspaces/clamav/common/actions.c:52:
/workspaces/clamav/libclamav/others.h:57:10: fatal error: unrar_iface.h: No such file or directory
   57 | #include "unrar_iface.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [common/CMakeFiles/common.dir/build.make:76: common/CMakeFiles/common.dir/actions.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1662: common/CMakeFiles/common.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

cmake .. -D CMAKE_BUILD_TYPE=RelWithDebInfo -D CMAKE_INSTALL_PREFIX=/usr -D CMAKE_INSTALL_LIBDIR=/usr/lib -D APP_CONFIG_DIRECTORY=/etc/clamav -D DATABASE_DIRECTORY=/workspaces/clamav/scan-rules -D ENABLE_STATIC_LIB=ON -D ENABLE_SHARED_LIB=OFF -D ENABLE_UNRAR=OFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants