Fix benign overread in HTML/js-norm parser #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to run this one through a larger regression test to make sure it doesn't inadvertently change the javascript normalization and cause false negatives. |
ragusaa
approved these changes
Mar 17, 2022
|
I haven't merged this yet because in a large regression test I found a number of false negatives and I haven't had time to triage each to determine if there's a bug, or if we will just have to update some signatures after this lands. Can complete this after 0.105 ships. |
micahsnyder
force-pushed
the
CLAM-1711-js-norm-overread
branch
from
01511cd
to
386bd44
Compare
Fix a possible overread in `handle_de()` where we dereference tokens without boundchecking. The over-read does not cause a crash. Resolves: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44849 Also clean up very sloppy bounds checking in `match_parameters()`. I don't have any evidence of an overflow. The code just looks sus. Eliminated a benign warning in `cli_js_process_buffer()`.
micahsnyder
force-pushed
the
CLAM-1711-js-norm-overread
branch
from
386bd44
to
7301d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix a possible overread in
handle_de()where we dereferencetokenswithout boundchecking. The over-read does not cause a crash.
I do not believe this issue to be a vulnerability.
Resolves: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44849
Also clean up very sloppy bounds checking in
match_parameters().I don't have any evidence of an overflow. The code just looks sus.
Eliminated a benign warning in
cli_js_process_buffer().