Clam 1656 Fix leak loading malformed IDB databases #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
changed the title
micahsnyder
approved these changes
May 28, 2022
micahsnyder
force-pushed
the
CLAM-1656-idbleak
branch
from
aff35e5
to
5e6f056
Compare
|
Rebased to see it go through the test pipelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Free matcher on error condition.
Reproducer artifacts are https://github.com/Cisco-Talos/clamav/suites/4980638814/artifacts/145471677
To reproduce, build with address sanitization enabled and mpool disabled
'cmake -G Ninja .. -DCMAKE_CXX_COMPILER=clang++-8 -DCMAKE_C_COMPILER=clang-8 -DCMAKE_LINKER=clang-8 -DCMAKE_INSTALL_PREFIX=~/install -DCMAKE_C_FLAGS='''-fsanitize=address -g -fno-omit-frame-pointer''' -DENABLE_TESTS=OFF -DDISABLE_MPOOL=1'
Rename the reproducer test case to '.idb', and try and load the signature
'clamscan -d test.idb'
Description is here https://github.com/Cisco-Talos/clamav/runs/4860615522?check_suite_focus=true
Click Summary->artifacts