1611 - add bounds checking to wdb pattern buffer - #548
Merged
Conversation
During wdb load, it was possible to go beyond the bounds of the pattern buffer due to two subsequent increment ops with no bounds checking in between. This issue was reported by external researchers and they provided the fix as well. Based on our own research, this is a defect but not a vulnerability.
val-ms
self-requested a review
April 15, 2022 20:08
val-ms
approved these changes
Apr 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During wdb load, it was possible to go beyond the bounds
of the pattern buffer due to two subsequent increment ops
with no bounds checking in between.
This issue was reported by external researchers and
they provided the fix as well.
Based on our own research, this is a defect but not a vulnerability.