Clam 1648 Fix benign heap over-read when loading some LDB signatures using byte-compare feature #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
reviewed
May 16, 2022
ragusaa
force-pushed
the
CLAM-1648-FixIndex
branch
from
f21b8fc
to
0c16380
Compare
Previously 2 was hardcoded as as upper bound for loop in cli_bcomp_freemeta. Change to comp_count to avoid going past the end.
micahsnyder
force-pushed
the
CLAM-1648-FixIndex
branch
from
0c16380
to
8a1d7f4
Compare
|
Rebased this because it was failing the fuzz regression test from the latest fuzz fix, and wasn't completing the entire pipeline. |
micahsnyder
changed the title
micahsnyder
changed the title
|
Testing all looks good here. I got a bit hung up on debugging a failure in the private fuzz corpus until I realized a PoC landed there before a fix, and that it didn't mean this was introducing a new bug or anything |
micahsnyder
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously 2 was hardcoded as as upper bound for loop in
cli_bcomp_freemeta. Change to comp_count to avoid going
past the end.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43816