Clam 938 velvet sweatshop #700
Conversation
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
2 times, most recently
from
ae4e1b5
to
db73947
Compare
|
This pull request introduces 1 alert when merging db73947 into 197113c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 3d9f3e6 into b3a3b35 - view on LGTM.com new alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
3 times, most recently
from
7ec03e0
to
ac87635
Compare
|
This pull request fixes 1 alert when merging ac87635 into b3a3b35 - view on LGTM.com fixed alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
from
bbdf270
to
8ab4012
Compare
There was a problem hiding this comment.
Outside of some very minor issues, this looks awesome. Very nice work, @ragusaa
I'm happy with the code review.
Next up,
- I would like if you could can add a non-malware test case for the supported encryption type(s). If you can provide the samples/signatures, I'd be happy to create the test itself under
clamscan_test.,py, or else you are welcome to do it. - We should do some regression testing on a big set from the zoo, and see what happens.
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
from
4741cb1
to
7044d86
Compare
|
This pull request fixes 1 alert when merging 7044d86 into a4e6868 - view on LGTM.com fixed alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
2 times, most recently
from
c491b70
to
2694f89
Compare
|
This pull request fixes 1 alert when merging 2694f89 into cf81299 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 3d91a04 into cf81299 - view on LGTM.com fixed alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
from
6baa73f
to
13d1290
Compare
|
This pull request fixes 1 alert when merging 13d1290 into cf81299 - view on LGTM.com fixed alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
3 times, most recently
from
13b473f
to
47b9b0b
Compare
|
This pull request fixes 1 alert when merging 47b9b0b into 449bcd2 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 25eef13 into 449bcd2 - view on LGTM.com fixed alerts:
|
ragusaa
force-pushed
the
CLAM-938-VelvetSweatshop
branch
from
25eef13
to
276ee61
Compare
|
This pull request fixes 1 alert when merging 276ee61 into 449bcd2 - view on LGTM.com fixed alerts:
|
|
For any readers -- we moved the test to our internal repo, because the (entirely non-malicious) test file Andy created is detected by some antivirus for being understandably suspicious. We don't want the clam source, or even decrypted clam test files to be flagged by AV's. Testing looked good in the jenkins pipelines. Merging. |
Draft PR. NOT ready for review.