Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamscan: Add --jobs option for parallel scanning (v2) #78

Closed

Conversation

michal42
Copy link

When --jobs=N is given, build a list of files first and then spawn N
children to scan the files in parallel. The main process writes indexes
of to-be-scanned files to a pipe and the children all read from the
other end of the pipe and scan the given files. No attempt is made to
synchronize the output of the children, so the --jobs option is best
used together with --infected.

Signed-off-by: Michal Marek mmarek@suse.com

Changes in v2:

  • Rebased onto current master
  • Fixed a memory leak in error paths in run_jobs()

When --jobs=N is given, build a list of files first and then spawn N
children to scan the files in parallel. The main process writes indexes
of to-be-scanned files to a pipe and the children all read from the
other end of the pipe and scan the given files. No attempt is made to
synchronize the output of the children, so the --jobs option is best
used together with --infected.

Signed-off-by: Michal Marek <mmarek@suse.com>
@michal42 michal42 changed the title clamscan: Add --jobs option for parallel scanning clamscan: Add --jobs option for parallel scanning (v2) Jun 20, 2017
@micahsnyder
Copy link
Contributor

Hi @michal42 & @willmerae. Sorry about the delays in evaluating this pull request.

I'm looking forward to it, but unfortunately we haven't had time to evaluate and integrate it in this development cycle. We just transitioned to release testing to prepare for the 0.100.2 patch release and 0.101 feature release.

Just a heads up, we have a couple of larger changes currently undergoing review for the dev/0.101 that will require some minor changes to your code in order to rebase cleanly.

@michal42
Copy link
Author

Hi @micah-at-talos,

OK, please let me know once the larger changes have landed and I will rebase and also change the option name to -m / --multiscan.

@micahsnyder
Copy link
Contributor

Hi @michal42,

Now that 0.101 is finally released, we've made the dev/0.102 branch and have applied new clang-format rules to the repository. This is the change I was mentioning earlier.

We included a "clam-format" script, that will run clang-format on the whole code base for you (if installed), excluding files we don't own, and a few select files that we don't wish to format.

@micahsnyder micahsnyder changed the base branch from master to dev/0.102 December 4, 2018 14:06
@micahsnyder
Copy link
Contributor

Closing this PR as being replaced by #113

@micahsnyder micahsnyder closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants