Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf() argument type mismatch warnings #795

Merged
merged 1 commit into from Mar 7, 2023

Conversation

rzvncj
Copy link
Contributor

@rzvncj rzvncj commented Dec 15, 2022

"format ‘%zu’ expects argument of type ‘size_t’, but argument 3 has type ‘int’ [-Wformat=]"

@rzvncj
Copy link
Contributor Author

rzvncj commented Dec 15, 2022

I've read the Windows build log and I don't believe that the build error has anything to do with this change.

@rzvncj rzvncj force-pushed the main branch 2 times, most recently from 459b5e9 to ce7efbe Compare February 3, 2023 13:34
"format ‘%zu’ expects argument of type ‘size_t’, but argument 3
has type ‘int’ [-Wformat=]"
@rzvncj
Copy link
Contributor Author

rzvncj commented Feb 23, 2023

Ping? :) As discussed on Discord, the automated check errors are not caused by the patch.

Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In testing I verified that it resolved the warnings. Thank you for the fix @rzvncj

@micahsnyder micahsnyder merged commit 64b4bd9 into Cisco-Talos:main Mar 7, 2023
21 of 24 checks passed
@rzvncj
Copy link
Contributor Author

rzvncj commented Mar 8, 2023

Looks good to me. In testing I verified that it resolved the warnings. Thank you for the fix @rzvncj

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants