Add an option to avoid setting RPATH on unix systems. #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this Sebastian. Casually reading this, it makes sense to me. As noted on the other PR, this week has been hectic and I expect that week will be as well. I will give it more attention as soon as I can. |
|
Can you please also document the new option in https://github.com/Cisco-Talos/clamav/blob/main/INSTALL.md#custom-cmake-config-options Outside of this documentation request, I'm happy with the PR. |
micahsnyder
requested changes
Mar 9, 2023
RPATH overrides the normal library search path, possibly interfering with local policy and causing problems for multi-lib, among other issues. Add an option to avoid setting it with letting it enabled by default. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
|
done |
micahsnyder
requested changes
Mar 19, 2023
micahsnyder
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
RPATH overrides the normal library search path, possibly interfering with local policy and causing problems for multilib, among other issues.
Add an option to avoid setting it with letting it enabled by default.
Signed-off-by: Sebastian Andrzej Siewior sebastian@breakpoint.cc