Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamonacc: add logging to watchpoint hierarchy add #822

Merged
merged 1 commit into from Feb 9, 2023

Conversation

m-sola
Copy link
Contributor

@m-sola m-sola commented Feb 2, 2023

Patch provides more insight into error conditions which may arise when adding a directory to the watch hierarchy. If a specific file caused the issue, the filename is provided to help users with any troubleshooting needed.

@micahsnyder
Copy link
Contributor

There are also some places where err (a cl_error_t return code) is printed directly. E.g.

            logg(LOGG_ERROR, "ClamInotif: could not parse include list (%d)\n", err);

It would probably help make if we switch to cl_strerror, like:

            logg(LOGG_ERROR, "ClamInotif: could not parse include list (%s)\n", cl_strerror(err));

clamonacc/inotif/inotif.c Fixed Show fixed Hide fixed
clamonacc/inotif/inotif.c Fixed Show fixed Hide fixed
clamonacc/inotif/inotif.c Fixed Show fixed Hide fixed
clamonacc/inotif/inotif.c Fixed Show fixed Hide fixed
Patch provides more insight into error conditions which may arise
when adding a directory to the watch hierarchy. If a specific file
caused the issue, the filename is provided to help users with any
troubleshooting needed.
@micahsnyder micahsnyder merged commit 73109eb into Cisco-Talos:main Feb 9, 2023
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants