Clam 571 sigtool vba extraction improvements #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
9 times, most recently
from
e372a80
to
06cdd46
Compare
micahsnyder
changed the title
|
In testing I tried using the |
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
from
c000ec8
to
aed8895
Compare
|
Good catch, just pushed an update |
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
2 times, most recently
from
070fabc
to
67ddb36
Compare
micahsnyder
requested changes
Mar 22, 2023
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
from
32b4737
to
5801dfb
Compare
ragusaa
commented
Mar 23, 2023
micahsnyder
requested changes
Mar 23, 2023
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
from
258ac87
to
49592f1
Compare
ragusaa
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
4 times, most recently
from
9314e36
to
f4c21fb
Compare
micahsnyder
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
2 times, most recently
from
53db585
to
d6796d0
Compare
Add a new cl_engine_set_clcb_vba() function to set a cb_vba callback function and add clcb_generic_data handler prototype to the clamav.h public API. The cb_vba callback function will be run whenever VBA is extracted from office documents. The provided data will be a normalized copy of the original VBA. This callback is added to support Sigtool so it can use the same VBA extraction logic as when scanning documents. Change the Sigtool temp directory creation for any commands that use temp directories so that you can select a custom temp directory with the `--tempdir=PATH` option, and can retain the temp files with the `--leave-temps` option. Added `--tempdir` and `--leave-temps` to the Sigtool `--help` output. Added `--tempdir` and `--leave-temps` to the Sigtool manpage.
micahsnyder
force-pushed
the
CLAM-571-ThisProbablyWontWork
branch
from
d6796d0
to
4747786
Compare
micahsnyder
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR deduplicates some vba extraction logic so sigtool works the same way libclamav does, and so it can extract more things.