Windows: Enable MSI installer to upgrade between feature versions #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSI installer can find previous ClamAV installs to non-standard locations such at D:\ClamAV instead of C:\Program Files\ClamAV but only if upgrading to a new patch version of the same feature version. E.g. can find an upgrade 1.0.0 to 1.0.1, but cannot automatically find and upgrade 1.0.1 to 1.1.0. This change will make it so all minor feature versions will store the install path to the same key in the registry. A consequence of this change is that you can no longer install multiple feature versions of ClamAV using the MSI installer. If you want multiple ClamAV minor versions installed on Windows you will need to install using the ZIP package. This change will not allow the MSI installer to automatically find and upgrade across different major versions. E.g. cannot find and upgrade 0.105.2 to 1.1.0 because the former is major version 0, and the latter is major version 1. This is intentional because it is more likely that there will be breaking changes to config files and other user interfaces when we go to ClamAV 2.0.0.
ragusaa
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The MSI installer can find previous ClamAV installs to non-standard locations such at D:\ClamAV instead of C:\Program Files\ClamAV but only if upgrading to a new patch version of the same feature version.
E.g. can find an upgrade 1.0.0 to 1.0.1, but cannot automatically find and upgrade 1.0.1 to 1.1.0.
This change will make it so all minor feature versions will store the install path to the same key in the registry.
A consequence of this change is that you can no longer install multiple feature versions of ClamAV using the MSI installer. If you want multiple ClamAV minor versions installed on Windows you will need to install using the ZIP package.
This change will not allow the MSI installer to automatically find and upgrade across different major versions.
E.g. cannot find and upgrade 0.105.2 to 1.1.0 because the former is major version 0, and the latter is major version 1. This is intentional because it is more likely that there will be breaking changes to config files and other user interfaces when we go to ClamAV 2.0.0.
Fixes: #861