Use antivirus_use_jit instead of clamd_use_jit

[Klaas-]

clamd_use_jit was renamed to antivirus_use_jit https://bugzilla.redhat.com/show_bug.cgi?id=1295473

[Klaas-]

I think I found how to compile that bytecode :) the diff seems a little big for my changes, from git history it looks like there are more changes that were made to source that did not make it into the real bytecode

[micahsnyder]

Thanks for the submission Klaas! That's frustrating that they renamed it to antivirus_use_jit, but I also understand why.

I also tried compiling the header with your change into bytecode to compare and the output I got was mostly the same, but slightly different than what's in your pull request. I'll review it again a little later when I find some more time and see if I can understand why.

[Klaas-]

If I recompile it the first line seems to change, maybe it includes some information like a compile date?

[micahsnyder]

Hmm seems likely.

[micahsnyder]

I'm told that the name antivirus_use_jit is only a redhat/fedora thing, and that the official selinux reference policy has clamd_use_jit. This change would apparently upset all of the other distro users.

[Klaas-]

hehe, okay I did not know that. Should I maybe make a reference to both?

[micahsnyder]

I'm not familiar enough with selinux to say if duplicating that line to set both will work. If it does, that's probably a good way to go.

[micahsnyder]

I will note, that if we do make this change, we'll have to update the bytecode.cvd database to propagate this. The builtin bytecode is overridden by one distributed in bytecode.cvd (which should be identical).

[micahsnyder]

Things have been hectic here on development and we just passed our deadline for completing code for inclusion into 0.101. We're now focused on testing changes that we've made and merging those dev/0.101 prior to an upcoming 0.101.0-beta. As such, this change won't make it into 0.101.

Don't despair about it not being hardcoded into 0.101, as it is more important to get such a change into the bytecode.cvd database where it overrides the built-in version.

Regardless, we still can't accept the change without evaluating if using both clamd_use_jit and antivirus_use_jit will accomplish the desired effect so as to keep all distro's happy.

[micahsnyder]

Adding link for reference, so this ticket isn't forgotten when we eventually figure out what to do with this: https://bugzilla.clamav.net/show_bug.cgi?id=12372

[micahsnyder]

I didn't mean to close this -- I deleted the old feature development branch because that version was merged, is done. It automatically closed this rather than re-targeting for a different branch.

It's still a good idea to try to support both antivirus_use_jit and clamd_use_jit. Just no time to work on it on my end and this PR swapped one for the other instead of trying to support both. I suppose it's good that we close it. This should really be a bug report until someone can put together a fix.