Skip to content

Add setuptools to install_requires#59

Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom
candrews:patch-1
Sep 5, 2024
Merged

Add setuptools to install_requires#59
val-ms merged 1 commit intoCisco-Talos:mainfrom
candrews:patch-1

Conversation

@candrews
Copy link
Contributor

@candrews candrews commented Sep 4, 2024

cvdupdate uses the pkg_resources module (provided by setuptools) at runtime so setuptools should be a dependency.

See https://setuptools.pypa.io/en/latest/pkg_resources.html

The usages are:

This PR addresses the runtime failure of cvd with this error:

$ cvd config set --dbdir "$(pwd)/database"
Traceback (most recent call last):
  File "/usr/local/bin/cvd", line 5, in <module>
    from cvdupdate.__main__ import cli
  File "/usr/local/lib/python3.12/site-packages/cvdupdate/__main__.py", line 42, in <module>
    from cvdupdate import auto_updater
  File "/usr/local/lib/python3.12/site-packages/cvdupdate/auto_updater.py", line 3, in <module>
    from cvdupdate.cvdupdate import CVDUpdate
  File "/usr/local/lib/python3.12/site-packages/cvdupdate/cvdupdate.py", line 28, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

cvdupdate uses the pkg_resources module (provided by setuptools) at runtime so setuptools should be a dependency.

Signed-off-by: Craig Andrews <candrews@integralblue.com>
@XtremeAI
Copy link

XtremeAI commented Sep 5, 2024

Same issue here. This worked for me.

Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran into this issue last week and was considering the same. Thank you for the PR.

@val-ms
Copy link
Contributor

val-ms commented Sep 5, 2024

@candrews are you able to sign your commit? Our org now requires signed commits. If it's a hassle, I can rebase your branch and sign it myself.

@candrews
Copy link
Contributor Author

candrews commented Sep 5, 2024

@candrews are you able to sign your commit? Our org now requires signed commits. If it's a hassle, I can rebase your branch and sign it myself.

The commit is signed - GitHub shows it as verified:
image

@val-ms
Copy link
Contributor

val-ms commented Sep 5, 2024

I'm an idiot. I misread the error message on the merge. And I already had my dose of caffeine for the morning. 🤦

@val-ms val-ms merged commit 9fa03c1 into Cisco-Talos:main Sep 5, 2024
@candrews
Copy link
Contributor Author

@micahsnyder can you please release a new version of cvdupdate with this change?

@val-ms
Copy link
Contributor

val-ms commented Oct 15, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants