New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Npc can be moved by players #1279

Closed
killertudse opened this Issue Aug 23, 2017 · 11 comments

Comments

Projects
None yet
7 participants
@killertudse

killertudse commented Aug 23, 2017

Greetings.
Some of my players recently discovered a bug with the Citizens plugin.

It is actually possible to move an NPC by using a fishing rod. If you right click with the fishing rod and hit an npc, they will actually be moved.

Thank you!

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Aug 23, 2017

Member

Are you running an up-to-date Citizens on 1.12.1 minecraft?

Member

mcmonkey4eva commented Aug 23, 2017

Are you running an up-to-date Citizens on 1.12.1 minecraft?

@killertudse

This comment has been minimized.

Show comment
Hide comment
@killertudse

killertudse Aug 23, 2017

Hello - Yes i am.
I can attempt to update to a newer build?

killertudse commented Aug 23, 2017

Hello - Yes i am.
I can attempt to update to a newer build?

@brutuscat2

This comment has been minimized.

Show comment
Hide comment
@brutuscat2

brutuscat2 Aug 23, 2017

I can reproduce this - it moves the NPC forward from my point of view. I am using the latest dev build along with the latest Paper build (also happens on Spigot) on 1.12.1.

brutuscat2 commented Aug 23, 2017

I can reproduce this - it moves the NPC forward from my point of view. I am using the latest dev build along with the latest Paper build (also happens on Spigot) on 1.12.1.

@killertudse

This comment has been minimized.

Show comment
Hide comment
@killertudse

killertudse Aug 24, 2017

Yes, exactly - heh.
As you can imagine this is causing a lot of issues. I was hoping the bug wouldnt spread, but slowly people just found out.

killertudse commented Aug 24, 2017

Yes, exactly - heh.
As you can imagine this is causing a lot of issues. I was hoping the bug wouldnt spread, but slowly people just found out.

@Bodyash

This comment has been minimized.

Show comment
Hide comment
@Bodyash

Bodyash Aug 26, 2017

Also, NPC can be moved by explotion velocity, lighting and water\lava

Bodyash commented Aug 26, 2017

Also, NPC can be moved by explotion velocity, lighting and water\lava

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Aug 30, 2017

Member

BTW, as a "backup" for this,
Set a single point using /npc path for NPCs you want to remain in place.
That way if they get knocked out of their spot, they just walk on back!

Member

mcmonkey4eva commented Aug 30, 2017

BTW, as a "backup" for this,
Set a single point using /npc path for NPCs you want to remain in place.
That way if they get knocked out of their spot, they just walk on back!

@HurricanKai

This comment has been minimized.

Show comment
Hide comment
@HurricanKai

HurricanKai Sep 1, 2017

You can, Use an item, (if the NPC has one) with an Attribute ( Knockback resistance ), or make the NPC Invincible (no idea if that works but ...) Minecraft Wik

HurricanKai commented Sep 1, 2017

You can, Use an item, (if the NPC has one) with an Attribute ( Knockback resistance ), or make the NPC Invincible (no idea if that works but ...) Minecraft Wik

@fullwall

This comment has been minimized.

Show comment
Hide comment
@fullwall

fullwall Sep 4, 2017

Member

It's tricky to fix this because Spigot's fishing API doesn't fully capture the fish event and there are other ways to move the NPC. I could make a command to make sure the NPC can't be moved but it would have to be added per-NPC (i.e. not default). Is that OK?

Member

fullwall commented Sep 4, 2017

It's tricky to fix this because Spigot's fishing API doesn't fully capture the fish event and there are other ways to move the NPC. I could make a command to make sure the NPC can't be moved but it would have to be added per-NPC (i.e. not default). Is that OK?

@brutuscat2

This comment has been minimized.

Show comment
Hide comment
@brutuscat2

brutuscat2 Sep 4, 2017

That would be fine.

brutuscat2 commented Sep 4, 2017

That would be fine.

@ElementalRealm

This comment has been minimized.

Show comment
Hide comment
@ElementalRealm

ElementalRealm Nov 21, 2017

didint fixed my problem at #1348

ElementalRealm commented Nov 21, 2017

didint fixed my problem at #1348

@fullwall

This comment has been minimized.

Show comment
Hide comment
@fullwall

fullwall Mar 15, 2018

Member

I can't move the NPCs in the latest spigot/Citizens.

Member

fullwall commented Mar 15, 2018

I can't move the NPCs in the latest spigot/Citizens.

@fullwall fullwall closed this Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment