New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC names that are over 16 characters are getting truncated #1300

Closed
Blackvein opened this Issue Sep 10, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@Blackvein

Blackvein commented Sep 10, 2017

When I name an NPC anything over 16 characters, the first 16 characters get dropped and the name over the NPC's head is the remainder of the String.

Example: Here i've named an NPC "mmynameissixteen" which is exactly 16 characters long: http://i.imgur.com/jLIPMy5.png

No problem, but if I make the NPC name "mmynameissixteencharacters" the first 16 get dropped and the name just becomes "characters": http://i.imgur.com/GPCFKaC.png

The proper full name still appears in /npc list, as well as the saves.yml but above the NPC's head it seems to not display correctly. This was tested on a blank server with nothing but Spigot and Citizens running.
Also player-scoreboard-teams.enable is set to true in the Citizens config.

Citizens v2.0.22-SNAPSHOT (build 1494)
Minecraft 1.12.1
CraftBukkit version git-Spigot-da42974-876d22c (MC: 1.12.1) (Implementing API version 1.12.1-R0.1-SNAPSHOT)

@Pugabyte

This comment has been minimized.

Show comment
Hide comment
@Pugabyte

Pugabyte Feb 25, 2018

I am also experiencing this problem. I've heard from multiple sources that this is not what's supposed to happen

Pugabyte commented Feb 25, 2018

I am also experiencing this problem. I've heard from multiple sources that this is not what's supposed to happen

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Feb 25, 2018

Member

It's not supposed to happen... Citizens handles longer names by generating scoreboard prefix/suffix as needed to extend a full name. It's really weird to maintain sometimes though...

Member

mcmonkey4eva commented Feb 25, 2018

It's not supposed to happen... Citizens handles longer names by generating scoreboard prefix/suffix as needed to extend a full name. It's really weird to maintain sometimes though...

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Jun 28, 2018

Member

npc rename command is patched in latest dev build (it was not updating scoreboards correctly, the way that npc create did)

Member

mcmonkey4eva commented Jun 28, 2018

npc rename command is patched in latest dev build (it was not updating scoreboards correctly, the way that npc create did)

@Pugabyte

This comment has been minimized.

Show comment
Hide comment
@Pugabyte

Pugabyte Jun 28, 2018

This is not fixed for me on build 1548. Neither rename nor create will create names with longer than 16 character names

EDIT: Works on a test server. Plugin incompatibility

Pugabyte commented Jun 28, 2018

This is not fixed for me on build 1548. Neither rename nor create will create names with longer than 16 character names

EDIT: Works on a test server. Plugin incompatibility

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Jun 28, 2018

Member

@Pugabyte likely conflict with some scoreboard control plugin? Or you've accidentally disabled scoreboards in the Citizens config.
Rename command was broken before, but scoreboard setup in general works fine on latest builds.
I confirmed they work fine a few days ago while building the rename command patch.

Member

mcmonkey4eva commented Jun 28, 2018

@Pugabyte likely conflict with some scoreboard control plugin? Or you've accidentally disabled scoreboards in the Citizens config.
Rename command was broken before, but scoreboard setup in general works fine on latest builds.
I confirmed they work fine a few days ago while building the rename command patch.

@Pugabyte

This comment has been minimized.

Show comment
Hide comment
@Pugabyte

Pugabyte Jun 28, 2018

We confirmed it works on a test server, my bad. We'll do some research and see if we can figure out which plugin as there's a few we have that mess with scoreboards.

Pugabyte commented Jun 28, 2018

We confirmed it works on a test server, my bad. We'll do some research and see if we can figure out which plugin as there's a few we have that mess with scoreboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment