New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin causes a problem with invisible mobs #1324

Closed
Ghostlyr opened this Issue Oct 4, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@Ghostlyr

Ghostlyr commented Oct 4, 2017

After installing the plugin a list of entities become invisible to clients spawned by natural generation: only spiders, slimes, zombies and may be another mobs. Players are can heard their sounds and hurt them, but cant see them.
No any errors and messages in plugin debug mode on server-side.

In client log, in the presence of a number of such mobs such records appears:

Skipping Entity with id -1

Without Citizens problem does not occur.

Last citizens 2.0.22 version build from jenkins.
Last spigot 1.11.2 version build.
MC 1.11.2 without any mods.

@Ghostlyr Ghostlyr changed the title from Plugin causes a problem with invinsible mobs to Plugin causes a problem with invisible mobs Oct 4, 2017

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Oct 5, 2017

Member

what other plugins do you have? That sounds like it might be conflicting with something protocol-related.

Member

mcmonkey4eva commented Oct 5, 2017

what other plugins do you have? That sounds like it might be conflicting with something protocol-related.

@Ghostlyr

This comment has been minimized.

Show comment
Hide comment
@Ghostlyr

Ghostlyr Oct 5, 2017

Latest for 1.11.2 versions of:
Essentials, Vault, VoidWorld, ProtocolLib, Multiverse-Core, NoCheatPlus, Citizens, Orebfuscator4, HolographicDisplays, UltraCosmetics
I guess conflicting with UltraCosmetics because without it could not reproduce the problem.

Ghostlyr commented Oct 5, 2017

Latest for 1.11.2 versions of:
Essentials, Vault, VoidWorld, ProtocolLib, Multiverse-Core, NoCheatPlus, Citizens, Orebfuscator4, HolographicDisplays, UltraCosmetics
I guess conflicting with UltraCosmetics because without it could not reproduce the problem.

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Oct 6, 2017

Member

:/ could you try to contact that plugin's developer(s)? Feel free to just ask them to post here and we can figure out what's going on?

Member

mcmonkey4eva commented Oct 6, 2017

:/ could you try to contact that plugin's developer(s)? Feel free to just ask them to post here and we can figure out what's going on?

@RadBuilder

This comment has been minimized.

Show comment
Hide comment
@RadBuilder

RadBuilder Oct 22, 2017

Hello, I'm a contributor in the UltraCosmetics repository and would like to figure out what's going on. Unfortunately, I can't reproduce the issue you're describing.
2017-10-21_21 59 46

RadBuilder commented Oct 22, 2017

Hello, I'm a contributor in the UltraCosmetics repository and would like to figure out what's going on. Unfortunately, I can't reproduce the issue you're describing.
2017-10-21_21 59 46

@mcmonkey4eva

This comment has been minimized.

Show comment
Hide comment
@mcmonkey4eva

mcmonkey4eva Oct 22, 2017

Member

@RadBuilder the OP mentions it's specifically: Slimes, Spiders, Zombies.
Which seems to match the entity set you've customized in: https://github.com/iSach/UltraCosmetics/tree/master/v1_11_R1/src/main/java/be/isach/ultracosmetics/v1_11_R1/customentities
I notice your registration of these ( https://github.com/iSach/UltraCosmetics/blob/master/v1_11_R1/src/main/java/be/isach/ultracosmetics/v1_11_R1/customentities/CustomEntities.java#L119 ) is marked with TODO's and weird error handlers..

Member

mcmonkey4eva commented Oct 22, 2017

@RadBuilder the OP mentions it's specifically: Slimes, Spiders, Zombies.
Which seems to match the entity set you've customized in: https://github.com/iSach/UltraCosmetics/tree/master/v1_11_R1/src/main/java/be/isach/ultracosmetics/v1_11_R1/customentities
I notice your registration of these ( https://github.com/iSach/UltraCosmetics/blob/master/v1_11_R1/src/main/java/be/isach/ultracosmetics/v1_11_R1/customentities/CustomEntities.java#L119 ) is marked with TODO's and weird error handlers..

@RadBuilder

This comment has been minimized.

Show comment
Hide comment
@RadBuilder

RadBuilder Oct 22, 2017

Custom entities are registered here: CustomEntities.java#L84. The one you tagged was unregistering the custom entities, which is no longer needed since the server should be shutting down anyways. We do restore the entity id to the original entity here: CustomEntities.java#L87, so the issue described shouldn't be happening.

Upon testing again with the mobs specified, they naturally spawn without any issues.
2017-10-21_22 28 05

@Ghostlyr What version of UltraCosmetics are you using?

RadBuilder commented Oct 22, 2017

Custom entities are registered here: CustomEntities.java#L84. The one you tagged was unregistering the custom entities, which is no longer needed since the server should be shutting down anyways. We do restore the entity id to the original entity here: CustomEntities.java#L87, so the issue described shouldn't be happening.

Upon testing again with the mobs specified, they naturally spawn without any issues.
2017-10-21_22 28 05

@Ghostlyr What version of UltraCosmetics are you using?

@RadBuilder

This comment has been minimized.

Show comment
Hide comment
@RadBuilder

RadBuilder Oct 24, 2017

@Ghostlyr any updates on this issue? What version of UltraCosmetics are you using?

RadBuilder commented Oct 24, 2017

@Ghostlyr any updates on this issue? What version of UltraCosmetics are you using?

@Ghostlyr

This comment has been minimized.

Show comment
Hide comment
@Ghostlyr

Ghostlyr Oct 26, 2017

Sorry for the wait. As I already wrote above, the problem occurs only under natural spawn. Not when spawned by egg or command summoning or on chunk generation.

Please repeat the tests, taking into account this information.

image

As you can see, in the screenshot I'm getting damage. It was an invisible spider.

UltraCosmetics-2.4.9-RELEASE
citizens-2.0.22-SNAPSHOT b1​49​6

Unfortunately, in the near future I can not check on newer MC versions.

Ghostlyr commented Oct 26, 2017

Sorry for the wait. As I already wrote above, the problem occurs only under natural spawn. Not when spawned by egg or command summoning or on chunk generation.

Please repeat the tests, taking into account this information.

image

As you can see, in the screenshot I'm getting damage. It was an invisible spider.

UltraCosmetics-2.4.9-RELEASE
citizens-2.0.22-SNAPSHOT b1​49​6

Unfortunately, in the near future I can not check on newer MC versions.

@RadBuilder

This comment has been minimized.

Show comment
Hide comment
@RadBuilder

RadBuilder Oct 26, 2017

As noted in my previous response, they naturally spawn without any issues. I have tried to reproduce the problem but haven't had any success.

RadBuilder commented Oct 26, 2017

As noted in my previous response, they naturally spawn without any issues. I have tried to reproduce the problem but haven't had any success.

@Ghostlyr

This comment has been minimized.

Show comment
Hide comment
@Ghostlyr

Ghostlyr Oct 26, 2017

I can not imagine what is special in my environment so that issue is reproduced only for my servers. Completely clean - default configs, only 2 plugins, clean mc client.

However, I was able to check problem on the 1.12.2 server & mc versions - all fine, no invisible entities found. Any assumptions what makes the conflict only on one version?

Ghostlyr commented Oct 26, 2017

I can not imagine what is special in my environment so that issue is reproduced only for my servers. Completely clean - default configs, only 2 plugins, clean mc client.

However, I was able to check problem on the 1.12.2 server & mc versions - all fine, no invisible entities found. Any assumptions what makes the conflict only on one version?

@RadBuilder

This comment has been minimized.

Show comment
Hide comment
@RadBuilder

RadBuilder Oct 27, 2017

I'm not sure, they seem to spawn fine for me.

RadBuilder commented Oct 27, 2017

I'm not sure, they seem to spawn fine for me.

@fullwall

This comment has been minimized.

Show comment
Hide comment
@fullwall

fullwall Mar 15, 2018

Member

Assuming this is a plugin conflict, please reopen if it is still an issue.

Member

fullwall commented Mar 15, 2018

Assuming this is a plugin conflict, please reopen if it is still an issue.

@fullwall fullwall closed this Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment