New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT GIVE HEADS #1600

Open
andfont opened this Issue Oct 26, 2018 · 11 comments

Comments

Projects
None yet
2 participants
@andfont

andfont commented Oct 26, 2018

We can not assign heads, I perform the process that I have always done, npc select, npc equip and then I give it the head but it does not accept it and it does not assign it, please fix this bug thanks!

version Citizens 2.0.24-SNAPSHOT (build Unknown)

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Oct 26, 2018

A: You can use helmet (type it in chat while in the equipment editor) to put any item on an NPC's head (even if it doesn't normally recognize it)
B: You're running some unknown/custom build of Citizens. Grab an official build here: http://ci.citizensnpcs.co/job/Citizens2/

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Oct 26, 2018

@fullwall looks like skull support was accidentally dropped in the 1.13 updates from the list here:
https://github.com/CitizensDev/Citizens2/blob/master/main/src/main/java/net/citizensnpcs/editor/GenericEquipper.java#L82
1.12 item name was SKULL_ITEM,
1.13 item names are PLAYER_HEAD, DRAGON_HEAD, CREEPER_HEAD, ZOMBIE_HEAD, SKELETON_SKULL, and WITHER_SKELETON_SKULL

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

It happens to me with the official version for that reason I am looking at the code to fix it but this error happens in the latest version of citizen there is no way to put a head in a ALDEANO for example as I could do before. when it is solved you tell me friend xD

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Oct 26, 2018

@andfont again, type helmet in chat with the equipment editor open while holding the head

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

ooo ok now yes thanks! I already got it okk XD

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

the heads personalized with TEXTURES do not work out badly !, only works the ones that OWNER has but not those of https://minecraft-heads.com/ for example it does not accept them :(

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Oct 26, 2018

Do you mean the skin is lost from the player head item, or the item doesn't go on the NPC at all?

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

the texture is lost, the head is not maintained but the texture is lost, the skin is lost, but the exact head is not lost

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

the head is not lost, but if the texture

@andfont

This comment has been minimized.

andfont commented Oct 26, 2018

but it is lost when you restart the server, at first it is maintained but when restarting it loses the texture of: https://minecraft-heads.com/

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Oct 26, 2018

That's an additional issue that will also need to be addressed, then.

@fullwall likely the CitizensAPI item persistence/storage system needs to be updated for 1.13 NBT structures. In particular for this issue, skull handling: https://github.com/CitizensDev/CitizensAPI/blob/master/src/main/java/net/citizensnpcs/api/util/ItemStorage.java#L162 needs to be updated. Looks like for the PlayerHead 1.13 item, there's the root level NBT key SkullOwner (whereas that 1.12 code seems to reference skull.owner as the key name) - likely other related key names are changed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment