New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citizens NPC Player heads stuck facing upward after battling phantoms even after fixing pitch/yaw in saves #1623

Open
axemwa opened this Issue Nov 30, 2018 · 26 comments

Comments

Projects
None yet
4 participants
@axemwa

axemwa commented Nov 30, 2018

Citizens NPC Player heads stuck facing upward after battling phantoms even after fixing pitch/yaw in saves.yml

The output of command /version on my server is: (This server is running Paper version git-Paper-469 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT))

The output of command /version citizens on my server is: (Citizens version 2.0.24-SNAPSHOT (build 1592))

@axemwa axemwa changed the title from Citizens NPC Player heads stuck facing upward after battling phantoms to Citizens NPC Player heads stuck facing upward after battling phantoms even after fixing pitch/yaw in saves Nov 30, 2018

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Nov 30, 2018

Which NPC (id number) are you referring to? (There's a lot of them saved there)
Can you provide a screenshot of the how the NPC appears in game?

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

The Guards with the 'joymo' skin NPC '72' and '157'

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

image

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

ID is mentioned above

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Nov 30, 2018

Can you try using /npc lookclose to make the NPC look at you? Does that fix their head direction?

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

I did, but it only works if I turn path/waypoints off which stops them walking in the paths I chose and when I walk away out of lookclose range and they fight the phantoms again their heads stuck looking up again

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Nov 30, 2018

So:
To clarify my understanding: when they're walking around, the pitch (up/down angle) of their heads is stuck in place as whatever it was last forced into (in this case by fighting with something above them)?

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

Yeah that's correct :)

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

And if lookclose is on they do look at you but as soon as u leave, the npc head looks up again

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Nov 30, 2018

This commit: 9f9647a may be relevant here.

@axemwa

This comment has been minimized.

axemwa commented Nov 30, 2018

Maybe, it does mention the pitch. I'm new to plugin development only made 1 plugin so far so not too good at reading code yet lemme know if there anything else I can do to help

@Florenthz

This comment has been minimized.

Florenthz commented Dec 3, 2018

Hi there.., Im here because I have the same problem... When I use /npc create "name"
a npc appears but he doesnt move the head... And I have lookclose enabled with 10 radius

@mergu

This comment has been minimized.

Contributor

mergu commented Dec 3, 2018

@axemwa

This comment has been minimized.

axemwa commented Dec 3, 2018

Hi there.., Im here because I have the same problem... When I use /npc create "name"
a npc appears but he doesnt move the head... And I have lookclose enabled with 10 radius

@Florenthz
Did u try both enabling lookclose in config aswell as activating it with the command "/npc lookclose"?

@Florenthz

This comment has been minimized.

Florenthz commented Dec 4, 2018

@mergu I found this friend:

03.12 18:46:09 [Server] INFO Florenthz issued server command: /citizens reload
03.12 18:46:09 [Server] WARN java.lang.IllegalArgumentException: unable to find valid entity superclass for class class net.citizensnpcs.nms.v1_13_R2.entity.WolfController$EntityWolfNPC
03.12 18:46:09 [Server] WARN at net.citizensnpcs.nms.v1_13_R2.util.NMSImpl.registerEntityClass(NMSImpl.java:800)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.util.NMS.registerEntityClass(NMS.java:222)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.npc.AbstractEntityController.(AbstractEntityController.java:16)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.nms.v1_13_R2.entity.MobEntityController.(MobEntityController.java:21)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.nms.v1_13_R2.entity.WolfController.(WolfController.java:29)
03.12 18:46:09 [Server] WARN at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
03.12 18:46:09 [Server] WARN at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
03.12 18:46:09 [Server] WARN at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
03.12 18:46:09 [Server] WARN at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
03.12 18:46:09 [Server] WARN at java.lang.Class.newInstance(Class.java:442)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.npc.EntityControllers.createForType(EntityControllers.java:20)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.npc.CitizensNPCRegistry.getByType(CitizensNPCRegistry.java:103)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.npc.CitizensNPCRegistry.createNPC(CitizensNPCRegistry.java:50)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.api.npc.SimpleNPCDataStore.loadInto(SimpleNPCDataStore.java:56)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.Citizens.reload(Citizens.java:362)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.commands.AdminCommands.reload(AdminCommands.java:44)
03.12 18:46:09 [Server] WARN at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
03.12 18:46:09 [Server] WARN at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
03.12 18:46:09 [Server] WARN at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
03.12 18:46:09 [Server] WARN at java.lang.reflect.Method.invoke(Method.java:498)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.api.command.CommandManager.executeMethod(CommandManager.java:155)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.api.command.CommandManager.execute(CommandManager.java:87)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.api.command.CommandManager.executeSafe(CommandManager.java:183)
03.12 18:46:09 [Server] WARN at net.citizensnpcs.Citizens.onCommand(Citizens.java:238)
03.12 18:46:09 [Server] WARN at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
03.12 18:46:09 [Server] WARN at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:139)
03.12 18:46:09 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:699)
03.12 18:46:09 [Server] WARN at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1648)
03.12 18:46:11 [Multicraft] Skipped 44 lines due to rate limit (30/s)

@Florenthz

This comment has been minimized.

Florenthz commented Dec 4, 2018

@axemwa Yeah... I have enabled lookclose and path but when I create a new npc, only move the head the first second, and when I asign a path, npc only walks every that I change him a new skin... Do i have to go to discord group?

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Dec 4, 2018

@Florenthz post a new issue, don't post on this one (your issue has no relation to this issue thread)

@Florenthz

This comment has been minimized.

Florenthz commented Dec 4, 2018

Ok sorry... Im new in Github

@Florenthz

This comment has been minimized.

Florenthz commented Dec 4, 2018

Its ready:
#1626

@axemwa

This comment has been minimized.

axemwa commented Dec 4, 2018

@axemwa Yeah... I have enabled lookclose and path but when I create a new npc, only move the head the first second, and when I asign a path, npc only walks every that I change him a new skin... Do i have to go to discord group?

I'm pretty sure if an NPC has a path it's normal for lookclose not to work

@axemwa

This comment has been minimized.

axemwa commented Dec 9, 2018

@mcmonkey4eva Do you know whether or not citizens are supposed to shoot tipped arrows? I noticed this when my NPC's were attacking mobs with arrows, it seems like the arrows have effects on them. Was wondering if this was a citizens issue or not and whether if it's worth making and issue report about it if it is?

image

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Dec 9, 2018

@axemwa that'd be a Sentinel issue if they're being fired by Sentinel, and that generally happens if you gave the NPC tipped arrows to shoot.

@axemwa

This comment has been minimized.

axemwa commented Dec 9, 2018

Hmm the NPC's don't currently have any tipped arrows in their inventory, just normal ones. I gave some to them in the past but I've removed then since then, is it possible a mob such as a skeleton could have fired it, but even then they only shoot normal arrows don't they so maybe not?

@axemwa

This comment has been minimized.

axemwa commented Dec 16, 2018

@mcmonkey4eva is there a command or option in config where you can set a cooldown between individual NPC chat/messages

@mcmonkey4eva

This comment has been minimized.

Member

mcmonkey4eva commented Dec 16, 2018

@axemwa I have no idea what that question is asking in the context of this issue.
If that question has no relation to this issue, ask on Discord https://discord.gg/Q6pZGSR or a separate issue

@axemwa

This comment has been minimized.

axemwa commented Dec 16, 2018

sorry it was in no relation to this issue I was asking off topic but u right I should use discord instead for off topic questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment