New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC skins turning into Steve/Alex #1632

Open
Scabista opened this Issue Dec 10, 2018 · 20 comments

Comments

Projects
None yet
6 participants
@Scabista
Copy link

Scabista commented Dec 10, 2018

  • Citizen player skins seem to load/unload, player side randomly. This will turn them into, or load them as steve/alex. Some players seem to report it happens more for npcs that are further away when they enter an area with npcs.

  • https://gist.github.com/Scabista/c20c9534862ff2ae5c9f4b67a210f13f (No related console errors, or output)

  • FOR LAG RELATED ISSUES: 35g memory. 100ish global npcs.

The output of command /version on my server is: https://imgur.com/jXJ6XD3
The output of command /version citizens on my server is: https://imgur.com/a/P3bNGeG

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

mcmonkey4eva commented Dec 10, 2018

Both your Spigot jar and your Citizens jar are a bit outdated. Should probably update them both to start.

Some info on this wiki page might be relevant: https://wiki.citizensnpcs.co/Skins
But if I understand correctly it sounds like you're encountering an issue we've had in the past but that hasn't been reported in a while. I don't know offhand if it was ever completely fixed.

@Scabista

This comment has been minimized.

Copy link

Scabista commented Dec 11, 2018

I'm running a 1.12.2 server, not 1.13+. We use over 100 plugins, and some do not work yet with 1.13. I was sure I updated to the correct version of citizens, for that, no?

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

mcmonkey4eva commented Dec 11, 2018

Run latest Citizens and latest Spigot 1.12.2

I didn't say update Minecraft, that's not required at the moment (1.13 is still new and is a tough change so we fully dual-support 1.12.2 and 1.13.2)

Citizens2 latest: http://ci.citizensnpcs.co/job/Citizens2/
Spigot latest: https://www.spigotmc.org/wiki/buildtools/ (java -jar BuildTools.jar --rev 1.12.2)

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 14, 2018

I get this problem aswell in current latest dev/jenkins builds of citizens in 1.13.2 and I have to use /citizens reload to fix the skins. Sometimes the skins will fix them selves when either facing them at a certain angle or leaving and reentering the chunk

@LeafyMitsuwa

This comment has been minimized.

Copy link

LeafyMitsuwa commented Dec 14, 2018

I have encountered this issue as well on a small lobby I happened to be OP in.

The lobby itself is approx 12 chunks in width.
In the center of this lobby, is an NPC with a santa skin.

I've seen it happen where, by simply idling, the skin of this NPC would revert to Steve, and moments later, would be back to the intended skin -- without reloading citizens.

These changes always happen when I do not see the NPC itself, it simply comes into field of view with either its skin, or the Steve skin, and a few loops later, usually has its original skin back.

The server is running bungee.
The Lobby uses viaforward, and I am usually on there using a 1.13.2 client.

/version of the lobby.
This server is running CraftBukkit version git-Spigot-dcd1643-e60fc34 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
This is a final build for 1.12.2. Please see https://www.spigotmc.org/ for details about upgrading.

/citizens
=====[ Citizens v2.0.22-SNAPSHOT (build 1487) ]=====
-- Written by fullwall and aPunch
-- Source Code: http://github.com/CitizensDev
-- Website: http://www.citizensnpcs.co

I'll update to latest citizens, and see if issue persists.

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

mcmonkey4eva commented Dec 14, 2018

@LeafyMitsuwa you're running a version of Citizens that's about 1.5 years old now.

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 16, 2018

This is what it's doing for me
https://youtu.be/T7hmV-yu6LY

@Scabista

This comment has been minimized.

Copy link

Scabista commented Dec 16, 2018

As far as I can tell, I'm fully updated. The issue still persists.

https://i.imgur.com/7nQJkhF.png

@fullwall

This comment has been minimized.

Copy link
Member

fullwall commented Dec 16, 2018

What is the citizens output when debug-mode is turned on in the config

@Scabista

This comment has been minimized.

Copy link

Scabista commented Dec 17, 2018

Reload usually corrects it, at least for the person using the command, This isn't a fix though. What npcs have skin issues is player side, so some players may rarely experience the problem, while others get it more often. A player may see a npc with their skin, while another will see the same npc with a Steve/Alex skin.
Seems plenty of people have this issue, not just myself.

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 18, 2018

Here's my latest log of server start and stop with debug enabled.
The next time the NPC skins aren't showing I will update the latest.log link
The link below just shows the output after starting and stopping the server

https://pastebin.com/xYwYdVQA

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 19, 2018

Heres a log when the npc skins weren't working/applying on NPCs https://pastebin.com/HH2dKnZT
I didn't notice much difference in the log from when the skins were working/applied
Leaveing and re-entering the chunk brings the skins back
Another note, this is all in a WG region

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 19, 2018

On another note when this message apppeared in console
Spawned id 159 due to chunk event at [-12,15]
if those are co-ordinates x & y I tp'd there and there's nothing there that looked abnormal

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

mcmonkey4eva commented Dec 19, 2018

Those are chunk coordinates (not block coordinates)
Which NPCs (names+skinnames+IDs) were missing skins?
At what point during that log (throughout the time the server was running, or only for part of it?)

edit: please also pastebin your Citizens/saves.yml file

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 19, 2018

Pretty sure it was ALL of the NPC's in that chunk that were missing textures for their skin.

The NPC's were

image

I thought I'd also mention that all those NPCs are inside the main "world" spawn area which chunk stays loaded (that area is also in a worldguard region called spawn)

Will link the saves.yml in a sec

@axemwa

This comment has been minimized.

Copy link

axemwa commented Dec 19, 2018

Here's my saves.yml

EDIT - Also thought I'd mention the npcs with actual player names are from the statusblock plugin and weren't made with the /npc create command

@Scabista

This comment has been minimized.

Copy link

Scabista commented Dec 28, 2018

I wonder if this issue could have anything to do with having the free version?

@mergu

This comment has been minimized.

Copy link
Contributor

mergu commented Dec 28, 2018

It doesn't. There is no 'premium' version of Citizens.

From the spigot page:
This is posted as a premium resource to motivate the continued development of the plugin. If you would not like to contribute to development you are welcome to download the same versions for free here but please read 'Why premium?' below for more information.

@Scabista

This comment has been minimized.

Copy link

Scabista commented Jan 13, 2019

Just thought I'd mention this is still an issue.

@mergu

This comment has been minimized.

Copy link
Contributor

mergu commented Jan 13, 2019

So I can actually fairly reliably replicate skin loading issues in Citizens:

  • Spawn an npc, equip a skin to it, walk straight back in a line watching it until it despawns
  • Mark the despawn boundary
  • If you walk inside the boundary while looking at the npc, loads fine every time:

image

  • If you walk backwards (or straight down) into the boundary then turn to look at the npc, skin is usually steve/alex:

image

So seems to have something to do with players not receiving the skin if they're not directly looking at the npc when it's spawned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment