Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npc glowing issue #1852

Open
Sean1472 opened this issue Jul 3, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@Sean1472
Copy link

commented Jul 3, 2019

Hello, I've recently been using your citizen's plugin and the glow effect returns null whenever I type anything after "/npc glowing -- color [COLOR]". Whatever colour I try, RED, &4, 4, it always says "null".

I have found a solution (Temporary).

You can create a team, add the villagers to it and modify the glow colour which works. The only downside is citizens resets the glow colour on server restart so the team won't work properly and goes back to white.

Is there a way to possibly save the glowing colour / team issue?

The output of command /version on my server is: git paper-624 1.13.2
The output of command /version citizens on my server is: 2.0.25-Snapshot build 1717

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Please post the exact command(s) that you tried in full, and the details of what NPC you were trying them on (third line indicates it may be specifically villagers?). Have you tried on other entity types (like player-type NPCs?)

@Sean1472

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Thanks for the reply.

I've tried the command /npc glowing --color RED, returns null, older versions actually return the correct colour in chat but doesn't change the NPC colour.

Tested with villagers and normal player NPCs.

This was also tested on a clean server, no other plugins

Tried respawning the NPC and that did not help either.

@Sean1472

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Also, a side note;
When I type /npc glowing --color red, while the player NPC is selected, it modifys the config properly but the glow in-game doesn't visually change despite the config changing.

Also, I reloaded citizens and restarted the server during testing with multiple different config changes to test.

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Do you have any other plugins or settings that may alter your server's scoreboards?
Citizens glowing functionality (alongside longer name functionality and some other stuff) does require that Citizens be able to control the scoreboard - this most often gets broken when plugins like sidebars and tablist changers and such choose to irrelevantize the main server scoreboard

@Sean1472

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

Just to reiterate, it was tested on a clean server with just Citizens on it.

The command to change the glow color only runs properly on PLAYER type NPC's. On all other mob types, it just returns null in the chat with no config changes. Even though the config has a glowing-color option set, the visual glow around the NPC remains white no matter what. I've even tested this on a 1.9 server running citizens 2.0.18 to see if maybe going far back would do anything and the same results. The in-game color doesn't change despite /citizens reload and server restarts.

@fullwall

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Try the latest build. When you say it returns "null" usually that means you need to delete the lang folder in the plugins folder.

@Sean1472

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

Thanks for the reply. I just downloaded the latest build (build 1727) and the same issue occurs.
Screenshot here for player and villager types;
https://imgur.com/ug7YjOH
As you can see, setting it to a villager and changing colour returns null, setting it to a player and changing colours returns the right colour but the glow colour still stays white in-game.

I also got this error when changing an NPC from a villager to a player type.
[18:05:36 ERROR]: [Citizens] An exception occurred while the trait inventory was spawning for NPC ID 0. [18:05:36 WARN]: java.lang.ArrayIndexOutOfBoundsException: 8 [18:05:36 WARN]: at net.citizensnpcs.api.trait.trait.Inventory.setContents(Inventory.java:195) [18:05:36 WARN]: at net.citizensnpcs.api.trait.trait.Inventory.onSpawn(Inventory.java:90) [18:05:36 WARN]: at net.citizensnpcs.npc.CitizensNPC.spawn(CitizensNPC.java:281) [18:05:36 WARN]: at net.citizensnpcs.npc.CitizensNPC.setEntityController(CitizensNPC.java:196) [18:05:36 WARN]: at net.citizensnpcs.npc.CitizensNPC.setBukkitEntityType(CitizensNPC.java:183) [18:05:36 WARN]: at net.citizensnpcs.commands.NPCCommands.type(NPCCommands.java:1998) [18:05:36 WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [18:05:36 WARN]: at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) [18:05:36 WARN]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) [18:05:36 WARN]: at java.lang.reflect.Method.invoke(Unknown Source) [18:05:36 WARN]: at net.citizensnpcs.api.command.CommandManager.executeMethod(CommandManager.java:155) [18:05:36 WARN]: at net.citizensnpcs.api.command.CommandManager.execute(CommandManager.java:87) [18:05:36 WARN]: at net.citizensnpcs.api.command.CommandManager.executeSafe(CommandManager.java:183) [18:05:36 WARN]: at net.citizensnpcs.Citizens.onCommand(Citizens.java:263) [18:05:36 WARN]: at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) [18:05:36 WARN]: at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:151) [18:05:36 WARN]: at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:734) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1783) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1591) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:15) [18:05:36 WARN]: at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [18:05:36 WARN]: at java.util.concurrent.FutureTask.run(Unknown Source) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:108) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1018) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:940) [18:05:36 WARN]: at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:837) [18:05:36 WARN]: at java.lang.Thread.run(Unknown Source)

As a side note: This was a fresh install of Citizens. No previous files were used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.