Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakblock API does not propperly update the waypoint when the previous breakblock command is completed but the npc is still pathing #2017

Open
1thebeast opened this issue Jan 5, 2020 · 1 comment

Comments

@1thebeast
Copy link

@1thebeast 1thebeast commented Jan 5, 2020

the issue im having is related to the breakblock API
from denizen im using the break command which in turn calls the api
the problem i ran into is that when another break command is issued before the last one finishes the npc sometimes gets stuck
i think the cause is that the task is marked as finished when the block is broken but the npc might still be pathing towards the block (it pathes towards the block itself, not the location where it gets in range) so when the next break action is assigned its waiting for the target block to get in range but the waypoint doesnt get updated(my assumption is its added to the list but cleared when the npc arives at the first waypoint) so the npc is stuck waiting for the block to get in range until i reload citizens

The output of command /version on my server is:
"This server is running CraftBukkit version git-Spigot-492a779-c727dc2 (MC: 1.15.1) (Implementing API version 1.15.1-R0.1-SNAPSHOT)"
The output of command /version citizens on my server is:
Citizens version 2.0.26-SNAPSHOT (build 1802)

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

@mcmonkey4eva mcmonkey4eva commented Jan 5, 2020

The most literal solution to this would be to ensure BlockBreakerConfiguration#callback waits for pathing to complete, but the more proper solution would likely to be to make the NPC stop navigation immediately after breaking a block, right before the callback is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.