Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skin default and npc invisable #223

Closed
Cammo009 opened this issue Jan 27, 2015 · 62 comments
Closed

skin default and npc invisable #223

Cammo009 opened this issue Jan 27, 2015 · 62 comments
Labels
Bug Report A bug was reported.

Comments

@Cammo009
Copy link

Hi Citizer, im am running a spigot 1.8 server and having issues with the citizen2 2.0.14 that some skins default to steve skin and sometimes the Npc's can disappear and not come back when out of chunk ratious and then return back. sometimes i cant see them when login in and have to relog 2 to 3 times.

when npc is invisable you can still select them. There is no error in console, just these smal issues.

Chris

@koatheraiser
Copy link

Same issue here,
Skins (no matter if set by name or by /npc skin) revert to default, unless I use /citizens reload, and that only works if the NPC is in my line of sight. No errors in console as well.

Running Spigot (spigot_1.8_899f5ee-1092acb) and the latest Dev of Citizens2.

Good luck. Love the plugin, would be great to see this working.

@CKGAR
Copy link

CKGAR commented Feb 4, 2015

Confirmed.

@ZenTauren
Copy link

I'm having this problem too, i'm using dtlTraders and players get so confused when the traders are not there all of a sudden, they come back when you write /citizens reload. Sometimes they are there and sometimes not.

@BogiAtanasov
Copy link

Its getting pretty annoying :/ Got the same problem as everyone else.. NPCs dissapearing or changing to default skin whenever they want. Dont let this plugin die.. if you have to transfer to Spigot and make it paid do it, but just let it die

@noorkoteb
Copy link

when will the next update be expected come out?

@mcmonkey4eva
Copy link
Member

Our lead dev is MIA currently, working on waking him... I've personally no idea what to do with this bug, as I can't replicate it at all.

@gdude2002
Copy link

Can confirm this one - it seems that if the NPC is placed, it has the skin, but moving far enough away that it's unloaded client-side or changing world and coming back leaves it with the Steve skin

@pixelbat
Copy link

Experiencing this too. If mcmonkey4eva can't replicate it, I wonder what we all have in common, and if it's another plugin we have conflicting?

List of my plugins... AsyncWorldEdit, Citizens, CommunityBridge, Dynmap, Essentials, EssentialsChat, EssentialsSpawn, getUUID, Multiverse, Multiverse Portals, PermissionsEx, TimeShift, Titlemotd, WorldEdit, WorldGuard

@pixelbat
Copy link

Another thought... what version of Java are you folks running for your client? I only ask because I was using 8, then just went ahead and switched my client to use 7, and I haven't been able to replicate the issue yet.

@gdude2002
Copy link

@pixelbat I'm using Java 8 on both the client and server, as far as I can tell. Haven't had a chance to test otherwise, though.

@pixelbat
Copy link

Spoke too soon, started happening with Java 7.

@noorkoteb
Copy link

well is there a way to save someones skin when they join and update it every 12hrs, because the problem is probably it trying to connect with the mojang servers due to 1.8 update. and with the saved skin it can just load from there and ignore mojang checks?

@gdude2002
Copy link

No, as far as I know, the client will only check Mojang's servers for updated skins.

Besides, as far as I know, it caches them until you restart the client.

@mcmonkey4eva
Copy link
Member

Actually, in modern MC, the server is the one that pings Mojang's server for skin files, and it /does/ cache skins currently.

@gdude2002
Copy link

Huh, that seems like a new thing, then. When did they add that? lol

@mcmonkey4eva
Copy link
Member

MC 1.7.6 was the first version to do this. It's also when issues like this one started appearing. This change in MC's code broke so much @.@

@noorkoteb
Copy link

that sucks is there anyway to get around it? will this ever be fixed?

@pixelbat
Copy link

No it will never get fixed because the devs can't replicate it, when the rest of the world can.

@gdude2002
Copy link

If the devs can't replicate it then there's something different in their testing environment.

Either way, I wouldn't dismiss them so easily - they make a great plugin, and are clearly trying their best.

@pixelbat
Copy link

@gdude2002 well the issue isn't exactly new. If you look at issues open and closed, it's been reported like over a dozen times, and dating as far back as Oct. It is a great plugin, but I find it hard to believe that this can't be replicated when so many other people can. Getting it replicated should be pretty easy with the assistance of the community. In the name of getting this fixed I'd be willing to share my server with the devs, where it is replicated.

@gdude2002
Copy link

Maybe it would be easier if @mcmonkey4eva could explain their testing environment?

@calico-kid
Copy link

i had this issue but it was due to an outdated plugin.... havnt had the issue since... it was caused by my essentials i had to update to the latest one for spigot... i am running the latest on all builds and havnt had a problem since

@pixelbat
Copy link

@calico-kid hmmm, I also use Essentials. Are you using this version? https://hub.spigotmc.org/jenkins/job/Spigot-Essentials/

That's what I have and I'm having the issue. Are you using any of the other Essential plugins?

@calico-kid
Copy link

yeah thats the version i have... i dont use essentials anticheat or any of the others... i mainly only use it for warps atm since my server is in dev still might try removing the rest of the essentials kit and see if that changes anything... on a local test server of course...

@pixelbat
Copy link

Will give it a shot. I am using Essentials, Essentials Antibuild, Essentials Spawn, and Essentials Chat. Anyone else with the issue also using any of these 3 Essentials mods?

@gdude2002
Copy link

I'm using Essentials with Chat and Antibuild, yep.

@pixelbat
Copy link

Can't imagine Chat causing an issue, but maybe Antibuild. I don't even use it anymore, I'm gonna ditch it and see if that fixes my issue. I'll post back soon.

@calico-kid
Copy link

i would think more like spawn would be the major issuer... but antibuild could do it too

@CKGAR
Copy link

CKGAR commented Feb 17, 2015

I have already confirmed it wasn't AntiBuild, and I'm running the same version as you guys. I am having a hard time believing this has anything to do with Essentials.

@calico-kid
Copy link

plugins do conflict at times... testing is important to be able to get a definite answer. twice now this has happened with different plugins for me both recently and early on @CKGAR

@calico-kid
Copy link

Seems as though this may be a respawn issue with the chuncks ill try it out again with all the latest build and see if i can replicate this... Is there anything else being used aside from base minecraft and citizens on your test servers? Eg forge or any other mods?

Sent from my iPhone

On Feb 18, 2015, at 8:50 AM, Kristoff notifications@github.com wrote:

@pixelbat Ditto.


Reply to this email directly or view it on GitHub.

@pixelbat
Copy link

No.

@BogiAtanasov
Copy link

Same problem as well, i figured that the command /butcher removes NPCs which are (mobtype), dunno how the Player NPCs dissapear tho.

@noorkoteb
Copy link

this only happens to ppl who leave the npc when i tried this on my server my friend didn't move and he can still see the skin, but i left and came back i couldn't see the skins. when i disconnected and reconnected i could see it again. i believe this might be a communication issue with the players client.

@whoshenry
Copy link

Is this issue going to be fixed at all? I am still getting this issue even when using the latest Dev Build of Citizens 2.0.15 which claims the following: http://prntscr.com/6j1hl5

I am also using the latest ProtocolLIB so I'm not sure what's the issue here.

@mcmonkey4eva
Copy link
Member

https://dl.dropboxusercontent.com/u/54130586/Citizens-2.0.15-SNAPSHOT.jar does this build help anyone else? Myself and another server owner are unable to replicate it in this build.

@whoshenry
Copy link

@mcmonkey4eva Still occurs on world change and when joining to begin with, using latest Spigot and ProtocolLIB.

Yes, still testing thoroughly and it occurs on world-change and when visiting different areas, the skins don't always load up correctly and just show the default skins.

Do you recommend a certain build to use for ProtocolLIB or anything else that could be causing this issue?

@mcmonkey4eva
Copy link
Member

@whoshenry protocollib isn't relevant. And try again, I updated the file in the link to catch a few more situations, including world change

@whoshenry
Copy link

@mcmonkey4eva This version you uploaded seems to be so much better. From constant world changing/flying around I've only experienced it a handful of times, but just going a little further away and coming back, they seem to load properly. I will keep testing it but this version is much better.

World changes seems to be fixed also. Just loads the skin a second or 2 after you have teleported which is perfectly fine.

Update: I am still experiencing a few skin-loss NPCs but not as many as before.

@Cammo009
Copy link
Author

Cammo009 commented Apr 7, 2015

@mcmonkey4eva

So what build do we need again for the fix? #1224

@mcmonkey4eva
Copy link
Member

There are some problems on the current builds, use the Dropbox build linked above for the fix for now. In theory, the next successful build (IE, not marked with a red dot) will probably be functional too.

@mcmonkey4eva
Copy link
Member

Update: #1227 is now available and functional

@BogiAtanasov
Copy link

Eh, I thought everything is fixed..
All of the latest dev builds dont work for 1.8
Thats why I updated Spigot to 1.8.3 .. But the skin gets removed again.. after teleporting away. ( Latest dev build. )

And is it possible to make the latest dev version to be working with 1.8, since the majority of server owners still havent updated, cuz lots of plugins get a decent amount of bugs on 1.8.3?

@mcmonkey4eva
Copy link
Member

We build for latest, that's all there is to it. We're not going to maintain two separate versions of one plugin.
Also, can you provide some evidence that you're running latest dev build and still getting skin troubles? (EG, a video?) We need everything we can get if we're going to fix anything.

@BogiAtanasov
Copy link

Eh, I cant get a video tho.. But as much as I can
http://gyazo.com/ded2fdfaab50a24507ca11c3ac395785
http://gyazo.com/4ac9986f51fa246d73df015a9c604f03
http://imgur.com/T7wcHkc,3aVQWI7
The 2nd image was when I did /npc skin Notch
the 1st one, went 100 blocks away and came back to that.

@DNx5
Copy link

DNx5 commented Apr 9, 2015

that's not #1227

@BogiAtanasov
Copy link

Indeed its not, but that version should have the fix as well.. I'll try 1227 right now!

EDIT: The result is the same. Skin getting reset to default.

@DNx5
Copy link

DNx5 commented Apr 9, 2015

4d08915
^ that's the commit :D

@BogiAtanasov
Copy link

That commit was fixed in the 1227 wasnt it? If yes, still doesnt work.

@Morphan1
Copy link
Contributor

Morphan1 commented Apr 9, 2015

@Apotheosis1337 maybe a video/some more pictures for it failing on 1227?

@BobLorodeth
Copy link

I have been experiencing this issue and after the best testing I could manage it seems there is a difference between chunk loading and world loading to the plugin. When I reload the world, e.g use a portal, disconnect, use a warp, or use a TP the NPCs lose their skins. However, when I fly/walk away and come back (which reloads the chunk) their skins return( sometimes a few at a time and sometimes all at once)

Perhaps somebody would like to confirm my findings?

Hope this helps some,
-Bob

@Zerpixelt
Copy link

I have nearly the same problem, exept that I use "craftbukkit 1.7.9 R-0.2" and play with the "citizens 2.013" version. I can see capes, but I can't see any skins. And yes, I tried real playernames and also /npc skin (playername with skin), but nothing changed, just steves everywhere. I also deinstalled the whole server and put only citizens in the plugins-file, but also just ugly steves :P
Is there now any solution for this problem, because I need skins for my poor NPCs :(

@mcmonkey4eva mcmonkey4eva added the Bug Report A bug was reported. label Apr 25, 2015
@mcmonkey4eva
Copy link
Member

Skins working at all well on 1.8.6?

@noorkoteb
Copy link

ill try it out

it doesn't work on 1.8.6 http://screenshot.net/3l5gigw

@THEBIGSEB
Copy link

Can u put the link of the Update: #1227 plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report A bug was reported.
Projects
None yet
Development

No branches or pull requests