Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respa_exchange: Return proper error message if the user tries to PUT a Reservation managed in Exchange #231

Closed
Rikuoja opened this issue Feb 28, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Rikuoja
Copy link
Member

commented Feb 28, 2018

Currently, https://github.com/City-of-Helsinki/respa/blob/master/respa_exchange/signals.py#L24 returns an empty list if the existing reservation has managed_in_exchange=True. Therefore, https://github.com/City-of-Helsinki/respa/blob/master/respa_exchange/signals.py#L44 yields IntegrityError as documented by https://sentry.hel.ninja/aok/virkarespa/issues/5262/?referrer=slack

We should return HTTP 403 instead of HTTP 500.

@Rikuoja Rikuoja added the bug label Feb 28, 2018

@Rikuoja Rikuoja changed the title respa_exchange: Return proper error message if the user tries to edit a Reservation managed in Exchange respa_exchange: Return proper error message if the user tries to PUT a Reservation managed in Exchange Feb 28, 2018

@petterill petterill added the old stuff label Apr 17, 2018

@petterill petterill removed the old stuff label Apr 26, 2018

@petterill petterill closed this May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.