Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Error403 with SSR check and not found. #1176

Merged
merged 1 commit into from
May 23, 2024
Merged

Replace Error403 with SSR check and not found. #1176

merged 1 commit into from
May 23, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented May 15, 2024 •
edited

🛠️ Changelog

  • Replace Error403 with SSR check and 404 because Error403 requires a lot of custom code (redirections to custom pages etc.).
  • Add: comments to nextjs error pages.

🧪 Test plan

🎫 Tickets

  • TILA-XXXX

vincit-matu
vincit-matu approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joonatank joonatank force-pushed the add-error-403-page branch 2 times, most recently from ca80af9 to 478270f Compare May 22, 2024 10:17
@joonatank joonatank changed the title add: error 403 page Replace Error403 with SSR check and not found. May 23, 2024
@joonatank joonatank merged commit b9db783 into main May 23, 2024
6 checks passed
@joonatank joonatank deleted the add-error-403-page branch May 23, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joonatank @vincit-matu