Navigation Menu

Skip to content
This repository has been archived by the owner on Dec 27, 2019. It is now read-only.

Issue with upcoming events list #526

Closed
reillyzlab opened this issue Mar 17, 2017 · 17 comments
Closed

Issue with upcoming events list #526

reillyzlab opened this issue Mar 17, 2017 · 17 comments

Comments

@reillyzlab
Copy link
Contributor

reillyzlab commented Mar 17, 2017

Issue with upcoming events list. List isn't populating upcoming events on some content types. No disruption to lists already created/being used, but issues with list not displaying events when current list is edited or new list is added. Happens to new and pre-existing pages. Content contributor can select upcoming events list in back end of CMS, but when they save the 'draft' doesn't display any upcoming events.

Four options available to choose in list dropdown:
upcoming_events - Upcoming Events (top item in list) > This is the list that works/brings in upcoming events [this is functionally how this should work]
upcoming_events - Events (second to bottom item in list) > Seems to be non-functioning
upcoming_events - Upcoming Events (bottom item in list) > Seems to be non-functioning
upcoming_events - Master (top item in list on tabbed page) > Seems to work

Working fine on the following page types:
Article
Landing
Listing
How To
Public Notice
Tabbed

Not working on the following pages types:
Department profile
Event
Guide
Person
Place
Post
Program/Initiative
Script

@matthewcrist
Copy link
Contributor

@reillyzlab this should be the way it works. we can remove the others from the list.

@jimafisk
Copy link
Contributor

For my reference, upcoming_events is a list within the "List" component type:

upcoming_events

We need to

  1. Remove non-functioning, duplicate upcoming_events options from the dropdown
  2. Fix the main upcoming_events option that isn't working on the content types specified above

@jimafisk
Copy link
Contributor

The first issue (duplicated upcoming_events options)

misc_upcoming_events_options

is because the View "Upcoming Events" has several displays used for this throughout the site

view_displays

but the allowed value list for the component is set at the View level and not the display level

allowed_values

Proposed solution: Create a new view (or clone the original) and make the only display available be the default that is needed for this component. Reference that new view in the List component. @reillyzlab @matthewcrist would that work?

@reillyzlab
Copy link
Contributor Author

I defer to @matthewcrist on this

matthewcrist added a commit that referenced this issue May 3, 2017
Fix Issue #526 - Upcoming Events & Related Content
@matthewcrist matthewcrist assigned reillyzlab and unassigned jimafisk May 9, 2017
@matthewcrist
Copy link
Contributor

This is ready on staging

@reillyzlab
Copy link
Contributor Author

Leaving ticket because issue with entire ticket rather than one off issues.

This is not working on any content type. More specifically:

Was working on these content types when originally entered this ticket, but no longer working on:
Article
Landing
Listing
How To
Public Notice
Tabbed

Wasn't working before originally entered this ticket and still not working:
Department profile
Event
Guide
Person
Place
Post
Program/Initiative
Script

@matthewcrist
Copy link
Contributor

@reillyzlab I've been able to add upcoming events to all content types in Hub and Boston.gov. Can you include your testing steps?

@duffy-james
Copy link

duffy-james commented May 11, 2017

Seeing similar issues to Reilly:

  1. Logged into edit-stg.boston.gov
  2. Created the content type listed below.
  3. Filled out required fields.
  4. Added events component.

Here's the content types. I can go through all of them, but this is a start.

Article page: https://edit-stg.boston.gov/node/25421/edit
Department profile: https://edit-stg.boston.gov/departments/duffy-department-profile
Event: https://edit-stg.boston.gov/calendar/duffy-event

Also only seeing the "upcoming events" option in the list dropdown.

@matthewcrist
Copy link
Contributor

@jimafisk looks like the component won't display events unless you're an admin now. Can you take a look? This is a blocker.

@jimafisk
Copy link
Contributor

Removed node_access check on relationships in view. Let me know if it still gives you trouble. Thanks!

@duffy-james
Copy link

Just jumped into person profiles and program profiles and it still doesn't appear to be working.

I can run through the rest of the content types as well.

@matthewcrist
Copy link
Contributor

@jduffy2001 I just deployed the fixes to Boston.gov staging. You should be able to see them now.

@duffy-james
Copy link

duffy-james commented May 12, 2017

@reillyzlab
Copy link
Contributor Author

Closing b/c moved styling bug into: https://github.com/CityOfBoston/boston.gov/issues/668 (not blocker)

@reillyzlab
Copy link
Contributor Author

Not working on Hub

@reillyzlab
Copy link
Contributor Author

Now working on Hub, but major bug that should hold this push to production until fixed: https://github.com/CityOfBoston/boston.gov/issues/694

@reillyzlab
Copy link
Contributor Author

Resolved, closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants