Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that causes the unit summaries not to show up in the /listings view #259

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix the bug that causes the unit summaries not to show up in the /listings view #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb0032
Make unitsSummarized a Transform field within Listing
anders-schneider Jul 23, 2021
5360df5
Merge branch 'main' into aeschneider-unit-summary-table-fix
anders-schneider Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 13 additions & 6 deletions backend/core/src/listings/dto/listing.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,19 @@ export class ListingDto extends OmitType(Listing, [
yearBuilt?: number | null

@Expose()
@ApiProperty({ type: UnitsSummarized })
get unitsSummarized(): UnitsSummarized | undefined {
if (Array.isArray(this.units) && this.units.length > 0) {
return transformUnits(this.units as Unit[])
}
}
@IsDefined({ groups: [ValidationsGroupsEnum.default] })
@ValidateNested({ groups: [ValidationsGroupsEnum.default] })
@Type(() => UnitsSummarized)
@Transform(
(value, obj: Listing) => {
const units = obj.property.units
if (Array.isArray(units) && units.length > 0) {
return transformUnits(units)
}
},
{ toClassOnly: true }
)
unitsSummarized: UnitsSummarized | undefined
}

export class PaginatedListingsDto extends PaginationFactory<ListingDto>(ListingDto) {}
Expand Down