Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for StateTransaction and StateDescriptors #193

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@localhuman
Copy link
Collaborator

localhuman commented Jan 24, 2018

What current issue(s) does this address?, or what feature is it adding?

  • adds support for StateTransactions and StateDescriptors, which are now appearing on testnet due to changes in v2.6.0
  • read more here: #169

How did you solve this problem?

  • added StateTransaction and StateDescriptor

How did you make sure your solution works?

  • tests

Did you add any tests?

  • yes

Are there any special changes in the code that we should be aware of?

  • this changeset allows neo-python to function as normally when v2.6.0 nodes are on the network
  • this is not a full implementation of the new functionality, as a full implementation is not needed unless we are performing consensus
  • with that in mind, I will leave the issue open as these current changes do not fully solve the issue
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 24, 2018

Coverage Status

Coverage decreased (-0.06%) to 70.122% when pulling 2a7127f on feature-v260 into 12a0136 on development.

@metachris

This comment has been minimized.

Copy link
Collaborator

metachris commented Jan 24, 2018

👍 Awesome!

For reference, it fixes this error:
wallet-terminal

@metachris metachris merged commit 2200802 into development Jan 24, 2018
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.06%) to 70.122%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@localhuman localhuman deleted the feature-v260 branch Jan 24, 2018
metachris added a commit that referenced this pull request Jan 24, 2018
* development:
  changelog: start 0.4.7-dev entry
  symlink changelog into docs/source
  Bump version: 0.4.6 → 0.4.7-dev
  Bump version: 0.4.6-dev → 0.4.6
  Combine 2 changelogs into 1, and symlink into docs
  Bump version: 0.4.6 → 0.4.7-dev
  Bump version: 0.4.6-dev → 0.4.6
  Combine 2 changelogs into 1, and symlink into docs
  CHANGELOG: added recent additions to the dev branch
  Added support for StateTransaction and StateDescriptors (#193)
  remove PWDatabase singleton to allow multiple open sqlite databases at once
  Getting Started update (#178)
  added tests for new functionality
  adding ability to specify tx attrs with send command
  Incorporate feedback
  Make command responses more consistent
  Minor cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.