This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge CoZ Development into My Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ development into jseagrave21 development
I added block_index and blocktime to this method to help a user sort and filter the results. I am thinking this method will be particularly useful when sorting through transactions when filing taxes. Please let me know if you have any thoughts or recommendations. cc @localhuman @ixje |
I would prefer that any non standard RPC methods ( methods not implemented in |
Yep, I can make those changes. |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Adds
gettxhistory
RPC method which returns a list of every tx in the associated wallet in JSON format, including block_index and blocktimeThis PR helps address issue #189
How did you solve this problem?
Trial and Error.
How did you make sure your solution works?
Unittest
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)