Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add gettxhistory RPC method #614

Closed
wants to merge 11 commits into from

Conversation

jseagrave21
Copy link
Contributor

@jseagrave21 jseagrave21 commented Sep 18, 2018

What current issue(s) does this address, or what feature is it adding?
Adds gettxhistory RPC method which returns a list of every tx in the associated wallet in JSON format, including block_index and blocktime

This PR helps address issue #189

How did you solve this problem?
Trial and Error.

How did you make sure your solution works?
Unittest

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

Merge CoZ Development into My Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ development into jseagrave21 development
@coveralls
Copy link

coveralls commented Sep 18, 2018

Coverage Status

Coverage increased (+0.05%) to 80.283% when pulling b27a998 on jseagrave21:gettxhistory into cfc8361 on CityOfZion:development.

@jseagrave21
Copy link
Contributor Author

jseagrave21 commented Sep 18, 2018

I added block_index and blocktime to this method to help a user sort and filter the results. I am thinking this method will be particularly useful when sorting through transactions when filing taxes. Please let me know if you have any thoughts or recommendations. cc @localhuman @ixje

@localhuman
Copy link
Collaborator

I would prefer that any non standard RPC methods ( methods not implemented in neo-cli RPC ) to not be in the core RPC implementation. Could you make an extended version of JsonRpcApi with this additional method ( along with #598 and #573 ). We could then add a switch in np-api-server to optionally start the extended JsonRpcApi.

@localhuman localhuman self-requested a review September 21, 2018 11:34
@jseagrave21
Copy link
Contributor Author

Yep, I can make those changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants