Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap fix + updates #705

Merged
merged 2 commits into from Nov 6, 2018
Merged

Bootstrap fix + updates #705

merged 2 commits into from Nov 6, 2018

Conversation

@ixje
Copy link
Member

ixje commented Nov 6, 2018

What current issue(s) does this address, or what feature is it adding?

  • Fix the dreaded cannot join current thread people are now getting with np-bootstrap #700
  • each time bootstraps are updated people need to update their protocol config files

How did you solve this problem?

  • downgraded to the previous tqdm==4.23.4 that doesn't have this issue
  • make bootstrap.py query what the latest files are via a bootstrap_latest json file looking like this:
{
	"mainnet": "https://s3.us-east-2.amazonaws.com/cityofzion/bootstrap_main/Main292952.tar.gz ",
	"mainnet_notif": "https://s3.us-east-2.amazonaws.com/cityofzion/bootstrap_main/MainNotif292952.tar.gz",
	"testnet": "https://s3.us-east-2.amazonaws.com/cityofzion/bootstrap_main/Test168xxxx.tar.gz",
	"testnet_notif": "https://s3.us-east-2.amazonaws.com/cityofzion/bootstrap_main/TestNotif168xxxx.tar.gz" 
}

That way we can update the bootstrap files + this bootstrap_latest file on AWS and users don't have to do anything on their side.

How did you make sure your solution works?
manual testing + make test

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage increased (+0.003%) to 82.994% when pulling f6f92d2 on ixje:bootstrap_updates into cd77b16 on CityOfZion:development.

@localhuman

This comment has been minimized.

Copy link
Collaborator

localhuman commented Nov 6, 2018

Great change!

@localhuman localhuman merged commit 84c6bb2 into CityOfZion:development Nov 6, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 82.994%
Details
@ixje ixje deleted the ixje:bootstrap_updates branch Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.