Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PICKITEM for ByteArray into VM #923

Merged
merged 3 commits into from Mar 29, 2019
Merged

Conversation

@ixje
Copy link
Member

ixje commented Mar 28, 2019

What current issue(s) does this address, or what feature is it adding?
neo-project/neo-vm#98

How did you solve this problem?
write code

How did you make sure your solution works?
run VM test vectors

Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)
@ixje

This comment has been minimized.

Copy link
Member Author

ixje commented Mar 29, 2019

StackItem.New did not create a ByteArray when receiving a str input value therefore failing some local tests. The VM test-vectors did not cover this.
C# ref: https://github.com/neo-project/neo-vm/blob/bfb68c806f52ed773ae7badff3b652e96e257c61/src/neo-vm/StackItem.cs#L95-L98

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 29, 2019

Coverage Status

Coverage decreased (-0.01%) to 86.764% when pulling 217c6e5 on ixje:pickitem-vm into bcb46c4 on CityOfZion:development.

@ixje ixje merged commit 0a2b8b0 into CityOfZion:development Mar 29, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.01%) to 86.764%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ixje ixje deleted the ixje:pickitem-vm branch Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.