Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Rolling log #508

Open
aboimpinto opened this issue Oct 16, 2018 · 5 comments
Open

Rolling log #508

aboimpinto opened this issue Oct 16, 2018 · 5 comments
Labels
Enhancement New feature or request

Comments

@aboimpinto
Copy link
Contributor

Rolling log should be configured
The neo-python project has a default of rolling log of 3 rotation of 50Mbytes. Neo-sharp should implement this model as default too and keep the communication line with neo-python in order to have the same configured logging scenarios.

We should should look for framework best practices for the rolling logs.

@shargon
Copy link
Member

shargon commented Oct 22, 2018

Also we should be able to disable this logs

@osmirnov
Copy link
Collaborator

I was forced to make it rolling while working on sync. Please start with the requirements for this feature and to tweak the configuration in nlog.config.

@osmirnov osmirnov added the Enhancement New feature or request label Oct 22, 2018
@shargon
Copy link
Member

shargon commented Oct 30, 2018

@osmirnov is possible to disable logs in this config?

@osmirnov
Copy link
Collaborator

This is an initial configuration. I think there are many ways to disable logging. For example:
<logger name="*" minlevel="Trace" writeTo="targetGeneralOutput" enabled="false" />
If you want to do it on fly I believe you need to use NLog APi, to find a logger by name and to set that property.

@shargon
Copy link
Member

shargon commented Oct 30, 2018

@osmirnov You save my SSD :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants