Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31: Make the email id in the footer clickable #33

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@RyanWils
Copy link

RyanWils commented Oct 3, 2019

Hi, I have added in the clickable email id in the footer.
In _include/footer.html, I have included the same hyper link you used in the landingpage.html
<a class=" text-blue" href="mailto:info@civicdatalab.in" target="_blank"><a>

The picture below is what the footer looks like after the changes
image

@akki2825

This comment has been minimized.

Copy link
Member

akki2825 commented Oct 5, 2019

Thanks for the contribution @RyanWils ! We don't need the font color to be blue. Please retain the original white color.

@RyanWils

This comment has been minimized.

Copy link
Author

RyanWils commented Oct 5, 2019

Hi, I created another commit and set the email id back to the original color.
image
On Hover
image

@akki2825 akki2825 requested a review from thedigitalmonk Oct 6, 2019
@thedigitalmonk

This comment has been minimized.

Copy link
Contributor

thedigitalmonk commented Oct 11, 2019

Works. Thanks for the contribution @RyanWils :)

@thedigitalmonk thedigitalmonk merged commit 8525361 into CivicDataLab:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.