Disable s390 builds for clang 12 and earlier on mainline #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the same reason as commit 342e440 ("generator.yml: Disable s390 builds for clang 12 and earlier on -next"). Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
disable-s380-mainline
branch
from
0402fea
to
99bf844
Compare
|
Sorry to hijack the PR -- so is s390 not working under LLVM 12 now? (again?) I was planning to add this one as the next arch for Rust for Linux :-( |
|
if it helps and not too complex, I could backport the fix into apt.llvm.org |
Yes, see https://git.kernel.org/linus/e2bc3e91d91ede6710801fa0737e4e4ed729b19e for the reasoning.
Unfortunately, due to the commit above, that will not do anything :( |
|
Thanks Nathan! Understood -- let's wait for LLVM 13 then :) |
nathanchance
added a commit
to nathanchance/continuous-integration2
that referenced
this pull request
Feb 1, 2023
Commit 82d3edb50a11 ("s390/cpum_sf: add READ_ONCE() semantics to compare
and swap loops") was applied to 5.10, where it started causing build
breakage with LLVM 11 and 12:
arch/s390/kernel/perf_cpum_sf.c:1234:3: error: inline asm error: This value type register class is not natively supported!
" cdsg %[old],%[new],%[ptr]\n"
^
warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
The construct that is used in the inline assembly was only supported in
LLVM starting with the 13.0.0 release, even though it has been supported
in GCC for a while. This was the catalyst for commit e2bc3e91d91e
("scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for
s390").
The min-tool-version.sh infrastructure does not exist in 5.10 and it may
be undesirable to backport it. Do what was done in ClangBuiltLinux#150 and ClangBuiltLinux#161 and
disable LLVM 11 and 12 builds on stable-5.10. This does not lose us much
coverage, as we were only testing one configuration on these branches.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.