Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wparentheses-equality in drivers/md/dm-flakey.c #1798

Closed
nathanchance opened this issue Feb 2, 2023 · 2 comments
Closed

-Wparentheses-equality in drivers/md/dm-flakey.c #1798

nathanchance opened this issue Feb 2, 2023 · 2 comments
Assignees
@nathanchance
Labels
-Wparentheses-equality [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle

Comments

@nathanchance
Copy link
Member 

../drivers/md/dm-flakey.c:369:28: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
                        if ((fc->corrupt_bio_rw == WRITE)) {
                             ~~~~~~~~~~~~~~~~~~~^~~~~~~~
../drivers/md/dm-flakey.c:369:28: note: remove extraneous parentheses around the comparison to silence this warning
                        if ((fc->corrupt_bio_rw == WRITE)) {
                            ~                   ^       ~
../drivers/md/dm-flakey.c:369:28: note: use '=' to turn this equality comparison into an assignment
                        if ((fc->corrupt_bio_rw == WRITE)) {
                                                ^~
                                                =
1 error generated.

Patch submitted: https://lore.kernel.org/20230202-dm-parenthesis-warning-v1-1-ebdee213eeb9@kernel.org/
@nathanchance nathanchance added -Wparentheses-equality [PATCH] Submitted A patch has been submitted for review [BUG] linux-next This is an issue only seen in linux-next labels Feb 2, 2023
@nathanchance nathanchance self-assigned this Feb 2, 2023
@nathanchance
Copy link
Member Author

This appears to be fixed in the maintainer's tree: https://git.kernel.org/device-mapper/linux-dm/c/aa56b9b75996ff4c76a0a4181c2fa0206c3d91cc

@nathanchance nathanchance added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Feb 2, 2023
@nathanchance
Copy link
Member Author

Now in next-20230203.

@nathanchance nathanchance added [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wparentheses-equality [BUG] linux-next This is an issue only seen in linux-next [FIXED][LINUX] development cycle This bug was only present and fixed in a -next or -rc cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance