Skip to content

/ linux

forked from torvalds/linux
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wsometimes-uninitialized in fs/btrfs/uuid-tree.c #385

Closed
nickdesaulniers opened this issue Feb 26, 2019 · 4 comments
Closed

-Wsometimes-uninitialized in fs/btrfs/uuid-tree.c #385

nickdesaulniers opened this issue Feb 26, 2019 · 4 comments
Assignees
@nathanchance
Labels
-Wsometimes-uninitialized [BUG] linux [FIXED][LINUX] 5.2

Comments

@nickdesaulniers
Copy link
Member

@nickdesaulniers nickdesaulniers commented Feb 26, 2019

from #381

fs/btrfs/uuid-tree.c:129:13: error: variable 'eb' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: error: variable 'offset' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

allyesconfig
@nickdesaulniers
Copy link
Member Author

@nickdesaulniers nickdesaulniers commented Feb 26, 2019

Clang seems confused likely cause of the final else if (it's not able to work out that ALL cases are covered). The final branch should just be an else, no else if.
@nathanchance nathanchance self-assigned this Mar 7, 2019
@nathanchance
Copy link
Member

@nathanchance nathanchance commented Mar 7, 2019

Patch sent: https://lore.kernel.org/lkml/20190307163515.2168-1-natechancellor@gmail.com/
@nathanchance
Copy link
Member

@nathanchance nathanchance commented Mar 8, 2019

Patch accepted: kdave@2feb2cb
kdave added a commit to kdave/btrfs-devel that referenced this issue Mar 21, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
f22898c 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Mar 25, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
a540189 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Mar 27, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
e95322a 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Apr 1, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
9498b52 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Apr 15, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
57187f4 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Apr 23, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
59cc611 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave added a commit to kdave/btrfs-devel that referenced this issue Apr 29, 2019
@nathanchance @kdave
btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add
e8baf7a 
When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: ClangBuiltLinux#385
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
@nathanchance
Copy link
Member

@nathanchance nathanchance commented May 7, 2019

Merged into mainline: https://git.kernel.org/torvalds/c/e8baf7abcf56da68a03df77f51459acddeef4195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wsometimes-uninitialized [BUG] linux [FIXED][LINUX] 5.2
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nickdesaulniers @nathanchance
You can’t perform that action at this time.