Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wsometimes-uninitialized in net/netfilter/nf_flow_table_offload.c #780

Closed
nathanchance opened this issue Nov 26, 2019 · 2 comments
Closed

-Wsometimes-uninitialized in net/netfilter/nf_flow_table_offload.c #780

nathanchance opened this issue Nov 26, 2019 · 2 comments

Comments

@nathanchance
Copy link
Member

@nathanchance nathanchance commented Nov 26, 2019

../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable 'offset' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0
../net/netfilter/nf_flow_table_offload.c:369:2: warning: variable 'offset' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:373:57: note: uninitialized use occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:358:12: note: initialize the variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0
2 warnings generated.

Patch submitted: https://lore.kernel.org/netfilter-devel/20191126201226.51857-1-natechancellor@gmail.com/

@nathanchance nathanchance self-assigned this Nov 26, 2019
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 27, 2019
…low_offload_port_{d,s}nat

Clang warns (trimmed the second warning for brevity):

../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable
'offset' is used uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use
occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the
variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0

Match what was done in the flow_offload_ipv{4,6}_{d,s}nat functions and
just return in the default case, since port would also be uninitialized.

Fixes: c29f74e ("netfilter: nf_flow_table: hardware offload support")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
@nathanchance

This comment has been minimized.

Copy link
Member Author

@nathanchance nathanchance commented Dec 1, 2019

ruscur pushed a commit to ruscur/linux that referenced this issue Dec 2, 2019
…low_offload_port_{d,s}nat

Clang warns (trimmed the second warning for brevity):

../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable
'offset' is used uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use
occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the
variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0

Match what was done in the flow_offload_ipv{4,6}_{d,s}nat functions and
just return in the default case, since port would also be uninitialized.

Fixes: c29f74e ("netfilter: nf_flow_table: hardware offload support")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
hnaz added a commit to hnaz/linux-mm that referenced this issue Dec 3, 2019
GIT 93aaf8d7ac1587a507769071a99d2cb9d681b885

commit 0faee24149d7ec00fba47e6596b3978f2ab7fafa
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Tue Nov 26 09:41:46 2019 -0500

    drm/radeon: fix r1xx/r2xx register checker for POT textures
    
    Shift and mask were reversed.  Noticed by chance.
    
    Tested-by: Meelis Roos <mroos@linux.ee>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 80c274fc854a2578287dbf0d0c7bca2395ef9a29
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Wed Oct 2 14:01:27 2019 +0200

    drm/amdgpu: work around llvm bug #42576
    
    Code in the amdgpu driver triggers a bug when using clang to build
    an arm64 kernel:
    
    /tmp/sdma_v4_0-f95fd3.s: Assembler messages:
    /tmp/sdma_v4_0-f95fd3.s:44: Error: selected processor does not support `bfc w0,#1,#5'
    
    I expect this to be fixed in llvm soon, but we can also work around
    it by inserting a barrier() that prevents the optimization.
    
    Link: https://bugs.llvm.org/show_bug.cgi?id=42576
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit a834e832e74d283f64eee7d5bbbcf5215a3110a1
Author: Oak Zeng <Oak.Zeng@amd.com>
Date:   Mon May 6 22:11:14 2019 -0500

    drm/amdkfd: New IOCTL to allocate queue GWS (v2)
    
    Add a new kfd ioctl to allocate queue GWS. Queue
    GWS is released on queue destroy.
    
    v2: re-introduce this API with the following fixes squashed in:
    - drm/amdkfd: fix null pointer dereference on dev
    - drm/amdkfd: Return proper error code for gws alloc API
    - drm/amdkfd: Remove GPU ID in GWS queue creation
    
    Signed-off-by: Oak Zeng <Oak.Zeng@amd.com>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 6a59c0659c9399f76b14a8e56cffb59c2d6dc7af
Author: Thomas Hellstrom <thellstrom@vmware.com>
Date:   Wed Sep 25 15:11:23 2019 +0200

    drm/ttm: Convert vm callbacks to helpers
    
    The default TTM fault handler may not be completely sufficient
    (vmwgfx needs to do some bookkeeping, control the write protectionand also
    needs to restrict the number of prefaults).
    
    Also make it possible replicate ttm_bo_vm_reserve() functionality for,
    for example, mkwrite handlers.
    
    So turn the TTM vm code into helpers: ttm_bo_vm_fault_reserved(),
    ttm_bo_vm_open(), ttm_bo_vm_close() and ttm_bo_vm_reserve(). Also provide
    a default TTM fault handler for other drivers to use.
    
    Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 24fb9d3feeee428ddf7d0e8675cc17b6be76608e
Author: Thomas Hellstrom <thellstrom@vmware.com>
Date:   Wed Sep 25 15:11:22 2019 +0200

    drm/ttm: Remove explicit typecasts of vm_private_data
    
    The explicit typcasts are meaningless, so remove them.
    
    Suggested-by: Matthew Wilcox <willy@infradead.org>
    Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit b2d629ec0aef0df0a779a32307ef993aebe91465
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Nov 27 15:55:35 2019 -0500

    drm/amdgpu: move CS secure flag next the structs where it's used
    
    So it's not mixed up with the CTX stuff.
    
    Reviewed-by: Zhan Liu <zhan.liu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 04bedd5767fc97d1c2a842851e70a1a51c011561
Author: Aaron Liu <aaron.liu@amd.com>
Date:   Fri Nov 15 15:08:36 2019 +0800

    drm/amdgpu: enable TMZ bit in FRAME_CONTROL for gfx10
    
    This patch enables TMZ bit in FRAME_CONTROL for gfx10.
    
    Signed-off-by: Aaron Liu <aaron.liu@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 371167248e8ad451dd4ff64908623cf1b7505500
Author: Aaron Liu <aaron.liu@amd.com>
Date:   Fri Nov 15 16:18:03 2019 +0800

    drm/amdgpu: enable TMZ bit in sdma copy pkt for sdma v5
    
    Enable sdma TMZ mode via setting TMZ bit in sdma copy pkt
    for sdma v5.
    
    Signed-off-by: Aaron Liu <aaron.liu@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 45f90b5a452d27dc4a3cf7f8121ce97285814ca3
Author: Aaron Liu <aaron.liu@amd.com>
Date:   Tue Oct 15 16:47:44 2019 +0800

    drm/amdgpu: enable TMZ bit in sdma copy pkt for sdma v4
    
    Enable sdma TMZ mode via setting TMZ bit in sdma copy pkt
    for sdma v4
    
    Signed-off-by: Aaron Liu <aaron.liu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 9c823421bb35d471ca53d18b3cb6eabeafa26f96
Author: Aaron Liu <aaron.liu@amd.com>
Date:   Tue Oct 15 15:45:23 2019 +0800

    drm/amdgpu: expand amdgpu_copy_buffer interface with tmz parameter
    
    This patch expands amdgpu_copy_buffer interface with tmz parameter.
    
    Signed-off-by: Aaron Liu <aaron.liu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit ee746e3b3515d7afaea39245e5e120c08ea6ca41
Author: Aaron Liu <aaron.liu@amd.com>
Date:   Tue Oct 15 15:37:48 2019 +0800

    drm/amdgpu: expand sdma copy_buffer interface with tmz parameter
    
    This patch expands sdma copy_buffer interface with tmz parameter.
    
    Signed-off-by: Aaron Liu <aaron.liu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 86e8ce4724aadd4034c58fa8520ad4fae3e69630
Author: Stephen Rothwell <sfr@canb.auug.org.au>
Date:   Wed Oct 16 11:22:07 2019 +1100

    drm/amdgpu: fix up for amdgpu_tmz.c and removal of drm/drmP.h
    
    Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 1161dd268aec18c1c43234aba5c8699160df53c3
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Aug 7 22:32:46 2019 -0500

    drm/amdgpu: set TMZ bits in PTEs for secure BO (v4)
    
    If a buffer object is secure, i.e. created with
    AMDGPU_GEM_CREATE_ENCRYPTED, then the TMZ bit of
    the PTEs that belong the buffer object should be
    set.
    
    v1: design and draft the skeletion of TMZ bits setting on PTEs (Alex)
    v2: return failure once create secure BO on non-TMZ platform  (Ray)
    v3: amdgpu_bo_encrypted() only checks the BO (Luben)
    v4: move TMZ flag setting into amdgpu_vm_bo_update  (Christian)
    
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>

commit 01d216faad334b3e9443f6e937bf878e5ecaaa6c
Author: Huang Rui <ray.huang@amd.com>
Date:   Thu Aug 8 20:05:15 2019 +0800

    drm/amdgpu: job is secure iff CS is secure (v5)
    
    Mark a job as secure, if and only if the command
    submission flag has the secure flag set.
    
    v2: fix the null job pointer while in vmid 0
    submission.
    v3: Context --> Command submission.
    v4: filling cs parser with cs->in.flags
    v5: move the job secure flag setting out of amdgpu_cs_submit()
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit a3b19937c8f5e0ee0998f41c56becc2df106c4a3
Author: Huang Rui <ray.huang@amd.com>
Date:   Thu Aug 8 20:18:42 2019 +0800

    drm/amdgpu: expand the context control interface with trust flag
    
    This patch expands the context control function to support trusted flag while we
    want to set command buffer in trusted mode.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Acked-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 1723061c13efcb6125ec22db51052d2e0d5723a2
Author: Huang Rui <ray.huang@amd.com>
Date:   Thu Aug 8 19:07:19 2019 +0800

    drm/amdgpu: expand the emit tmz interface with trusted flag
    
    This patch expands the emit_tmz function to support trusted flag while we want
    to set command buffer in trusted mode.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Acked-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 8874c9b20c4459fdb943527c4b4e4a9043af79ef
Author: Huang Rui <ray.huang@amd.com>
Date:   Thu Aug 8 17:00:16 2019 +0800

    drm/amdgpu: add tmz bit in frame control packet
    
    This patch adds tmz bit in frame control pm4 packet, and it will used in future.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 0eb84188faba518ae1fc1f50fecc83a4f3f6b9e5
Author: Huang Rui <ray.huang@amd.com>
Date:   Mon Aug 12 21:06:22 2019 +0800

    drm/amdgpu: add function to check tmz capability (v4)
    
    Add a function to check tmz capability with kernel parameter and ASIC type.
    
    v2: use a per device tmz variable instead of global amdgpu_tmz.
    v3: refine the comments for the function. (Luben)
    v4: add amdgpu_tmz.c/h for future use.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit daf98e0d192724456000026d306a1cd2ce78a78c
Author: Huang Rui <ray.huang@amd.com>
Date:   Thu Aug 22 16:21:46 2019 +0800

    drm/amdgpu: add amdgpu_tmz data structure
    
    This patch to add amdgpu_tmz structure which stores all tmz related fields.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit d2722d3ddfefa09787a6557b5b41306dd1644c17
Author: Huang Rui <ray.huang@amd.com>
Date:   Sun Aug 4 16:33:16 2019 +0800

    drm/amdgpu: add tmz feature parameter (v2)
    
    This patch adds tmz parameter to enable/disable
    the feature in the amdgpu kernel module. Nomally,
    by default, it should be auto (rely on the
    hardware capability).
    
    But right now, it need to set "off" to avoid
    breaking other developers' work because it's not
    totally completed.
    
    Will set "auto" till the feature is stable and
    completely verified.
    
    v2: add "auto" option for future use.
    
    Signed-off-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 59cf3672058973e259cff430517973245588941f
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Aug 7 22:31:50 2019 -0500

    drm/amdgpu: define the TMZ bit for the PTE
    
    Define the TMZ (encryption) bit in the page table entry (PTE) for
    Raven and newer asics.
    
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>

commit 4a36ea8a80060770e4e3bcd98b9e7f73fbdaec9c
Author: Luben Tuikov <luben.tuikov@amd.com>
Date:   Mon Sep 23 19:02:41 2019 -0400

    drm/amdgpu: add UAPI to create secure commands (v3)
    
    Add a flag to the command submission IOCTL
    structure which when present indicates that this
    command submission should be treated as
    secure. The kernel driver uses this flag to
    determine whether the engine should be
    transitioned to secure or unsecure, or the work
    can be submitted to a secure queue depending on
    the IP.
    
    v3: the flag is now at command submission IOCTL
    
    Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 4558ae5a95a526854e4483f95d9b03eb22348295
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Aug 7 21:43:24 2019 -0500

    drm/amdgpu: add UAPI for creating encrypted buffers
    
    Add a flag to the GEM_CREATE ioctl to create encrypted buffers.
    Buffers with this flag set will be created with the TMZ bit set
    in the PTEs or engines accessing them.  This is required in order
    to properly access the data from the engines.
    
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>

commit a501e22c8e36934b2d901b039b1c59c948886c90
Author: Colin Ian King <colin.king@canonical.com>
Date:   Mon Dec 2 15:47:38 2019 +0000

    drm/amd/display: remove redundant assignment to variable v_total
    
    The variable v_total is being initialized with a value that is never
    read and it is being updated later with a new value.  The initialization
    is redundant and can be removed.
    
    Addresses-Coverity: ("Unused value")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit f7a8b4739d94f05d4bb84b62d43157dd1bc3bc32
Author: zhengbin <zhengbin13@huawei.com>
Date:   Thu Nov 28 10:31:40 2019 +0800

    drm/amd/display: Remove unneeded semicolon in display_rq_dlg_calc_21.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c:1525:144-145: Unneeded semicolon
    drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c:1526:142-143: Unneeded semicolon
    
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 2fd4f169030a4e735af556b14586c54298acc457
Author: zhengbin <zhengbin13@huawei.com>
Date:   Thu Nov 28 10:31:39 2019 +0800

    drm/amd/display: Remove unneeded semicolon in hdcp.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/display/modules/hdcp/hdcp.c:506:2-3: Unneeded semicolon
    
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit c09f5e000d1e96de95da1aae2ce7ba25d3d207a7
Author: zhengbin <zhengbin13@huawei.com>
Date:   Thu Nov 28 10:31:38 2019 +0800

    drm/amd/display: Remove unneeded semicolon in bios_parser2.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:995:2-3: Unneeded semicolon
    
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 4c56feac0d47b0cf620a8f2e62c1c9cda8e22e54
Author: zhengbin <zhengbin13@huawei.com>
Date:   Thu Nov 28 10:31:37 2019 +0800

    drm/amd/display: Remove unneeded semicolon in bios_parser.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:2192:2-3: Unneeded semicolon
    
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit c7d5dfa88bc4e5a05d664eff04f6981f9fdf872d
Author: zhengbin <zhengbin13@huawei.com>
Date:   Wed Nov 27 17:33:42 2019 +0800

    drm/amd/powerplay: Remove unneeded variable 'ret' in amdgpu_smu.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/powerplay/amdgpu_smu.c:1192:5-8: Unneeded variable: "ret". Return "0" on line 1195
    drivers/gpu/drm/amd/powerplay/amdgpu_smu.c:1945:5-8: Unneeded variable: "ret". Return "0" on line 1961
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 3d218c31843ef27faf5a9169bf4176651216fd77
Author: zhengbin <zhengbin13@huawei.com>
Date:   Wed Nov 27 17:33:41 2019 +0800

    drm/amd/powerplay: Remove unneeded variable 'result' in vega12_hwmgr.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c:502:5-11: Unneeded variable: "result". Return "0" on line 515
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 7bb4b887d0f4161076c77e72b92af4f9d44c4269
Author: zhengbin <zhengbin13@huawei.com>
Date:   Wed Nov 27 17:33:40 2019 +0800

    drm/amd/powerplay: Remove unneeded variable 'ret' in smu7_hwmgr.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:5188:5-8: Unneeded variable: "ret". Return "0" on line 5196
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 98ce837d7b67bbd992f93f3489a300aa93fa41b3
Author: zhengbin <zhengbin13@huawei.com>
Date:   Wed Nov 27 17:33:39 2019 +0800

    drm/amd/powerplay: Remove unneeded variable 'result' in vega10_hwmgr.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c:4363:5-11: Unneeded variable: "result". Return "0" on line 4370
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 9c9290fa3ce16e0d81d89a7e82005cbf094d92d9
Author: zhengbin <zhengbin13@huawei.com>
Date:   Wed Nov 27 17:33:38 2019 +0800

    drm/amd/powerplay: Remove unneeded variable 'result' in smu10_hwmgr.c
    
    Fixes coccicheck warning:
    
    drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1154:5-11: Unneeded variable: "result". Return "0" on line 1159
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: zhengbin <zhengbin13@huawei.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit f706ec87ea4cd193b772a85ff66a693520dbf12d
Author: Colin Ian King <colin.king@canonical.com>
Date:   Wed Nov 20 17:22:42 2019 +0000

    drm/amd/display: fix double assignment to msg_id field
    
    The msg_id field is being assigned twice. Fix this by replacing the second
    assignment with an assignment to msg_size.
    
    Addresses-Coverity: ("Unused value")
    Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps")
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 0e29be9e0bbbf9cb3d718c5c48382b1420ce0749
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Fri Nov 15 10:02:44 2019 -0500

    drm/amd/display: re-enable wait in pipelock, but add timeout
    
    Removing this causes hangs in some games, so re-add it, but add
    a timeout so we don't hang while switching flip types.
    
    Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205169
    Bug: https://bugs.freedesktop.org/show_bug.cgi?id=112266
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 72b741af22d4e3dbce8a71bfd5d406b2b38ee058
Author: Zhan liu <zhan.liu@amd.com>
Date:   Mon Dec 2 15:12:27 2019 -0500

    drm/amd/display: Get NV14 specific ip params as needed
    
    [Why]
    NV14 is using its own ip params that's different from other
    DCN2.0 ASICs.
    
    [How]
    Add ASIC revision check to make sure NV14 gets correct
    ip params.
    
    Signed-off-by: Zhan Liu <zhan.liu@amd.com>
    Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit a2c63407316cb01d1de5c0eb4177eae8b977327b
Author: Zhan liu <zhan.liu@amd.com>
Date:   Mon Dec 2 14:54:16 2019 -0500

    drm/amd/display: Adding NV14 IP Parameters
    
    [Why]
    NV14 IP Parameters are missing.
    
    [How]
    Add IP Parameters in.
    
    Signed-off-by: Zhan liu <zhan.liu@amd.com>
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 0ea203a91247082f1294e6aa6e7802914665da50
Author: Emily Deng <Emily.Deng@amd.com>
Date:   Tue Dec 3 01:53:10 2019 +0800

    drm/amdgpu/sriov: No need the event 3 and 4 now
    
    As will call unload kms when initialize fail, and the unload kms will
    send event 3 and 4, so don't need event 3 and 4 in device init.
    
    Signed-off-by: Emily Deng <Emily.Deng@amd.com>
    Reviewed-by: Zhan Liu <zhan.liu@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 031514956bd06156897b54a80db66acf7c1d9ebd
Author: John Clements <john.clements@amd.com>
Date:   Mon Dec 2 17:57:25 2019 +0800

    drm/amdgpu: Added ASIC specific checks in gfxhub V1.1 get XGMI info
    
    Added max hive/node info checks per supported ASIC
    
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: John Clements <john.clements@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit a7f4ba7a6c2f0962a0db37743586c1e4a95ca72d
Author: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Date:   Fri Nov 8 16:57:21 2019 -0500

    drm/amd/display: Load TA firmware for navi10/12/14
    
    load the ta firmware for navi10/12/14.
    This is already being done for raven/picasso and
    is needed for supporting hdcp on navi
    
    Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 7c868b592d5c2c9d54c8ab92624efcf2d3d41bc6
Author: Yintian Tao <yttao@amd.com>
Date:   Fri Nov 29 16:05:55 2019 +0800

    drm/amdgpu: not remove sysfs if not create sysfs
    
    When load amdgpu failed before create pm_sysfs and ucode_sysfs,
    the pm_sysfs and ucode_sysfs should not be removed.
    Otherwise, there will be warning call trace just like below.
    [   24.836386] [drm] VCE initialized successfully.
    [   24.841352] amdgpu 0000:00:07.0: amdgpu_device_ip_init failed
    [   25.370383] amdgpu 0000:00:07.0: Fatal error during GPU init
    [   25.889575] [drm] amdgpu: finishing device.
    [   26.069128] amdgpu 0000:00:07.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring kiq_2.1.0 test failed (-110)
    [   26.070110] [drm:gfx_v9_0_hw_fini [amdgpu]] *ERROR* KCQ disable failed
    [   26.200309] [TTM] Finalizing pool allocator
    [   26.200314] [TTM] Finalizing DMA pool allocator
    [   26.200349] [TTM] Zone  kernel: Used memory at exit: 0 KiB
    [   26.200351] [TTM] Zone   dma32: Used memory at exit: 0 KiB
    [   26.200353] [drm] amdgpu: ttm finalized
    [   26.205329] ------------[ cut here ]------------
    [   26.205330] sysfs group 'fw_version' not found for kobject '0000:00:07.0'
    [   26.205347] WARNING: CPU: 0 PID: 1228 at fs/sysfs/group.c:256 sysfs_remove_group+0x80/0x90
    [   26.205348] Modules linked in: amdgpu(OE+) gpu_sched(OE) ttm(OE) drm_kms_helper(OE) drm(OE) i2c_algo_bit fb_sys_fops syscopyarea sysfillrect sysimgblt rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs lockd grace fscache binfmt_misc snd_hda_codec_generic ledtrig_audio crct10dif_pclmul snd_hda_intel crc32_pclmul snd_hda_codec ghash_clmulni_intel snd_hda_core snd_hwdep snd_pcm snd_timer input_leds snd joydev soundcore serio_raw pcspkr evbug aesni_intel aes_x86_64 crypto_simd cryptd mac_hid glue_helper sunrpc ip_tables x_tables autofs4 8139too psmouse 8139cp mii i2c_piix4 pata_acpi floppy
    [   26.205369] CPU: 0 PID: 1228 Comm: modprobe Tainted: G           OE     5.2.0-rc1 #1
    [   26.205370] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014
    [   26.205372] RIP: 0010:sysfs_remove_group+0x80/0x90
    [   26.205374] Code: e8 35 b9 ff ff 5b 41 5c 41 5d 5d c3 48 89 df e8 f6 b5 ff ff eb c6 49 8b 55 00 49 8b 34 24 48 c7 c7 48 7a 70 98 e8 60 63 d3 ff <0f> 0b eb d7 66 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55
    [   26.205375] RSP: 0018:ffffbee242b0b908 EFLAGS: 00010282
    [   26.205376] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000006
    [   26.205377] RDX: 0000000000000007 RSI: 0000000000000092 RDI: ffff97ad6f817380
    [   26.205377] RBP: ffffbee242b0b920 R08: ffffffff98f520c4 R09: 00000000000002b3
    [   26.205378] R10: ffffbee242b0b8f8 R11: 00000000000002b3 R12: ffffffffc0e58240
    [   26.205379] R13: ffff97ad6d1fe0b0 R14: ffff97ad4db954c8 R15: ffff97ad4db7fff0
    [   26.205380] FS:  00007ff3d8a1c4c0(0000) GS:ffff97ad6f800000(0000) knlGS:0000000000000000
    [   26.205381] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    [   26.205381] CR2: 00007f9b2ef1df04 CR3: 000000042aab8001 CR4: 00000000003606f0
    [   26.205384] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    [   26.205385] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    [   26.205385] Call Trace:
    [   26.205461]  amdgpu_ucode_sysfs_fini+0x18/0x20 [amdgpu]
    [   26.205518]  amdgpu_device_fini+0x3b4/0x560 [amdgpu]
    [   26.205573]  amdgpu_driver_unload_kms+0x4f/0xa0 [amdgpu]
    [   26.205623]  amdgpu_driver_load_kms+0xcd/0x250 [amdgpu]
    [   26.205637]  drm_dev_register+0x12b/0x1c0 [drm]
    [   26.205695]  amdgpu_pci_probe+0x12a/0x1e0 [amdgpu]
    [   26.205699]  local_pci_probe+0x47/0xa0
    [   26.205701]  pci_device_probe+0x106/0x1b0
    [   26.205704]  really_probe+0x21a/0x3f0
    [   26.205706]  driver_probe_device+0x11c/0x140
    [   26.205707]  device_driver_attach+0x58/0x60
    [   26.205709]  __driver_attach+0xc3/0x140
    
    Signed-off-by: Yintian Tao <yttao@amd.com>
    Acked-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Nirmoy Das <nirmoy.das@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit d5939e4db5e6b8e3fe9707edb08d705bf4754cea
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Tue Nov 26 19:33:38 2019 +0800

    drm/amdgpu: fix GFX10 missing CSIB set(v3)
    
    still need to init csb even for SRIOV
    
    v2:
    drop init_pg() for gfx10 at all since
    PG and GFX off feature will be fully controled
    by RLC and SMU fw for gfx10
    
    v3:
    drop the flush_gpu_tlb lines since we consider
    it is only usefull in emulation
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit eb529b8e46b87c1f89deeb1e736cf704948326e3
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Fri Nov 29 16:20:51 2019 +0800

    drm/amdgpu: should stop GFX ring in hw_fini
    
    To align with the scheme from gfx9
    
    disabling GFX ring after VM shutdown could avoid
    garbage data be fetched to GFX RB which may lead
    to unnecessary screw up on GFX
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 6de40f02b355ae4c449acdaae19bac1ee380a01d
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Tue Nov 26 19:38:22 2019 +0800

    drm/amdgpu: do autoload right after MEC loaded for SRIOV VF
    
    since we don't have RLCG ucode loading and no SRlist as well
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 1797ec7ffd1b4d41b078a4e807225827caf39e60
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Tue Nov 26 19:36:29 2019 +0800

    drm/amdgpu: skip rlc ucode loading for SRIOV gfx10
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 82a829dc8c2bb03cc9b7e5beb1c5479aa3ba7831
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Tue Nov 26 19:42:25 2019 +0800

    drm/amdgpu: fix calltrace during kmd unload(v3)
    
    issue:
    kernel would report a warning from a double unpin
    during the driver unloading on the CSB bo
    
    why:
    we unpin it during hw_fini, and there will be another
    unpin in sw_fini on CSB bo.
    
    fix:
    actually we don't need to pin/unpin it during
    hw_init/fini since it is created with kernel pinned,
    we only need to fullfill the CSB again during hw_init
    to prevent CSB/VRAM lost after S3
    
    v2:
    get_csb in init_rlc so hw_init() will make CSIB content
    back even after reset or s3
    
    v3:
    use bo_create_kernel instead of bo_create_reserved for CSB
    otherwise the bo_free_kernel() on CSB is not aligned and
    would lead to its internal reserve pending there forever
    
    take care of gfx7/8 as well
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 5bbbc9b77831427609e4fcfb0a2b5961af3a1156
Author: Harry Wentland <harry.wentland@amd.com>
Date:   Thu Nov 28 11:30:10 2019 -0500

    drm/amd/display: Drop AMD_EDID_UTILITY defines
    
    We don't use this upstream in the Linux kernel.
    
    Signed-off-by: Harry Wentland <harry.wentland@amd.com>
    Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 6bb27085aaa973eac31058a2534d73efe50b3a00
Author: Zhan Liu <zhan.liu@amd.com>
Date:   Thu Nov 28 14:12:11 2019 -0500

    drm/amd/display: Include num_vmid and num_dsc within NV14's resource caps
    
    [Why]
    "num_vmid" and "num_dsc" are missing within NV14's resource caps structure.
    
    [How]
    Add the missing parts.
    
    Signed-off-by: Zhan Liu <zhan.liu@amd.com>
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 869aebc7baa5b9bc65bde29690de311a26b2681b
Author: Monk Liu <Monk.Liu@amd.com>
Date:   Tue Nov 26 19:40:08 2019 +0800

    drm/amdgpu: use CPU to flush vmhub if sched stopped
    
    otherwse the flush_gpu_tlb will hang if we unload the
    KMD becuase the schedulers already stopped
    
    Signed-off-by: Monk Liu <Monk.Liu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 45317d5ffb4d9bc842ef1f6119bc0b9e36c95f56
Author: James Zhu <James.Zhu@amd.com>
Date:   Tue Nov 26 14:27:46 2019 -0500

    drm/amdgpu/gfx: Increase dispatch packet number
    
    For Arcturus, increase dispatch packet number to stress scheduler.
    
    Signed-off-by: James Zhu <James.Zhu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 2255d7f36e479646244cd87906a6b87eae73711d
Author: James Zhu <James.Zhu@amd.com>
Date:   Tue Nov 26 14:23:10 2019 -0500

    drm/amdgpu/gfx: Clear more EDC cnt
    
    Clear SDMA and HDP EDC counter in GPR workarounds.
    
    Signed-off-by: James Zhu <James.Zhu@amd.com>
    Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 858054f7617bde2df8969e999f580ff37faacb70
Author: Xiaojie Yuan <xiaojie.yuan@amd.com>
Date:   Wed Nov 6 21:08:06 2019 +0800

    drm/amdgpu/gfx10: remove outdated comments
    
    Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
    Reviewed-by: Zhan Liu <zhan.liu@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit a5e82d0b95051a01c5e8473f6969eb69a38b40cf
Author: Xiaojie Yuan <xiaojie.yuan@amd.com>
Date:   Wed Nov 6 21:10:20 2019 +0800

    drm/amdgpu/gfx10: unlock srbm_mutex after queue programming finish
    
    srbm_mutex is to guarantee atomicity for r/w of gfx indexed registers
    
    Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

commit 240b62d381fe5b66c496a6fd55edff3976a9be51
Author: Juergen Gross <jgross@suse.com>
Date:   Mon Oct 21 12:04:15 2019 +0200

    ia64: remove stale paravirt leftovers
    
    Remove the last leftovers from IA64 Xen pv-guest support.
    
    PARAVIRT is long gone from IA64 Kconfig and Xen IA64 support, too.
    
    Due to lack of infrastructure no testing done.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    Link: https://lore.kernel.org/r/20191021100415.7642-1-jgross@suse.com

commit 69738cfdfa7032f45d9e7462d24490e61cf163dd
Author: Deepa Dinamani <deepa.kernel@gmail.com>
Date:   Fri Nov 29 21:30:25 2019 -0800

    fs: cifs: Fix atime update check vs mtime
    
    According to the comment in the code and commit log, some apps
    expect atime >= mtime; but the introduced code results in
    atime==mtime.  Fix the comparison to guard against atime<mtime.
    
    Fixes: 9b9c5bea0b96 ("cifs: do not return atime less than mtime")
    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    Cc: stfrench@microsoft.com
    Cc: linux-cifs@vger.kernel.org
    Signed-off-by: Steve French <stfrench@microsoft.com>

commit 6f582b273ec23332074d970a7fb25bef835df71f
Author: Pavel Shilovsky <pshilov@microsoft.com>
Date:   Wed Nov 27 16:18:39 2019 -0800

    CIFS: Fix NULL-pointer dereference in smb2_push_mandatory_locks
    
    Currently when the client creates a cifsFileInfo structure for
    a newly opened file, it allocates a list of byte-range locks
    with a pointer to the new cfile and attaches this list to the
    inode's lock list. The latter happens before initializing all
    other fields, e.g. cfile->tlink. Thus a partially initialized
    cifsFileInfo structure becomes available to other threads that
    walk through the inode's lock list. One example of such a thread
    may be an oplock break worker thread that tries to push all
    cached byte-range locks. This causes NULL-pointer dereference
    in smb2_push_mandatory_locks() when accessing cfile->tlink:
    
    [598428.945633] BUG: kernel NULL pointer dereference, address: 0000000000000038
    ...
    [598428.945749] Workqueue: cifsoplockd cifs_oplock_break [cifs]
    [598428.945793] RIP: 0010:smb2_push_mandatory_locks+0xd6/0x5a0 [cifs]
    ...
    [598428.945834] Call Trace:
    [598428.945870]  ? cifs_revalidate_mapping+0x45/0x90 [cifs]
    [598428.945901]  cifs_oplock_break+0x13d/0x450 [cifs]
    [598428.945909]  process_one_work+0x1db/0x380
    [598428.945914]  worker_thread+0x4d/0x400
    [598428.945921]  kthread+0x104/0x140
    [598428.945925]  ? process_one_work+0x380/0x380
    [598428.945931]  ? kthread_park+0x80/0x80
    [598428.945937]  ret_from_fork+0x35/0x40
    
    Fix this by reordering initialization steps of the cifsFileInfo
    structure: initialize all the fields first and then add the new
    byte-range lock list to the inode's lock list.
    
    Cc: Stable <stable@vger.kernel.org>
    Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
    Reviewed-by: Aurelien Aptel <aaptel@suse.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>

commit 040b5cfbcefa263ccf2c118c4938308606bb7ed8
Author: Martin Varghese <martin.varghese@nokia.com>
Date:   Mon Dec 2 10:49:51 2019 +0530

    Fixed updating of ethertype in function skb_mpls_pop
    
    The skb_mpls_pop was not updating ethertype of an ethernet packet if the
    packet was originally received from a non ARPHRD_ETHER device.
    
    In the below OVS data path flow, since the device corresponding to port 7
    is an l3 device (ARPHRD_NONE) the skb_mpls_pop function does not update
    the ethertype of the packet even though the previous push_eth action had
    added an ethernet header to the packet.
    
    recirc_id(0),in_port(7),eth_type(0x8847),
    mpls(label=12/0xfffff,tc=0/0,ttl=0/0x0,bos=1/1),
    actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
    pop_mpls(eth_type=0x800),4
    
    Fixes: ed246cee09b9 ("net: core: move pop MPLS functionality from OvS to core helper")
    Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
    Acked-by: Pravin B Shelar <pshelar@ovn.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit b3c424eb6a1a3c485de64619418a471dee6ce849
Author: Victorien Molle <victorien.molle@wifirst.fr>
Date:   Mon Dec 2 15:11:38 2019 +0100

    sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
    
    This field has never been checked since introduction in mainline kernel
    
    Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
    Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
    Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"
    Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit a7effde99b6e8119b28c235eda5419c2e03b3089
Author: Joe Perches <joe@perches.com>
Date:   Thu Nov 28 09:13:26 2019 -0800

    MIPS: Kconfig: Use correct form for 'depends on'
    
    Remove the CONFIG_ prefix from "depends on" as it makes the selection
    not possible.
    
    Signed-off-by: Joe Perches <joe@perches.com>
    Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
    Signed-off-by: Paul Burton <paulburton@kernel.org>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: James Hogan <jhogan@kernel.org>
    Cc: linux-mips@vger.kernel.org
    Cc: LKML <linux-kernel@vger.kernel.org>

commit 7d2aa4bb90f5f6f1b8de8848c26042403f2d7bf9
Author: Vincenzo Frascino <vincenzo.frascino@arm.com>
Date:   Fri Nov 29 14:36:58 2019 +0000

    mips: Fix gettimeofday() in the vdso library
    
    The libc provides a discovery mechanism for vDSO library and its
    symbols. When a symbol is not exposed by the vDSOs the libc falls back
    on the system calls.
    
    With the introduction of the unified vDSO library on mips this behavior
    is not honored anymore by the kernel in the case of gettimeofday().
    
    The issue has been noticed and reported due to a dhclient failure on the
    CI20 board:
    
    root@letux:~# dhclient
    ../../../../lib/isc/unix/time.c:200: Operation not permitted
    root@letux:~#
    
    Restore the original behavior fixing gettimeofday() in the vDSO library.
    
    Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
    Tested-by: H. Nikolaus Schaller <hns@goldelico.com> # CI20 with JZ4780
    Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
    Signed-off-by: Paul Burton <paulburton@kernel.org>
    Cc: mips-creator-ci20-dev@googlegroups.com
    Cc: letux-kernel@openphoenux.org
    Cc: linux-mips@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org

commit 1e58252e334dc3f3756f424a157d1b7484464c40
Author: qize wang <wangqize888888888@gmail.com>
Date:   Fri Nov 29 18:10:54 2019 +0800

    mwifiex: Fix heap overflow in mmwifiex_process_tdls_action_frame()
    
    mwifiex_process_tdls_action_frame() without checking
    the incoming tdls infomation element's vality before use it,
    this may cause multi heap buffer overflows.
    
    Fix them by putting vality check before use it.
    
    IE is TLV struct, but ht_cap and  ht_oper aren’t TLV struct.
    the origin marvell driver code is wrong:
    
    memcpy(&sta_ptr->tdls_cap.ht_oper, pos,....
    memcpy((u8 *)&sta_ptr->tdls_cap.ht_capb, pos,...
    
    Fix the bug by changing pos(the address of IE) to
    pos+2 ( the address of IE value ).
    
    Signed-off-by: qize wang <wangqize888888888@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

commit 693d060536abca7b16d2fb8e66aa56be2a2443a2
Author: Lorenzo Bianconi <lorenzo@kernel.org>
Date:   Sun Nov 24 00:42:22 2019 +0200

    mt76: mt76x0: fix default mac address overwrite
    
    Current implementation always use default eeprom mac address to
    configure device registers even if it is updated using
    mt76_eeprom_override. Fix it initializing macaddr filed of mt76_dev data
    structure with eeprom mac address and running mt76_eeprom_override
    before mt76x02_mac_setaddr
    
    Fixes: d1bc9bf2072c ("mt76: mt76x0: eeprom: add support for MAC address from OF")
    Tested-by: Kevin Schmidt <kevin.patrick.schmidt@googlemail.com>
    Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

commit 0e1870084c84f46ccdfcba0333bf92d692b9c54b
Author: Sudeep Holla <sudeep.holla@arm.com>
Date:   Wed Nov 27 16:04:26 2019 +0000

    cpufreq: vexpress-spc: Switch cpumask from topology core to OPP sharing
    
    Since commit ca74b316df96 ("arm: Use common cpu_topology structure and
    functions.") the core cpumask has to be modified during cpu hotplug
    operations. So using them to set up cpufreq policy cpumask may be
    incorrect as it may contain only cpus that are online at that instance.
    
    Instead, we can use the cpumask setup by OPP library that contains all
    the cpus sharing OPP table using dev_pm_opp_get_sharing_cpus.
    
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

commit f9120602c4b30227e57102c1e79b48c12f7ff753
Author: Sudeep Holla <sudeep.holla@arm.com>
Date:   Wed Nov 27 15:56:40 2019 +0000

    ARM: vexpress: Set-up shared OPP table instead of individual for each CPU
    
    Currently we add individual copy of same OPP table for each CPU within
    the cluster. This is redundant and doesn't reflect the reality.
    
    We can't use core cpumask to set policy->cpus in ve_spc_cpufreq_init()
    anymore as it gets called via cpuhp_cpufreq_online()->cpufreq_online()
    ->cpufreq_driver->init() and the cpumask gets updated upon CPU hotplug
    operations. It also may cause issues when the vexpress_spc_cpufreq
    driver is built as a module.
    
    Since ve_spc_clk_init is built-in device initcall, we should be able to
    use the same topology_core_cpumask to set the opp sharing cpumask via
    dev_pm_opp_set_sharing_cpus and use the same later in the driver via
    dev_pm_opp_get_sharing_cpus.
    
    Cc: Liviu Dudau <liviu.dudau@arm.com>
    Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

commit 961c6a63bcd226eb3e9051c13bc20dbc4e833096
Author: Randy Dunlap <rdunlap@infradead.org>
Date:   Thu Nov 28 14:42:29 2019 -0800

    irqchip/csky: Cleanup Kconfig help text
    
    Fixes to Kconfig help text:
    
    - spell out "hardware"
    - fix verb usage
    
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Acked-by: Guo Ren <guoren@kernel.org>
    Link: https://lore.kernel.org/r/ca14f757-f191-62a0-b896-6b3ba0f9d168@infradead.org

commit 52ff679c98731d3d3ae435e29c0620ae3c04a87d
Author: Heyi Guo <guoheyi@huawei.com>
Date:   Sat Nov 30 15:38:49 2019 +0800

    irqchip/gic-v3-its: Set VPENDING table as inner-shareable
    
    There is no special reason to set virtual LPI pending table as
    non-shareable. If we choose to hard code the shareability without
    probing, inner-shareable will be a better choice, for all the other
    ITS/GICR tables prefer to be inner-shareable.
    
    What's more, on Hisilicon hip08 it will trigger some kind of bus
    warning when mixing use of different shareabilities.
    
    Signed-off-by: Heyi Guo <guoheyi@huawei.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20191130073849.38378-1-guoheyi@huawei.com

commit f027c76962b1cdc9bfbb6927e4e1ccf264fd7c55
Author: Zenghui Yu <yuzenghui@huawei.com>
Date:   Mon Dec 2 15:10:21 2019 +0800

    irqchip/gic-v3-its: Use the its_invall_cmd descriptor when building INVALL
    
    It looks like an obvious mistake to use its_mapc_cmd descriptor when
    building the INVALL command block. It so far worked by luck because
    both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of
    the ITS command descriptor, but we should not rely on it.
    
    Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20191202071021.1251-1-yuzenghui@huawei.com

commit 3464afdf11f9a1e031e7858a05351ceca1792fea
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Sun Dec 1 20:57:28 2019 +0100

    libbpf: Fix readelf output parsing on powerpc with recent binutils
    
    On powerpc with recent versions of binutils, readelf outputs an extra
    field when dumping the symbols of an object file. For example:
    
        35: 0000000000000838    96 FUNC    LOCAL  DEFAULT [<localentry>: 8]     1 btf_is_struct
    
    The extra "[<localentry>: 8]" prevents the GLOBAL_SYM_COUNT variable to
    be computed correctly and causes the check_abi target to fail.
    
    Fix that by looking for the symbol name in the last field instead of the
    8th one. This way it should also cope with future extra fields.
    
    Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Tested-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/bpf/20191201195728.4161537-1-aurelien@aurel32.net

commit 3ee1a9f5d0bc0e9dbac5b014e2e8a7d540b836df
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Nov 29 15:18:45 2019 +0000

    drm/i915/gem: Take timeline->mutex to walk list-of-requests
    
    Though the context is closed and so no more requests can be added to the
    timeline, retirement can still be removing requests. It can even be
    removing the very request we are inspecting and so cause us to wander
    into dead links.
    
    Serialise with the retirement by taking the timeline->mutex used for
    guarding the timeline->requests list.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112404
    Fixes: 4a3174152147 ("drm/i915/gem: Refine occupancy test in kill_context()")
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Cc: Matthew Auld <matthew.auld@intel.com>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191129151845.1092933-1-chris@chris-wilson.co.uk
    (cherry picked from commit 7ce596a8036cf3a4cb9ffa0c4edd8a76a7a43cc3)
    Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

commit d1f4c966475c6dd2545c6625022cb24e878bee11
Author: wenxu <wenxu@ucloud.cn>
Date:   Wed Nov 13 12:21:07 2019 +0800

    netfilter: nf_tables_offload: Check for the NETDEV_UNREGISTER event
    
    Check for the NETDEV_UNREGISTER event from the nft_offload_netdev_event
    function, which is the event that actually triggers the clean up.
    
    Fixes: 06d392cbe3db ("netfilter: nf_tables_offload: remove rules when the device unregisters")
    Signed-off-by: wenxu <wenxu@ucloud.cn>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit 024aa8732acb7d2503eae43c3fe3504d0a8646d0
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Thu Nov 28 23:50:40 2019 +0100

    ACPI: PM: s2idle: Rework ACPI events synchronization
    
    Note that the EC GPE processing need not be synchronized in
    acpi_s2idle_wake() after invoking acpi_ec_dispatch_gpe(), because
    that function checks the GPE status and dispatches its handler if
    need be and the SCI action handler is not going to run anyway at
    that point.
    
    Moreover, it is better to drain all of the pending ACPI events
    before restoring the working-state configuration of GPEs in
    acpi_s2idle_restore(), because those events are likely to be related
    to system wakeup, in which case they will not be relevant going
    forward.
    
    Rework the code to take these observations into account.
    
    Tested-by: Kenneth R. Crudup <kenny@panix.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

commit 016b87ca5c8c6e9e87db442f04dc99609b11ed36
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Thu Nov 28 23:47:51 2019 +0100

    ACPI: EC: Rework flushing of pending work
    
    There is a race condition in the ACPI EC driver, between
    __acpi_ec_flush_event() and acpi_ec_event_handler(), that may
    cause systems to stay in suspended-to-idle forever after a wakeup
    event coming from the EC.
    
    Namely, acpi_s2idle_wake() calls acpi_ec_flush_work() to wait until
    the delayed work resulting from the handling of the EC GPE in
    acpi_ec_dispatch_gpe() is processed, and that function invokes
    __acpi_ec_flush_event() which uses wait_event() to wait for
    ec->nr_pending_queries to become zero on ec->wait, and that wait
    queue may be woken up too early.
    
    Suppose that acpi_ec_dispatch_gpe() has caused acpi_ec_gpe_handler()
    to run, so advance_transaction() has been called and it has invoked
    acpi_ec_submit_query() to queue up an event work item, so
    ec->nr_pending_queries has been incremented (under ec->lock).  The
    work function of that work item, acpi_ec_event_handler() runs later
    and calls acpi_ec_query() to process the event.  That function calls
    acpi_ec_transaction() which invokes acpi_ec_transaction_unlocked()
    and the latter wakes up ec->wait under ec->lock, but it drops that
    lock before returning.
    
    When acpi_ec_query() returns, acpi_ec_event_handler() acquires
    ec->lock and decrements ec->nr_pending_queries, but at that point
    __acpi_ec_flush_event() (woken up previously) may already have
    acquired ec->lock, checked the value of ec->nr_pending_queries (and
    it would not have been zero then) and decided to go back to sleep.
    Next, if ec->nr_pending_queries is equal to zero now, the loop
    in acpi_ec_event_handler() terminates, ec->lock is released and
    acpi_ec_check_event() is called, but it does nothing unless
    ec_event_clearing is equal to ACPI_EC_EVT_TIMING_EVENT (which is
    not the case by default).  In the end, if no more event work items
    have been queued up while executing acpi_ec_transaction_unlocked(),
    there is nothing to wake up __acpi_ec_flush_event() again and it
    sleeps forever, so the suspend-to-idle loop cannot make progress and
    the system is permanently suspended.
    
    To avoid this issue, notice that it actually is not necessary to
    wait for ec->nr_pending_queries to become zero in every case in
    which __acpi_ec_flush_event() is used.
    
    First, during platform-based system suspend (not suspend-to-idle),
    __acpi_ec_flush_event() is called by acpi_ec_disable_event() after
    clearing the EC_FLAGS_QUERY_ENABLED flag, which prevents
    acpi_ec_submit_query() from submitting any new event work items,
    so calling flush_scheduled_work() and flushing ec_query_wq
    subsequently (in order to wait until all of the queries in that
    queue have been processed) would be sufficient to flush all of
    the pending EC work in that case.
    
    Second, the purpose of the flushing of pending EC work while
    suspended-to-idle described above really is to wait until the
    first event work item coming from acpi_ec_dispatch_gpe() is
    complete, because it should produce system wakeup events if
    that is a valid EC-based system wakeup, so calling
    flush_scheduled_work() followed by flushing ec_query_wq is also
    sufficient for that purpose.
    
    Rework the code to follow the above observations.
    
    Fixes: 56b9918490 ("PM: sleep: Simplify suspend-to-idle control flow")
    Reported-by: Kenneth R. Crudup <kenny@panix.com>
    Tested-by: Kenneth R. Crudup <kenny@panix.com>
    Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

commit cb50445130d14a5a609d7cd88db9d0436313c881
Author: Takashi Iwai <tiwai@suse.de>
Date:   Mon Dec 2 08:49:47 2019 +0100

    ALSA: hda: Modify stream stripe mask only when needed
    
    The recent commit in HD-audio stream management for changing the
    stripe control seems causing a regression on some platforms.  The
    stripe control is currently used only by HDMI codec, and applying the
    stripe mask unconditionally may lead to scratchy and static noises as
    seen on some MacBooks.
    
    For addressing the regression, this patch changes the stream
    management code to apply the stripe mask conditionally only when the
    codec driver requested.
    
    Fixes: 9b6f7e7a296e ("ALSA: hda: program stripe bits for controller")
    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204477
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20191202074947.1617-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>

commit b3f7931f5c61ba39e81a5c958bf5d65ebb1838af
Author: Juergen Gross <jgross@suse.com>
Date:   Thu Nov 7 12:15:46 2019 +0100

    xen/gntdev: switch from kcalloc() to kvcalloc()
    
    With sufficient many pages to map gntdev can reach order 9 allocation
    sizes. As there is no need to have physically contiguous buffers switch
    to kvcalloc() in order to avoid failing allocations.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>

commit 3b06ac6707c196b5036fe013c460da86c9060085
Author: Juergen Gross <jgross@suse.com>
Date:   Thu Nov 7 12:15:45 2019 +0100

    xen/gntdev: replace global limit of mapped pages by limit per call
    
    Today there is a global limit of pages mapped via /dev/xen/gntdev set
    to 1 million pages per default. There is no reason why that limit is
    existing, as total number of grant mappings is limited by the
    hypervisor anyway and preferring kernel mappings over userspace ones
    doesn't make sense. It should be noted that the gntdev device is
    usable by root only.
    
    Additionally checking of that limit is fragile, as the number of pages
    to map via one call is specified in a 32-bit unsigned variable which
    isn't tested to stay within reasonable limits (the only test is the
    value to be <= zero, which basically excludes only calls without any
    mapping requested). So trying to map e.g. 0xffff0000 pages while
    already nearly 1000000 pages are mapped will effectively lower the
    global number of mapped pages such that a parallel call mapping a
    reasonable amount of pages can succeed in spite of the global limit
    being violated.
    
    So drop the global limit and introduce per call limit instead. This
    per call limit (default: 65536 grant mappings) protects against
    allocating insane large arrays in the kernel for doing a hypercall
    which will fail anyway in case a user is e.g. trying to map billions
    of pages.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>

commit d41b26d81a83e04500e926fbab746ae87c20bb0e
Author: Colin Ian King <colin.king@canonical.com>
Date:   Mon Nov 11 12:20:09 2019 +0000

    xen/gntdev: remove redundant non-zero check on ret
    
    The non-zero check on ret is always going to be false because
    ret was initialized as zero and the only place it is set to
    non-zero contains a return path before the non-zero check. Hence
    the check is redundant and can be removed.
    
    [ jgross@suse.com: limit scope of ret ]
    
    Addresses-Coverity: ("Logically dead code")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>

commit 348be43384e6bcd5e9da7ff5f1680d49f65c488d
Author: Juergen Gross <jgross@suse.com>
Date:   Fri Nov 29 13:39:41 2019 +0100

    xen/events: remove event handling recursion detection
    
    __xen_evtchn_do_upcall() contains guards against being called
    recursively. This mechanism was introduced in the early pvops times
    (kernel 2.6.26) when there were all the Xen backend drivers missing
    from the upstream kernel, and some of those out-of-tree drivers were
    enabling interrupts in their event handlers (which was explicitly
    allowed in the initial XenoLinux).
    
    Nowadays we don't need to support those old drivers any more and the
    capability to allow recursive calls of __xen_evtchn_do_upcall() can
    be removed.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>

commit e1608f3fa857b600045b6df7f7dadc70eeaa4496
Author: Daniel Borkmann <daniel@iogearbox.net>
Date:   Fri Nov 29 23:29:11 2019 +0100

    bpf: Avoid setting bpf insns pages read-only when prog is jited
    
    For the case where the interpreter is compiled out or when the prog is jited
    it is completely unnecessary to set the BPF insn pages as read-only. In fact,
    on frequent churn of BPF programs, it could lead to performance degradation of
    the system over time since it would break the direct map down to 4k pages when
    calling set_memory_ro() for the insn buffer on x86-64 / arm64 and there is no
    reverse operation. Thus, avoid breaking up large pages for data maps, and only
    limit this to the module range used by the JIT where it is necessary to set
    the image read-only and executable.
    
    Suggested-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Link: https://lore.kernel.org/bpf/20191129222911.3710-1-daniel@iogearbox.net

commit 2115fbf7210bd053ba55a95e7ebc366df41aa9cf
Author: Heiko Carstens <heiko.carstens@de.ibm.com>
Date:   Mon Nov 18 13:59:25 2019 +0100

    s390: remove compat vdso code
    
    Remove compat vdso code, since there is hardly any compat user space
    left. Still existing compat user space will have to use system calls
    instead.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

commit d21b7e6b985c15ff75e8668b0282ec5104391901
Author: Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun Dec 1 16:08:46 2019 +0900

    MAINTAINERS: update Kbuild/Kconfig maintainer's email address
    
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

commit 466e16f0920f3ffdfa49713212fa334fb3dc08f1
Author: NeilBrown <neilb@suse.de>
Date:   Thu Nov 28 13:56:43 2019 +1100

    nfsd: check for EBUSY from vfs_rmdir/vfs_unink.
    
    vfs_rmdir and vfs_unlink can return -EBUSY if the
    target is a mountpoint.  This currently gets passed to
    nfserrno() by nfsd_unlink(), and that results in a WARNing,
    which is not user-friendly.
    
    Possibly the best NFSv4 error is NFS4ERR_FILE_OPEN, because
    there is a sense in which the object is currently in use
    by some other task.  The Linux NFSv4 client will map this
    back to EBUSY, which is an added benefit.
    
    For NFSv3, the best we can do is probably NFS3ERR_ACCES, which isn't
    true, but is not less true than the other options.
    
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

commit a25e3726b32c746c0098125d4c7463bb84df72bb
Author: Trond Myklebust <trondmy@gmail.com>
Date:   Wed Nov 27 17:05:51 2019 -0500

    nfsd: Ensure CLONE persists data and metadata changes to the target file
    
    The NFSv4.2 CLONE operation has implicit persistence requirements on the
    target file, since there is no protocol requirement that the client issue
    a separate operation to persist data.
    For that reason, we should call vfs_fsync_range() on the destination file
    after a successful call to vfs_clone_file_range().
    
    Fixes: ffa0160a1039 ("nfsd: implement the NFSv4.2 CLONE operation")
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Cc: stable@vger.kernel.org # v4.5+
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

commit d50264f1fef92967e2d2c9d91bdb05de214ddacf
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Fri Nov 29 10:07:01 2019 +0100

    netfilter: nf_flow_table_offload: add IPv6 match description
    
    Add missing IPv6 matching description to flow_rule object.
    
    Fixes: 5c27d8d76ce8 ("netfilter: nf_flow_table_offload: add IPv6 support")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit c7c17e6a03e08860f7a40095643e72c24c3f896b
Author: Florian Westphal <fw@strlen.de>
Date:   Thu Nov 28 13:25:48 2019 +0100

    netfilter: conntrack: tell compiler to not inline nf_ct_resolve_clash
    
    At this time compiler inlines it, but this code will not be executed
    under normal conditions.
    
    Also, no inlining allows to use "nf_ct_resolve_clash%return" perf probe.
    
    Signed-off-by: Florian Westphal <fw@strlen.de>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit dc4d3f2e12a6e8a22d13b0d648a6529e403b65a6
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Nov 26 13:12:26 2019 -0700

    netfilter: nf_flow_table_offload: Don't use offset uninitialized in flow_offload_port_{d,s}nat
    
    Clang warns (trimmed the second warning for brevity):
    
    ../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable
    'offset' is used uninitialized whenever switch default is taken
    [-Wsometimes-uninitialized]
            default:
            ^~~~~~~
    ../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use
    occurs here
            flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                                   ^~~~~~
    ../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the
    variable 'offset' to silence this warning
            u32 offset;
                      ^
                       = 0
    
    Match what was done in the flow_offload_ipv{4,6}_{d,s}nat functions and
    just return in the default case, since port would also be uninitialized.
    
    Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
    Link: https://github.com/ClangBuiltLinux/linux/issues/780
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Reported-by: kernelci.org bot <bot@kernelci.org>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit e052901991ae21e15851bfc89c682bfcb39a4dcf
Author: wenxu <wenxu@ucloud.cn>
Date:   Wed Nov 20 13:12:22 2019 +0800

    netfilter: nf_flow_table_offload: Fix block_cb tc_setup_type as TC_SETUP_CLSFLOWER
    
    Add/del/stats flows through block_cb call must set the tc_setup_type as
    TC_SETUP_CLSFLOWER.
    
    Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
    Signed-off-by: wenxu <wenxu@ucloud.cn>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit ee1bcfe01251e8958b53de45d2b0c85e09dd2719
Author: wenxu <wenxu@ucloud.cn>
Date:   Wed Nov 20 12:30:42 2019 +0800

    netfilter: nf_flow_table_offload: Fix block setup as TC_SETUP_FT cmd
    
    Set up block through TC_SETUP_FT command.
    
    Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
    Signed-off-by: wenxu <wenxu@ucloud.cn>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

commit aa137a6d302b5989ed205b7dfb7fe40a8851babc
Author: Miroslav Benes <mbenes@suse.cz>
Date:   Wed Nov 6 10:56:01 2019 +0100

    s390/livepatch: Implement reliable stack tracing for the consistency model
    
    The livepatch consistency model requires reliable stack tracing
    architecture support in order to work properly. In order to achieve
    this, two main issues have to be solved. First, reliable and consistent
    call chain backtracing has to be ensured. Second, the unwinder needs to
    be able to detect stack corruptions and return errors.
    
    The "zSeries ELF Application Binary Interface Supplement" says:
    
      "The stack pointer points to the first word of the lowest allocated
      stack frame. If the "back chain" is implemented this word will point to
      the previously allocated stack frame (towards higher addresses), except
…
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 9, 2019
Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Dec 10, 2019
…low_offload_port_{d,s}nat

Clang warns (trimmed the second warning for brevity):

../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable
'offset' is used uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use
occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the
variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0

Match what was done in the flow_offload_ipv{4,6}_{d,s}nat functions and
just return in the default case, since port would also be uninitialized.

Fixes: c29f74e ("netfilter: nf_flow_table: hardware offload support")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Dec 10, 2019
Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
mpe added a commit to linuxppc/linux that referenced this issue Dec 19, 2019
Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
@nathanchance

This comment has been minimized.

Copy link
Member Author

@nathanchance nathanchance commented Dec 30, 2019

mpe added a commit to linuxppc/linux that referenced this issue Jan 6, 2020
Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
tobetter added a commit to tobetter/linux that referenced this issue Jan 9, 2020
…low_offload_port_{d,s}nat

Clang warns (trimmed the second warning for brevity):

../net/netfilter/nf_flow_table_offload.c:342:2: warning: variable
'offset' is used uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
../net/netfilter/nf_flow_table_offload.c:346:57: note: uninitialized use
occurs here
        flow_offload_mangle(entry, flow_offload_l4proto(flow), offset,
                                                               ^~~~~~
../net/netfilter/nf_flow_table_offload.c:331:12: note: initialize the
variable 'offset' to silence this warning
        u32 offset;
                  ^
                   = 0

Match what was done in the flow_offload_ipv{4,6}_{d,s}nat functions and
just return in the default case, since port would also be uninitialized.

Fixes: c29f74e ("netfilter: nf_flow_table: hardware offload support")
Link: ClangBuiltLinux#780
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
ZyCromerZ pushed a commit to ZyCromerZ/android_kernel_asus_X01BD that referenced this issue Feb 10, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ZyCromerZ pushed a commit to ZyCromerZ/android_kernel_asus_X01BD that referenced this issue Feb 11, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit c3aae14 upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
freeza-inc added a commit to freeza-inc/bm-galaxy-note10-sd855-Q that referenced this issue Feb 15, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f5099297c ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to ragy365/onclite_zeus_kernel that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sdm835 that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sdm660 that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sm8150 that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to mylove90/android_kernel_xiaomi_onc that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to DerpFest-Devices/kernel_xiaomi_onclite that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mylove90 added a commit to Xtended-Devices/android_kernel_xiaomi_onclite that referenced this issue Feb 16, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
venomdev-kernel added a commit to venomdev-kernel/Venoom that referenced this issue Feb 17, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mokeeopensource pushed a commit to MoKee/android_kernel_xiaomi_onclite that referenced this issue Feb 17, 2020
commit c3aae14e5d468d18dbb5d7c0c8c7e2968cc14aad upstream.

Clang warns:

../arch/powerpc/boot/4xx.c:231:3: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
        val = SDRAM0_READ(DDR0_42);
        ^
../arch/powerpc/boot/4xx.c:227:2: note: previous statement is here
        else
        ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

Fixes: d23f509 ("[POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: ClangBuiltLinux/linux#780
Link: https://lore.kernel.org/r/20191209200338.12546-1-natechancellor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.