Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wmisleading-indentation in drivers/scsi/qla4xxx/ql4_os.c #819

Closed
nathanchance opened this issue Dec 18, 2019 · 2 comments
Closed

-Wmisleading-indentation in drivers/scsi/qla4xxx/ql4_os.c #819

nathanchance opened this issue Dec 18, 2019 · 2 comments

Comments

@nathanchance
Copy link
Member

@nathanchance nathanchance commented Dec 18, 2019

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is here
        if (ha->queues)
        ^
1 warning generated.

Patch submitted: https://lore.kernel.org/lkml/20191218015252.20890-1-natechancellor@gmail.com/

@nathanchance nathanchance self-assigned this Dec 18, 2019
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 20, 2019
Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
@nathanchance

This comment has been minimized.

fengguang pushed a commit to 0day-ci/linux that referenced this issue Dec 23, 2019
Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
hnaz added a commit to hnaz/linux-mm that referenced this issue Jan 3, 2020
GIT 8c9a586be5e85f4e8d5620f8d3069a84bb1d4637

commit 539cebf23ccf30a10d371530bc60accabdb3c7ce
Author: Bart Van Assche <bvanassche@acm.org>
Date:   Wed Dec 18 16:44:12 2019 -0800

    scsi: qla2xxx: Fix sparse warnings triggered by the PCI state checking code
    
    This patch fixes the following sparse warnings:
    
    drivers/scsi/qla2xxx/qla_mbx.c:120:21: warning: restricted pci_channel_state_t degrades to integer
    drivers/scsi/qla2xxx/qla_mbx.c:120:37: warning: restricted pci_channel_state_t degrades to integer
    
    This patch does not change any functionality. From include/linux/pci.h:
    
    enum pci_channel_state {
            /* I/O channel is in normal state */
            pci_channel_io_normal = (__force pci_channel_state_t) 1,
    
            /* I/O to channel is blocked */
            pci_channel_io_frozen = (__force pci_channel_state_t) 2,
    
            /* PCI card is dead */
            pci_channel_io_perm_failure = (__force pci_channel_state_t) 3,
    };
    
    Cc: Himanshu Madhani <hmadhani@marvell.com>
    Cc: Quinn Tran <qutran@marvell.com>
    Cc: Martin Wilck <mwilck@suse.com>
    Cc: Daniel Wagner <dwagner@suse.de>
    Cc: Roman Bolshakov <r.bolshakov@yadro.com>
    Link: https://lore.kernel.org/r/20191219004412.37639-1-bvanassche@acm.org
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Reviewed-by: Daniel Wagner <dwagner@suse.de>
    Acked-by: Himanshu Madhani <hmadhani@marvell.com>
    Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit acae5720e08852c0a31264a31ffbfc15e13bddf7
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Dec 17 18:47:26 2019 -0700

    scsi: csiostor: Adjust indentation in csio_device_reset
    
    Clang warns:
    
    ../drivers/scsi/csiostor/csio_scsi.c:1386:3: warning: misleading
    indentation; statement is not part of the previous 'if'
    [-Wmisleading-indentation]
             csio_lnodes_exit(hw, 1);
             ^
    ../drivers/scsi/csiostor/csio_scsi.c:1382:2: note: previous statement is
    here
            if (*buf != '1')
            ^
    1 warning generated.
    
    This warning occurs because there is a space after the tab on this
    line.  Remove it so that the indentation is consistent with the Linux
    kernel coding style and clang no longer warns.
    
    Fixes: a3667aaed569 ("[SCSI] csiostor: Chelsio FCoE offload driver")
    Link: https://github.com/ClangBuiltLinux/linux/issues/818
    Link: https://lore.kernel.org/r/20191218014726.8455-1-natechancellor@gmail.com
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 6f058c0007d9db250e0730ea83c08cb8850fa2da
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Dec 17 18:42:20 2019 -0700

    scsi: aic7xxx: Adjust indentation in ahc_find_syncrate
    
    Clang warns:
    
    ../drivers/scsi/aic7xxx/aic7xxx_core.c:2317:5: warning: misleading
    indentation; statement is not part of the previous 'if'
    [-Wmisleading-indentation]
                            if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
                            ^
    ../drivers/scsi/aic7xxx/aic7xxx_core.c:2310:4: note: previous statement
    is here
                            if (syncrate == &ahc_syncrates[maxsync])
                            ^
    1 warning generated.
    
    This warning occurs because there is a space amongst the tabs on this
    line. Remove it so that the indentation is consistent with the Linux kernel
    coding style and clang no longer warns.
    
    This has been a problem since the beginning of git history hence no fixes
    tag.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/817
    Link: https://lore.kernel.org/r/20191218014220.52746-1-natechancellor@gmail.com
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit e4dc9a4c31fe10d1751c542702afc85be8a5c56a
Author: Israel Rukshin <israelr@mellanox.com>
Date:   Wed Dec 11 17:36:02 2019 +0200

    scsi: target/iblock: Fix protection error with blocks greater than 512B
    
    The sector size of the block layer is 512 bytes, but integrity interval
    size might be different (in case of 4K block size of the media). At the
    initiator side the virtual start sector is the one that was originally
    submitted by the block layer (512 bytes) for the Reftag usage. The
    initiator converts the Reftag to integrity interval units and sends it to
    the target. So the target virtual start sector should be calculated at
    integrity interval units. prepare_fn() and complete_fn() don't remap
    correctly the Reftag when using incorrect units of the virtual start
    sector, which leads to the following protection error at the device:
    
    "blk_update_request: protection error, dev sdb, sector 2048 op 0x0:(READ)
    flags 0x10000 phys_seg 1 prio class 0"
    
    To fix that, set the seed in integrity interval units.
    
    Link: https://lore.kernel.org/r/1576078562-15240-1-git-send-email-israelr@mellanox.com
    Signed-off-by: Israel Rukshin <israelr@mellanox.com>
    Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
    Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 71482fde704efdd8c3abe0faf34d922c61e8d76b
Author: Varun Prakash <varun@chelsio.com>
Date:   Wed Dec 18 19:15:31 2019 +0530

    scsi: libcxgbi: fix NULL pointer dereference in cxgbi_device_destroy()
    
    If cxgb4i_ddp_init() fails then cdev->cdev2ppm will be NULL, so add a check
    for NULL pointer before dereferencing it.
    
    Link: https://lore.kernel.org/r/1576676731-3068-1-git-send-email-varun@chelsio.com
    Signed-off-by: Varun Prakash <varun@chelsio.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 291c2548458d3a8b326bfa8d7abbba86e036faf7
Author: Colin Ian King <colin.king@canonical.com>
Date:   Wed Dec 18 08:43:01 2019 +0000

    scsi: lpfc: fix spelling mistakes of asynchronous
    
    There are spelling mistakes of asynchronous in a lpfc_printf_log message
    and comments. Fix these.
    
    Link: https://lore.kernel.org/r/20191218084301.627555-1-colin.king@canonical.com
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: James Smart <james.smart@broadcom.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit a94a87f099734fc6a5c18f54fd651dc348076d22
Author: Nathan Chancellor <natechancellor@gmail.com>
Date:   Tue Dec 17 18:52:52 2019 -0700

    scsi: qla4xxx: Adjust indentation in qla4xxx_mem_free
    
    Clang warns:
    
    ../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
    indentation; statement is not part of the previous 'if'
    [-Wmisleading-indentation]
             if (ha->fw_dump)
             ^
    ../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
    here
            if (ha->queues)
            ^
    1 warning generated.
    
    This warning occurs because there is a space after the tab on this
    line.  Remove it so that the indentation is consistent with the Linux
    kernel coding style and clang no longer warns.
    
    Fixes: 068237c87c64 ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
    Link: https://github.com/ClangBuiltLinux/linux/issues/819
    Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Acked-by: Manish Rangankar <mrangankar@marvell.com>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 380f4589475393f343cc940a12e10c18558363d6
Author: Aditya Pakki <pakki001@umn.edu>
Date:   Tue Dec 17 15:22:13 2019 -0600

    scsi: libfc: remove unnecessary assertion on ep variable
    
    In ft_recv_write_data(), the pointer ep is dereferenced first and then
    asserts for NULL. The patch removes the unnecessary assertion.
    
    Link: https://lore.kernel.org/r/20191217212214.30722-1-pakki001@umn.edu
    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 1c5d50beb71838867f743a66a8c634c5c1bc674b
Author: Chen Zhou <chenzhou10@huawei.com>
Date:   Tue Dec 17 21:43:09 2019 +0800

    scsi: initio: make initio_state_7() static
    
    Fix sparse warning:
    
    drivers/scsi/initio.c:1643:5: warning: symbol 'initio_state_7' was not declared. Should it be static?
    
    Link: https://lore.kernel.org/r/20191217134309.41649-1-chenzhou10@huawei.com
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 37435fe941e8122fbef71f3b63a8ed6f76a505fc
Author: Chen Zhou <chenzhou10@huawei.com>
Date:   Fri Dec 13 14:40:42 2019 +0800

    scsi: ibmvscsi_tgt: remove set but not used variables 'iue' and 'sd'
    
    Fixes gcc '-Wunused-but-set-variable' warning:
    
    drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function ibmvscsis_send_messages:
    drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1888:19: warning: variable iue set but not used [-Wunused-but-set-variable]
    drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function ibmvscsis_queue_data_in:
    drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3806:8: warning: variable sd set but not used [-Wunused-but-set-variable]
    
    Link: https://lore.kernel.org/r/20191213064042.161840-1-chenzhou10@huawei.com
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 28ab0b4662314dc54b95c44eadaf1bb46bc94978
Author: Chen Zhou <chenzhou10@huawei.com>
Date:   Thu Dec 12 10:35:56 2019 +0800

    scsi: sym53c8xx: fix typos in comments
    
    Fix the typo "GPOI" -> "GPIO" in comment.
    
    Link: https://lore.kernel.org/r/20191212023556.72618-1-chenzhou10@huawei.com
    Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit a9420f062e60cb2c81c76d8835c8dbe753353956
Author: Bart Van Assche <bvanassche@acm.org>
Date:   Mon Dec 9 09:42:05 2019 -0800

    scsi: core: Fix a compiler warning triggered by the SCSI logging code
    
    This patch fixes the following compiler warning:
    
    In file included from drivers/scsi/scsi_error.c:46:
    drivers/scsi/scsi_error.c: In function 'scsi_eh_target_reset':
    drivers/scsi/scsi_logging.h:65:81: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
       65 | LOGGING(SCSI_LOG_ERROR_SHIFT, SCSI_LOG_ERROR_BITS, LEVEL,CMD);
          |                                                              ^
    
    drivers/scsi/scsi_error.c:1562:4: note: in expansion of macro 'SCSI_LOG_ERROR_RECOVERY'
     1562 |    SCSI_LOG_ERROR_RECOVERY(3,
          |    ^~~~~~~~~~~~~~~~~~~~~~~
    
    Link: https://lore.kernel.org/r/20191209174205.190025-1-bvanassche@acm.org
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 7d1ff0d9faf66f630c104a6ca6b8a3c6091ba3a3
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Dec 19 22:13:44 2019 +0000

    drm/i915/gt: Add breadcrumb retire to physical engine
    
    Avoid adding the retire workers to the virtual engine so that we don't
    end up in the unenviable situation of trying to free the virtual engine
    while its worker remains active.
    
    Fixes: dc93c9b69315 ("drm/i915/gt: Schedule request retirement when signaler idles")
    Closes: https://gitlab.freedesktop.org/drm/intel/issues/867
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219221344.161523-1-chris@chris-wilson.co.uk

commit ef3078e2acc3d611b2f8c631bbc99b4ecf5df9ad
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Fri Dec 13 16:11:35 2019 +0800

    scsi: ufs-mediatek: configure and enable clk-gating
    
    Enable clk-gating with customized delayed timer value in MediaTek Chipsets.
    
    Link: https://lore.kernel.org/r/1576224695-22657-5-git-send-email-stanley.chu@mediatek.com
    Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 4ccdd720d829dfa324ce27c240a6b04c9d9b38b3
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Fri Dec 13 16:11:34 2019 +0800

    scsi: ufs-mediatek: configure customized auto-hibern8 timer
    
    Configure customized auto-hibern8 timer in MediaTek Chipsets.
    
    Link: https://lore.kernel.org/r/1576224695-22657-4-git-send-email-stanley.chu@mediatek.com
    Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit d428999cdb96d027719ade411f856d3af226edc1
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Fri Dec 13 16:11:33 2019 +0800

    scsi: ufs: export ufshcd_auto_hibern8_update for vendor usage
    
    Export ufshcd_auto_hibern8_update to allow vendors to use common interface
    to customize auto-hibernate timer.
    
    Link: https://lore.kernel.org/r/1576224695-22657-3-git-send-email-stanley.chu@mediatek.com
    Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
    Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 0eb6facef47c3ac25a36838bbaac803ecd9a462a
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Fri Dec 13 16:11:32 2019 +0800

    scsi: ufs-mediatek: introduce reference clock control
    
    Introduce reference clock control in MediaTek Chipset in order to disable
    it if it is not necessary by UFS device to save system power.
    
    Currently reference clock can be disabled during system suspend, runtime
    suspend and clock-gating after link enters hibernate state.
    
    Link: https://lore.kernel.org/r/1576224695-22657-2-git-send-email-stanley.chu@mediatek.com
    Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit e8accf7c0b344f9c911394adcaa430e2bd7cdf88
Author: Sheeba B <sheebab@cadence.com>
Date:   Mon Dec 16 11:17:12 2019 +0100

    scsi: ufs: Power off hook for Cadence UFS driver
    
    Attach power off hook to Cadence UFS driver.
    
    Link: https://lore.kernel.org/r/1576491432-631-1-git-send-email-sheebab@cadence.com
    Signed-off-by: Sheeba B <sheebab@cadence.com>
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit 9c528229a75d86084f644f51fa211f9a6e62038c
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Sat Dec 7 20:22:01 2019 +0800

    scsi: ufs: disable interrupt during clock-gating
    
    Similar to suspend, ufshcd interrupt can be disabled since there won't be
    any host controller transaction expected till clocks ungated.
    
    Link: https://lore.kernel.org/r/1575721321-8071-3-git-send-email-stanley.chu@mediatek.com
    Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit cdeb8a77de75d7e3183dd2dba427c6359f1160ab
Author: Stanley Chu <stanley.chu@mediatek.com>
Date:   Sat Dec 7 20:22:00 2019 +0800

    scsi: ufs: disable irq before disabling clocks
    
    During suspend flow, interrupt shall be disabled before disabling clocks to
    avoid potential system hang due to accessing host registers after host
    clocks are disabled.
    
    For example, if an interrupt comes with IRQF_IRQPOLL flag configured with
    the misrouted interrupt recovery feature enabled, ufshcd ISR may be
    triggered even if nothing shall be done for UFS. In this case, system hang
    may happen if UFS interrupt status register is accessed with host clocks
    disabled.
    
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Link: https://lore.kernel.org/r/1575721321-8071-2-git-send-email-stanley.chu@mediatek.com
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

commit fd7bba685e7d9ebc45de2a7e9bd974fdd615abdf
Author: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Date:   Thu Dec 19 11:13:34 2019 -0800

    Input: apbps2 - add __iomem to register struct
    
    Add __iomem to the apbps2_priv.regs field to make the numerous
    warnings about differing address spaces go away. Fixes warnings
    such as:
    
    drivers/input/serio/apbps2.c:65:26: warning: incorrect type in argument 1 (different address spaces)
    drivers/input/serio/apbps2.c:65:26:    expected void const volatile [noderef] <asn:2> *addr
    drivers/input/serio/apbps2.c:65:26:    got unsigned int [noderef] *
    drivers/input/serio/apbps2.c:65:26: warning: incorrect type in argument 1 (different address spaces)
    drivers/input/serio/apbps2.c:65:26:    expected void const volatile [noderef] <asn:2> *addr
    drivers/input/serio/apbps2.c:65:26:    got unsigned int [noderef] *
    drivers/input/serio/apbps2.c:65:26: warning: incorrect type in argument 1 (different address spaces)
    drivers/input/serio/apbps2.c:65:26:    expected void const volatile [noderef] <asn:2> *addr
    drivers/input/serio/apbps2.c:65:26:    got unsigned int [noderef] *
    drivers/input/serio/apbps2.c:65:26: warning: incorrect type in argument 1 (different address spaces)
    drivers/input/serio/apbps2.c:65:26:    expected void const volatile [noderef] <asn:2> *addr
    [rest snipped]
    
    Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
    Link: https://lore.kernel.org/r/20191217122507.2157454-1-ben.dooks@codethink.co.uk
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

commit cbe821a20f3d46b419caa6fccf9e9812fff0e392
Author: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Date:   Thu Dec 19 11:13:13 2019 -0800

    Input: axp20x-pek - make device attributes static
    
    The two device attrbitues are not declared outside this file
    so make them static to avoid the following warnings:
    
    drivers/input/misc/axp20x-pek.c:194:1: warning: symbol 'dev_attr_startup' was not declared. Should it be static?
    drivers/input/misc/axp20x-pek.c:195:1: warning: symbol 'dev_attr_shutdown' was not declared. Should it be static?
    
    Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
    Acked-by: Chen-Yu Tsai <wens@csie.org>
    Link: https://lore.kernel.org/r/20191217152541.2167080-1-ben.dooks@codethink.co.uk
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

commit 5bf2fc1f9c88397b125d5ec5f65b1ed9300ba59d
Author: Aditya Pakki <pakki001@umn.edu>
Date:   Thu Dec 19 11:57:35 2019 -0600

    bpf: Remove unnecessary assertion on fp_old
    
    The two callers of bpf_prog_realloc - bpf_patch_insn_single and
    bpf_migrate_filter dereference the struct fp_old, before passing
    it to the function. Thus assertion to check fp_old is unnecessary
    and can be removed.
    
    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Link: https://lore.kernel.org/bpf/20191219175735.19231-1-pakki001@umn.edu

commit 93ccfa9a4eca482216c5caf88be77e5ffa0d744a
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Dec 19 17:17:22 2019 +0100

    drm/todo: Updating logging todo
    
    Jani has merged a new set of logging functions, which we hope to be
    the One True solution now, pinky promises:
    
    commit fb6c7ab8718eb2543695d77ad8302ff81e8e1e32
    Author: Jani Nikula <jani.nikula@intel.com>
    Date:   Tue Dec 10 14:30:43 2019 +0200
    
        drm/print: introduce new struct drm_device based logging macros
    
    Update the todo entry to match the new preference.
    
    v2: Fix spelling issue Sam noticed.
    
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Sean Paul <sean@poorly.run>
    Cc: Wambui Karuga <wambui.karugax@gmail.com>
    Acked-by: Jani Nikula <jani.nikula@intel.com>
    Acked-by: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219161722.2779994-1-daniel.vetter@ffwll.ch

commit 27b986d5dd4ff940805624890f69bc63ecee4d02
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Tue Dec 3 10:57:23 2019 +0100

    Documentation: document ioctl interfaces better
    
    Documentation/process/botching-up-ioctls.rst was orignally written as
    a blog post for DRM driver writers, so it it misses some points while
    going into a lot of detail on others.
    
    Try to provide a replacement that addresses typical issues across a wider
    range of subsystems, and follows the style of the core-api documentation
    better.
    
    Many improvements to the document are suggested by Ben Hutchings
    <ben.hutchings@codethink.co.uk>, Jonathan Corbet <corbet@lwn.net> and
    Geert Uytterhoeven <geert@linux-m68k.org>.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit afc6f62bd073ea82c4828e088a59ab53c30b3628
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Nov 29 11:48:31 2019 +0100

    compat_ioctl: simplify up block/ioctl.c
    
    Having separate implementations of blkdev_ioctl() often leads to these
    getting out of sync, despite the comment at the top.
    
    Since most of the ioctl commands are compatible, and we try very hard
    not to add any new incompatible ones, move all the common bits into a
    shared function and leave only the ones that are historically different
    in separate functions for native/compat mode.
    
    To deal with the compat_ptr() conversion, pass both the integer
    argument and the pointer argument into the new blkdev_common_ioctl()
    and make sure to always use the correct one of these.
    
    blkdev_ioctl() is now only kept as a separate exported interfact
    for drivers/char/raw.c, which lacks a compat_ioctl variant.
    We should probably either move raw.c to staging if there are no
    more users, or export blkdev_compat_ioctl() as well.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 1d9fe5f3f15e770ee277f4f95da15d78dc584a4b
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 11:28:41 2019 +0100

    compat_ioctl: block: simplify compat_blkpg_ioctl()
    
    There is no need to go through a compat_alloc_user_space()
    copy any more, just wrap the function in a small helper that
    works the same way for native and compat mode.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit c1549d610d3cd4e62ff05204abba53e8d736233e
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Nov 29 11:45:30 2019 +0100

    compat_ioctl: block: move blkdev_compat_ioctl() into ioctl.c
    
    Having both in the same file allows a number of simplifications
    to the compat path, and makes it more likely that changes to
    the native path get applied to the compat version as well.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 1fd4e58ac5cf5414297395b32d113674590e2f85
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 17:14:59 2019 +0100

    compat_ioctl: move HDIO ioctl handling into drivers/ide
    
    Most of the HDIO ioctls are only used by the obsolete drivers/ide
    subsystem, these can be handled by changing ide_cmd_ioctl() to be aware
    of compat mode and doing the correct transformations in place and using
    it as both native and compat handlers for all drivers.
    
    The SCSI drivers implementing the same commands are already doing
    this in the drivers, so the compat_blkdev_driver_ioctl() function
    is no longer needed now.
    
    The BLKSECTSET and HDIO_GETGEO_BIG ioctls are not implemented
    in any driver any more and no longer need any conversion.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 0b69da780d5adb055fa9169ea13022e6e1ea6215
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Nov 30 20:28:12 2019 +0100

    compat_ioctl: scsi: handle HDIO commands from drivers
    
    The ata_sas_scsi_ioctl() function implements a number of HDIO_* commands
    for SCSI devices, it is used by all libata drivers as well as a few
    drivers that support SAS attached SATA drives.
    
    The only command that is not safe for compat ioctls here is
    HDIO_GET_32BIT. Change the implementation to check for in_compat_syscall()
    in order to do both cases correctly, and change all callers to use it
    as both native and compat callback pointers, including the indirect
    callers through sas_ioctl and ata_scsi_ioctl.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 561962e351f65770bbb57be3c2b4d54999ba4917
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 15:55:17 2019 +0100

    compat_ioctl: move cdrom commands into cdrom.c
    
    There is no need for the special cases for the cdrom ioctls any more now,
    so make sure that each cdrom driver has a .compat_ioctl() callback and
    calls cdrom_compat_ioctl() directly there.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 97524812d006be3c454ffddd07eb0a2baa1c3c83
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Wed Nov 27 21:25:36 2019 +0100

    compat_ioctl: simplify the implementation
    
    Now that both native and compat ioctl syscalls are
    in the same file, a couple of simplifications can
    be made, bringing the implementation closer together:
    
    - do_vfs_ioctl(), ioctl_preallocate(), and compat_ioctl_preallocate()
      can become static, allowing the compiler to optimize better
    
    - slightly update the coding style for consistency between
      the functions.
    
    - rather than listing each command in two switch statements
      for the compat case, just call a single function that has
      all the common commands.
    
    As a side-effect, FS_IOC_RESVSP/FS_IOC_RESVSP64 are now available
    to x86 compat tasks, along with FS_IOC_RESVSP_32/FS_IOC_RESVSP64_32.
    This is harmless for i386 emulation, and can be considered a bugfix
    for x32 emulation, which never supported these in the past.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 8150885f575370061c153637300180c14a7c6c6e
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Jun 7 10:06:42 2019 +0200

    compat_ioctl: move sys_compat_ioctl() to ioctl.c
    
    The rest of the fs/compat_ioctl.c file is no longer useful now,
    so move the actual syscall as planned.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 828c83bb7a16e3679d8fb1bfd36864787b57269b
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Mar 15 17:39:44 2019 +0100

    compat_ioctl: scsi: move ioctl handling into drivers
    
    Each driver calling scsi_ioctl() gets an equivalent compat_ioctl()
    handler that implements the same commands by calling scsi_compat_ioctl().
    
    The scsi_cmd_ioctl() and scsi_cmd_blk_ioctl() functions are compatible
    at this point, so any driver that calls those can do so for both native
    and compat mode, with the argument passed through compat_ptr().
    
    With this, we can remove the entries from fs/compat_ioctl.c.  The new
    code is larger, but should be easier to maintain and keep updated with
    newly added commands.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 67df7584795a88f7037ccdcba943ccc95ce6a848
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Mar 15 17:26:56 2019 +0100

    compat_ioctl: ide: floppy: add handler
    
    Rather than relying on fs/compat_ioctl.c, this adds support
    for a compat_ioctl() callback in the ide-floppy driver directly,
    which lets it translate the scsi commands.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit c14ab55501b0abfb5a8de0c6a67de63e994cb05e
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Mar 15 17:13:06 2019 +0100

    compat_ioctl: bsg: add handler
    
    bsg_ioctl() calls into scsi_cmd_ioctl() for a couple of generic commands
    and relies on fs/compat_ioctl.c to handle it correctly in compat mode.
    
    Adding a private compat_ioctl() handler avoids that round-trip and lets
    us get rid of the generic emulation once this is done.
    
    Note that bsg implements an SG_IO command that is different from the
    other drivers and does not need emulation.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 1cd73d1efacf7b983fde2aa5de679679ab5667df
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Fri Mar 15 16:45:16 2019 +0100

    compat_ioctl: add scsi_compat_ioctl
    
    In order to move the compat handling for SCSI ioctl commands out of
    fs/compat_ioctl.c into the individual drivers, we need a helper function
    first to match the native ioctl handler called by sd, sr, st, etc.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit dd63a899cdf973b90661614d14fecbaafcdf9612
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 15:48:10 2019 +0100

    compat_ioctl: block: handle cdrom compat ioctl in non-cdrom drivers
    
    Various block drivers implement the CDROMMULTISESSION,
    CDROM_GET_CAPABILITY, and CDROMEJECT ioctl commands, relying on the
    block layer to handle compat_ioctl mode for them.
    
    Move this into the drivers directly as a preparation for simplifying
    the block layer later.
    
    When only integer arguments or no arguments are passed, the
    same handler can be used for .ioctl and .compat_ioctl, and
    when only pointer arguments are passed, the newly added
    blkdev_compat_ptr_ioctl can be used.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 996301c8f64c2cca6c3226ed7a3bbb418951a356
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Mon Dec 9 16:33:16 2019 +0100

    compat_ioctl: cdrom: handle CDROM_LAST_WRITTEN
    
    This is the only ioctl command that does not have a proper
    compat handler. Making the normal implementation do the
    right thing is actually very simply, so just do that by
    using an in_compat_syscall() check to avoid the special
    case in the pkcdvd driver.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 57f8918d35c428b1aa3cf0127d7b731042d18938
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 14:20:53 2019 +0100

    compat_ioctl: move CDROMREADADIO to cdrom.c
    
    Again, there is only one file that needs this, so move the conversion
    handler into the native implementation.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 811278262267eef900038bd2693f8dd4f9311110
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 13:44:48 2019 +0100

    compat_ioctl: move CDROM_SEND_PACKET handling into scsi
    
    There is only one implementation of this ioctl, so move the handling out
    of the common block layer code into the place where it's actually needed.
    
    It also gets called indirectly through pktcdvd, which needs to be aware
    of this change.
    
    As I noticed, the old implementation of the compat handler failed to
    convert the structure on the way out, so the updated fields never got
    written back to user space. This is either not important, or it has
    never worked and should be fixed now.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit dfd0f486c4db179d02c144b7c8c72d6d08585f36
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Nov 30 20:09:07 2019 +0100

    compat_ioctl: ubd, aoe: use blkdev_compat_ptr_ioctl
    
    These drivers implement the HDIO_GET_IDENTITY and CDROMVOLREAD ioctl
    commands, which are compatible between 32-bit and 64-bit user space and
    traditionally handled by compat_blkdev_driver_ioctl().
    
    As a prerequisite to removing that function, make both drivers use
    blkdev_compat_ptr_ioctl() as their .compat_ioctl callback.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 3ea136b4175badace56c403af80b61f577624407
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Nov 28 15:48:10 2019 +0100

    compat_ioctl: block: add blkdev_compat_ptr_ioctl
    
    A lot of block drivers need only a trivial .compat_ioctl callback.
    
    Add a helper function that can be set as the callback pointer
    to only convert the argument using the compat_ptr() conversion
    and otherwise assume all input and output data is compatible,
    or handled using in_compat_syscall() checks.
    
    This mirrors the compat_ptr_ioctl() helper function used in
    character devices.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 2661626d2ec94226e9f397ea1285f008d36ae3d4
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Wed Dec 4 09:35:00 2019 +0100

    compat: scsi: sg: fix v3 compat read/write interface
    
    In the v5.4 merge window, a cleanup patch from Al Viro conflicted
    with my rework of the compat handling for sg.c read(). Linus Torvalds
    did a correct merge but pointed out that the resulting code is still
    unsatisfactory.
    
    I later noticed that the sg_new_read() function still gets the compat
    mode wrong, when the 'count' argument is large enough to pass a
    compat_sg_io_hdr object, but not a nativ sg_io_hdr.
    
    To address both of these, move the definition of compat_sg_io_hdr
    into a scsi/sg.h to make it visible to sg.c and rewrite the logic
    for reading req_pack_id as well as the size check to a simpler
    version that gets the expected results.
    
    Fixes: c35a5cfb4150 ("scsi: sg: sg_read(): simplify reading ->pack_id of userland sg_io_hdr_t")
    Fixes: 98aaaec4a150 ("compat_ioctl: reimplement SG_IO handling")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit 641fd6fa9de9fcf10159bd6f6dde4f0ae0504f7e
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Dec 12 18:15:25 2019 +0100

    compat: provide compat_ptr() on all architectures
    
    In order to avoid needless #ifdef CONFIG_COMPAT checks,
    move the compat_ptr() definition to linux/compat.h
    where it can be seen by any file regardless of the
    architecture.
    
    Only s390 needs a special definition, this can use the
    self-#define trick we have elsewhere.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit fd95b4f6a9ad58e810b74ea219de23fa69a22fed
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Mon Dec 9 16:16:20 2019 +0100

    compat: ARM64: always include asm-generic/compat.h
    
    In order to use compat_* type defininitions in device drivers
    outside of CONFIG_COMPAT, move the inclusion of asm-generic/compat.h
    ahead of the #ifdef.
    
    All other architectures already do this.
    
    Acked-by: Will Deacon <will@kernel.org>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit b5abac2d2d17ce1b30c267dd72fb91c8bc21bee1
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:52 2019 +0000

    net: phy: marvell: use genphy_check_and_restart_aneg()
    
    Use the helper to check and restart autonegotiation for the marvell
    fiber page negotiation setting.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 9f4bae704f93c9b83196781de3df8a4bf1855a4b
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:47 2019 +0000

    net: phy: marvell: use phy_modify_changed()
    
    Use phy_modify_changed() to change the fiber advertisement register
    rather than open coding this functionality.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 20ecf424d0dbb820a337e994c8feec18c1fa77c9
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:42 2019 +0000

    net: phy: marvell: use existing clause 37 definitions
    
    Use existing clause 37 advertising/link partner definitions rather than
    private ones for the advertisement registers.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit d2004e27eb352a5961cae7cc50563dbdc5386ba7
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:36 2019 +0000

    net: phy: marvell: consolidate phy status reading
    
    marvell_read_status_page_an() always reads the PHY status register, but
    marvell_update_link() has already done this.  Rather than wastefully
    reading the register twice in quick succession, read it once in
    marvell_read_status_page() and use the result for both.
    
    This makes marvell_update_link() rather pointless, so move it into
    marvell_read_status_page().
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 760fa78f3509d3d414804c4017de3d0dba995081
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:31 2019 +0000

    net: phy: marvell: use positive logic for link state
    
    Rather than using negative logic:
    
            if (there is no link)
                    set link = 0
            else
                    set link = 1
    
    use the more natural positive logic:
    
            if (there is link)
                    set link = 1
            else
                    set link = 0
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 98f92831c561e43e8d4dafa7165e996af4dc8ac3
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:26 2019 +0000

    net: phy: marvell: initialise link partner state earlier
    
    Move the initialisation of the link partner state earlier, inside
    marvell_read_status_page(), so we don't have the same initialisation
    scattered amongst the other files.  This is in a similar place to
    the genphy implementation, so would result in the same behaviour if
    a PHY read error occurs.
    
    This allows us to get rid of marvell_read_status_page_fixed(), which
    became a pointless wrapper around genphy_read_status_fixed().
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit fcf1f59afc67dc8c214a1b085527ed1fc513c3a2
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:21 2019 +0000

    net: phy: marvell: rearrange to use genphy_read_lpa()
    
    Rearrange the Marvell PHY driver to use genphy_read_lpa() rather than
    open-coding this functionality.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 0efc286a923874f0c243e5766cce54e9429ed949
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:16 2019 +0000

    net: phy: provide and use genphy_read_status_fixed()
    
    There are two drivers and generic code which contain exactly the same
    code to read the status of a PHY operating without autonegotiation
    enabled. Rather than duplicate this code, provide a helper to read
    this information.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 2a10ab043ac5a658225ee77852db7942de9ac4c5
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:11 2019 +0000

    net: phy: add genphy_check_and_restart_aneg()
    
    Add a helper for restarting autonegotiation(), similar to the clause 45
    variant.  Use it in __genphy_config_aneg()
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit af006240c6cfea9f52fc197ac26e6cade4a8623d
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:06 2019 +0000

    net: phy: use phy_resolve_aneg_pause()
    
    Several drivers code their own version of this, working from the LPA
    register, after setting the ethtool link partner advertisement bitmask.
    Use the generic function instead.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit c48f16b42a3bf71eeb9c6141369b001097f961e6
Author: Russell King <rmk+kernel@armlinux.org.uk>
Date:   Tue Dec 17 13:39:00 2019 +0000

    net: phy: remove redundant .aneg_done initialisers
    
    Remove initialisers that set .aneg_done to genphy_aneg_done - this is
    the default for clause 22 PHYs, so the initialiser is redundant.
    
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

commit 52967db53035fd6a35324ffab690981316591ef5
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Dec 19 21:50:32 2019 +0100

    compat_ioctl: block: add missing include
    
    As the 0day bot pointed out, a header inclusion is missing in
    my earlier bugfixes:
    
    block/compat_ioctl.c: In function 'compat_blkdev_ioctl':
     block/compat_ioctl.c:411:7: error: 'IOC_PR_REGISTER' undeclared (first use in this function); did you mean 'TRACE_REG_REGISTER'?
    
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

commit f7f1538c3f7c03eca66a85a6e847108e18ef88bf
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Fri Dec 13 15:34:53 2019 +0200

    drm/i915: Rename pipe update tracepoints
    
    All the other display related tracepoints use intel_ instead
    if i915_ as the prefix. Do the same for the pipe update
    tracepoints so I don't always have to spend time looking for
    them.
    
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191213133453.22152-6-ville.syrjala@linux.intel.com
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

commit 36fef958e2da969595871da07dd913a2e5be2816
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Fri Dec 13 15:34:49 2019 +0200

    drm/i915/fbc: Remove second redundant intel_fbc_pre_update() call
    
    I fumbled the conflict resolution a bit when applying the
    fbc vblank wait w/a. Because of that we now call intel_fbc_pre_update()
    twice. Remove the second redundant call.
    
    Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191213133453.22152-2-ville.syrjala@linux.intel.com
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

commit 317b2cac79a66c7156dbe7983b825dc417acf9a8
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Fri Dec 13 15:34:48 2019 +0200

    drm/i915/fbc: Reject PLANE_OFFSET.y%4!=0 on icl+ too
    
    icl and tgl are still affected by the modulo 4 PLANE_OFFSET.y
    underrun issue. Reject such configurations on all gen9+ platforms.
    
    Can be reproduced easily with the following sequence of
    hardware poking:
    while {
      write FBC_CTL.enable=1
      wait for vblank
    
      write PLANE_OFFSET .x=0 .y=32
      write PLANE_SURF
      wait for vblank
    
      # if PLANE_OFFSET.y is multiple of 4 the underrun won't happen
      write PLANE_OFFSET .x=0 .y=31
      write PLANE_SURF
      wait for vblank
    
      # extra vblank wait is required here presumably
      # to get FBC into the proper state
      wait for vblank
    
      write FBC_CTL.enable=0
      # underrun happens some time after FBC disable
      wait for vblank
    }
    
    Both 8888 and 565 pixel formats and all tilinga formats
    seem affected. Reproduced on KBL/GLK/ICL/TGL. BDW confirmed
    not affected.
    
    Closes: https://gitlab.freedesktop.org/drm/intel/issues/792
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191213133453.22152-1-ville.syrjala@linux.intel.com
    Reviewed-by: Imre Deak <imre.deak@intel.com>

commit 1019fe2c728003f89ee11482cf8ec81dbd8f15ba
Author: Marek Szyprowski <m.szyprowski@samsung.com>
Date:   Thu Dec 19 11:51:30 2019 +0100

    ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids
    
    Hardkernel's Odroid XU3/XU4/HC1 boards use bootloader, which configures
    top PLLs to the following values: MPLL: 532MHz, CPLL: 666MHz and DPLL:
    600MHz.
    
    Adjust all bus related OPPs to the values that are possible to derive
    from the top PLL configured by the bootloader. Also add a comment for
    each bus describing which PLL is used for it.
    
    The most significant change is the highest rate for wcore bus. It has
    been increased to 532MHz as this is the value configured initially by
    the bootloader. Also the voltage for this OPP is changed to match the
    value set by the bootloader.
    
    This patch finally allows the buses to operate on the rates matching the
    values set for each OPP and fixes the following warnings observed on
    boot:
    
    exynos-bus: new bus device registered: soc:bus_wcore ( 84000 KHz ~ 400000 KHz)
    exynos-bus: new bus device registered: soc:bus_noc ( 67000 KHz ~ 100000 KHz)
    exynos-bus: new bus device registered: soc:bus_fsys_apb (100000 KHz ~ 200000 KHz)
    ...
    exynos-bus soc:bus_wcore: dev_pm_opp_set_rate: failed to find current OPP for freq 532000000 (-34)
    exynos-bus soc:bus_noc: dev_pm_opp_set_rate: failed to find current OPP for freq 111000000 (-34)
    exynos-bus soc:bus_fsys_apb: dev_pm_opp_set_rate: failed to find current OPP for freq 222000000 (-34)
    
    The problem with setting incorrect (in some cases much lower) clock rate
    for the defined OPP were there from the beginning, but went unnoticed
    because the only way to observe it was to manually check the rate of the
    respective clocks. The commit 4294a779bd8d ("PM / devfreq: exynos-bus:
    Convert to use dev_pm_opp_set_rate()") finally revealed it, because it
    enabled use of the generic code from the OPP framework, which issues the
    above mentioned warnings.
    
    Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

commit c6d0192afa24e315df501b1bd3f339a13ccb0692
Author: Marek Szyprowski <m.szyprowski@samsung.com>
Date:   Thu Dec 19 11:51:29 2019 +0100

    ARM: dts: exynos: Move Exynos5420 bus related OPPs to the Odroid boards DTS
    
    Currently the only Exynos5422-based boards that support bus frequency
    scaling are Hardkernel's Odroid XU3/XU4/HC1. Move the bus related OPPs
    to the boards DTS, because those OPPs heavily depend on the clock
    topology and top PLL rates, which are being configured by the board's
    bootloader.
    
    Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

commit e1f0fbda75e6447077205b472d1dd71bef417a4c
Author: Colin Ian King <colin.king@canonical.com>
Date:   Thu Dec 19 19:09:16 2019 +0000

    drm/i915: fix uninitialized pointer reads on pointers to and from
    
    Currently pointers to and from are not initialized and may contain
    garbage values. This will cause uninitialized pointer reads in the
    call to intel_frontbuffer_track and later checks to see if to and from
    are null.  Fix this by ensuring to and from are initialized to NULL.
    
    Addresses-Coverity: ("Uninitialised pointer read)"
    Fixes: da42104f589d ("drm/i915: Hold reference to intel_frontbuffer as we track activity")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219190916.24693-1-colin.king@canonical.com

commit 293f8995948330e1df9228519535593618b5ec0e
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu Dec 19 15:51:09 2019 +0100

    tty: serial: 21285: stop using the unused[] variable from struct uart_port
    
    Much like the samsung_tty driver (now I know where they copied the idea
    from), the 21285 uart driver uses 2 bytes from the "unused" array of
    struct uart_port to keep tx/rx enabled/disabled state.  Those fields are
    going away (they were never really needed in the first place), so fix up
    the 21285 driver by another horrible hack.
    
    Instead of creating a whole structure for just 2 bytes, just use two
    bits from the private_data pointer instead, as that pointer is never
    used.  The two bits reflect if tx/rx is now enabled/disabled.
    
    Astute readers will note that once rx is disabled, nothing ever seems to
    turn it back on, making one wonder if anyone has ever done this.
    
    Reported-by: kbuild test robot <lkp@intel.com>
    Cc: Dmitry Safonov <dima@arista.com>
    Cc: Russell King <linux@armlinux.org.uk>
    Cc: Jiri Slaby <jslaby@suse.com>
    Cc: linux-serial@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Link: https://lore.kernel.org/r/20191219145109.GA1962496@kroah.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

commit 737d6777b2315a8b85925affa91325eebac268bd
Author: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Date:   Tue Dec 3 15:50:18 2019 +0100

    cros_ec: treewide: Remove 'include/linux/mfd/cros_ec.h'
    
    This header file now only includes the cros_ec_dev struct, however, is the
    'include/linux/platform_data/cros_ec_proto.h' who contains the definition of
    all the Chrome OS EC related structs. There is no reason to have a
    separate include for this struct so move to the place where other
    structs are defined. That way, we can remove the include itself, but also
    simplify the common pattern
    
        #include <linux/mfd/cros_ec.h>
        #include <linux/platform_data/cros_ec_proto.h>
    
    for a single include
    
        #include <linux/platform_data/cros_ec_proto.h>
    
    The changes to remove the cros_ec.h include were generated with the
    following shell script:
    
        git grep -l "<linux/mfd/cros_ec.h>" | xargs sed -i '/<linux\/mfd\/cros_ec.h>/d'
    
    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Acked-by: Lee Jones <lee.jones@linaro.org>
    Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> for IIO parts.
    Acked-by: Sebastian Reichel <sre@kernel.org>

commit e054d71836f047743f910f97bd13dcd49116c146
Author: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Date:   Wed Dec 18 10:07:20 2019 +0000

    platform/chrome: cros_ec_ishtp: Make init_lock static
    
    The init_lock is not declared or used outside of cros_ec_ishtp.c
    so make it static to avoid the following warning:
    
    drivers/platform/chrome/cros_ec_ishtp.c:79:1: warning: symbol 'init_lock' was not declared. Should it be static?
    
    Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

commit c1ccff45e54eb54fa4e437da197e6738b002f22d
Author: SeongJae Park <sj38.park@gmail.com>
Date:   Fri Nov 29 19:28:23 2019 +0100

    docs/memory-barriers.txt.kokr: Minor wordsmith
    
    As suggested by Paul, I got a review from another Korean hacker Yunjae.
     From the review, I got not only 'Reviewed-by:' tags, but also found a
    few minor nits.  So I made a second version of the patchset but just
    realized that the first version has already sent to Linus.  I therefore
    send only the nit fixes as another patch.
    
    ----------------------------- >8 ----------------------------------------
    docs/memory-barriers.txt.kokr: Minor wordsmith
    
    This commit fixes a couple of minor nits in the Korean translation of
    'memory-barriers.txt'.
    
    Signed-off-by: SeongJae Park <sjpark@amazon.de>
    Reviewed-by: Yunjae Lee <lyj7694@gmail.com>
    Link: https://lore.kernel.org/r/20191129182823.8710-1-sjpark@amazon.de
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 3dbbeef42b6489ec7c10dba4d2b7805c9bbff773
Author: Federico Vaga <federico.vaga@vaga.pv.it>
Date:   Sun Dec 1 13:19:41 2019 +0100

    doc:locking: fix locktorture parameter description
    
    The description was talking about two default values: I removed the
    wrong one.
    
    Signed-off-by: Federico Vaga <federico.vaga@vaga.pv.it>
    Link: https://lore.kernel.org/r/20191201121941.6971-1-federico.vaga@vaga.pv.it
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 281176327d0217d3ee0f7acc93f7542cc1b1ce9d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Dec 18 21:05:45 2019 +0000

    drm/i915/gt: Suppress threshold updates on RPS parking
    
    When we park RPS, we set the GPU to run at minimum 'idle' frequency.
    However, as the GPU is idle, we also disable the worker and RPS
    interrupts - changing the RPS thresholds has no effect, it just incurs
    extra changes to restore them when we unpark. So on parking, leave the
    thresholds set to the current power level and so we expect them to be
    valid for our restart.
    
    References: https://gitlab.freedesktop.org/drm/intel/issues/848
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Andi Shyti <andi.shyti@intel.com>
    Reviewed-by: Andi Shyti <andi.shyti@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191218210545.3975426-2-chris@chris-wilson.co.uk

commit 35cc7f32c298ba163a009598e6e7e15920a2e4e6
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Dec 18 21:05:44 2019 +0000

    drm/i915/gt: Use non-forcewake writes for RPS
    
    Use non-forcewaked writes to queue RPS register changes that will take
    effect when the write buffer is flushed, rather than wake the mmio
    device for immediate effect. This is so that we can avoid a slow
    forcewake dance upon unparking, and at our irregular updates.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Andi Shyti <andi.shyti@intel.com>
    Reviewed-by: Andi Shyti <andi.shyti@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191218210545.3975426-1-chris@chris-wilson.co.uk

commit 921377c0b4e8e240e0b56cb13bc22f2ecc4e59df
Author: Ma Feng <mafeng.ma@huawei.com>
Date:   Thu Dec 19 09:46:31 2019 +0800

    power: supply: abx500_chargalg: Remove unneeded semicolon
    
    Fixes coccicheck warning:
    
    drivers/power/supply/abx500_chargalg.c:1826:2-3: Unneeded semicolon
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

commit e15c54d208f933fe004b2e5fcdd741d3ea408df1
Author: Ma Feng <mafeng.ma@huawei.com>
Date:   Thu Dec 19 09:46:30 2019 +0800

    power: supply: ab8500_charger: Remove unneeded semicolon
    
    Fixes coccicheck warning:
    
    drivers/power/supply/ab8500_charger.c:1082:2-3: Unneeded semicolon
    drivers/power/supply/ab8500_charger.c:792:2-3: Unneeded semicolon
    drivers/power/supply/ab8500_charger.c:2430:2-3: Unneeded semicolon
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

commit c6ef5234efc07679921c20025a743aabfc62f2c0
Author: Ma Feng <mafeng.ma@huawei.com>
Date:   Thu Dec 19 09:46:29 2019 +0800

    power: supply: ab8500: Remove unneeded semicolon
    
    Fixes coccicheck warning:
    
    drivers/power/supply/ab8500_fg.c:2224:5-6: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2227:4-5: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2334:3-4: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2342:3-4: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2350:3-4: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2358:3-4: Unneeded semicolon
    drivers/power/supply/ab8500_fg.c:2366:3-4: Unneeded semicolon
    
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

commit b81e4d9b594188a8babf06442e1d6f28de78c68f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Dec 19 12:43:53 2019 +0000

    drm/i915/gt: Track engine round-trip times
    
    Knowing the round trip time of an engine is useful for tracking the
    health of the system as well as providing a metric for the baseline
    responsiveness of the engine. We can use the latter metric for
    automatically tuning our waits in selftests and when idling so we don't
    confuse a slower system with a dead one.
    
    Upon idling the engine, we send one last pulse to switch the context
    away from precious user state to the volatile kernel context. We know
    the engine is idle at this point, and the pulse is non-preemptible, so
    this provides us with a good measurement of the round trip time. It also
    provides us with faster engine parking for ringbuffer submission, which
    is a welcome bonus (e.g. softer-rc6).
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Stuart Summers <stuart.summers@intel.com>
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219105043.4169050-1-chris@chris-wilson.co.uk
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219124353.8607-2-chris@chris-wilson.co.uk

commit dc93c9b69315167f5678b94aa911dc8e7c299fe5
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Dec 19 12:43:52 2019 +0000

    drm/i915/gt: Schedule request retirement when signaler idles
    
    Very similar to commit 4f88f8747fa4 ("drm/i915/gt: Schedule request
    retirement when timeline idles"), but this time instead of coupling into
    the execlists CS event interrupt, we couple into the breadcrumb
    interrupt and queue a timeline's retirement when the last signaler is
    completed. This should allow us to more rapidly park ringbuffer
    submission, and so help reduce power consumption on older systems.
    
    v2: Fixup intel_engine_add_retire() to handle concurrent callers
    
    References: 4f88f8747fa4 ("drm/i915/gt: Schedule request retirement when timeline idles")
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20191219124353.8607-1-chris@chris-wilson.co.uk

commit bc51a6d34c27bd1040fddaf2bdc61309f392f86a
Author: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Date:   Wed Dec 4 16:15:54 2019 +0530

    Documentation: kernel-hacking: hacking.rst: Change reference to document namespaces.rst to symbol-namespaces.rst
    
    This patch fixes the following documentation build warning:
    Warning: Documentation/kernel-hacking/hacking.rst references
    a file that doesn't exist: Documentation/kbuild/namespaces.rst
    
    According to the following patch:
    https://patchwork.kernel.org/patch/11178727/
    (doc: move namespaces.rst from kbuild/ to core-api/)
    
    The file namespaces.rst was moved from kbuild to core-api
    and renamed to symbol-namespaces.rst.
    Therefore, this patch changes the reference to the document
    kbuild/namespaces.rst in hacking.rst to
    core-api/symbol-namespaces.rst
    
    Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
    Link: https://lore.kernel.org/r/20191204104554.9100-1-madhuparnabhowmik04@gmail.com
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit a83aaf4979e799705781ceb86a1f29d2b29736b1
Author: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Date:   Wed Dec 4 15:49:39 2019 +0530

    Documentation: filesystems: automount-support: Change reference to document autofs.txt to autofs.rst
    
    This patch fixes following documentation build warning:
    Warning: Documentation/filesystems/automount-support.txt references
    a file that doesn't exist: Documentation/filesystems/autofs.txt
    
    Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
    Link: https://lore.kernel.org/r/20191204101939.6939-1-madhuparnabhowmik04@gmail.com
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 1d5c17e470286b8211e8a18d0f85ae89dec4e8d8
Author: Atish Patra <atish.patra@wdc.com>
Date:   Tue Oct 8 18:06:37 2019 -0700

    RISC-V: Typo fixes in image header and documentation.
    
    There are some typos in boot image header and riscv boot documentation.
    
    Fix the typos.
    
    Signed-off-by: Atish Patra <atish.patra@wdc.com>
    Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
    Link: https://lore.kernel.org/r/20191009010637.9955-1-atish.patra@wdc.com
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 8ab517d50a70b30cdf52b38f458cdd3be1735805
Author: Leonard Crestez <leonard.crestez@nxp.com>
Date:   Thu Dec 19 17:42:47 2019 +0200

    PM / devfreq: imx8m-ddrc: Remove unused defines
    
    The IMX_SIP_DDR_DVFS_WAIT_CHANGE and IMX_SIP_DDR_FREQ_SET_HIGH defines
    are not used so they can be removed.
    
    Fixes: 518e99e2a22e ("PM / devfreq: Add dynamic scaling for imx8m ddr controller")
    Reported-by: Shawn Guo <shawn.guo@kernel.org>
    Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

commit fac1617c95255c98d2d9cc5b36e640801b561168
Author: Artur Świgoń <a.swigon@samsung.com>
Date:   Mon Dec 16 11:47:48 2019 +0100

    PM / devfreq: exynos-bus: Reduce goto statements and remove unused headers
    
    Improve code readability by changing the goto statements
    as well as eliminating a few more goto statements (related to return
    paths). Moreover, remove unused header file and adds a missing <linux/of.h>.
    
    Signed-off-by: Artur Świgoń <a.swigon@samsung.com>
    [cw00.choi: Edit patch title and description]
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

commit 24b6b3218cdbd70905364ccb619b95a3ffa8888e
Author: Chanwoo Choi <cw00.choi@samsung.com>
Date:   Thu Dec 12 11:20:30 2019 +0900

    PM / devfreq: rk3399_dmc: Add COMPILE_TEST and HAVE_ARM_SMCCC dependency
    
    To build test, add COMPILE_TEST depedency to both ARM_RK3399_DMC_DEVFREQ
    and DEVFREQ_EVENT_ROCKCHIP_DFI configuration. And ARM_RK3399_DMC_DEVFREQ
    used the SMCCC interface so that add HAVE_ARM_SMCCC dependency to prevent
    the build break.
    
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

commit d29fa533c6c8fafdb20ad0b69ca5890bfa9f3e9e
Author: Yangtao Li <tiny.windzz@gmail.com>
Date:   Sun Dec 15 13:53:15 2019 +0000

    PM / devfreq: rockchip-dfi: Convert to devm_platform_ioremap_resource
    
    Use devm_platform_ioremap_resource() to simplify code.
    
    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

commit d348dff0acf9c0d28a2111f83c3e6349f30f4f95
Author: Yangtao Li <tiny.windzz@gmail.com>
Date:   Sat Dec 14 18:11:30 2019 +0000

    PM / devfreq: rk3399_dmc: Add missing of_node_put()
    
    of_node_put() needs to be called when the device node which is got
    from of_parse_phandle has finished using.
    
    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

commit 8acb64ff01d45c6419942ea9a544a1821ed5b70d
Author: Yangtao Li <tiny.windzz@gmail.com>
Date:   Sat Dec 14 18:11…
@nathanchance

This comment has been minimized.

Copy link
Member Author

@nathanchance nathanchance commented Jan 5, 2020

No longer relevant after llvm/llvm-project@b4b904e.

ZyCromerZ pushed a commit to ZyCromerZ/android_kernel_asus_X01BD that referenced this issue Feb 10, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 10, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ZyCromerZ pushed a commit to ZyCromerZ/android_kernel_asus_X01BD that referenced this issue Feb 11, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 11, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 13, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mrchapp pushed a commit to mrchapp/linux that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 14, 2020
commit aa86797 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
freeza-inc added a commit to freeza-inc/bm-galaxy-note10-sd855-Q that referenced this issue Feb 15, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c87c64 ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to ragy365/onclite_zeus_kernel that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sdm835 that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sdm660 that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cyborg2017 added a commit to nubia-development/android_kernel_nubia_sm8150 that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to mylove90/android_kernel_xiaomi_onc that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ragy365 added a commit to DerpFest-Devices/kernel_xiaomi_onclite that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mylove90 added a commit to Xtended-Devices/android_kernel_xiaomi_onclite that referenced this issue Feb 16, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
venomdev-kernel added a commit to venomdev-kernel/Venoom that referenced this issue Feb 17, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mokeeopensource pushed a commit to MoKee/android_kernel_xiaomi_onclite that referenced this issue Feb 17, 2020
commit aa8679736a82386551eb9f3ea0e6ebe2c0e99104 upstream.

Clang warns:

../drivers/scsi/qla4xxx/ql4_os.c:4148:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
         if (ha->fw_dump)
         ^
../drivers/scsi/qla4xxx/ql4_os.c:4144:2: note: previous statement is
here
        if (ha->queues)
        ^
1 warning generated.

This warning occurs because there is a space after the tab on this
line.  Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

Fixes: 068237c ("[SCSI] qla4xxx: Capture minidump for ISP82XX on firmware failure")
Link: ClangBuiltLinux/linux#819
Link: https://lore.kernel.org/r/20191218015252.20890-1-natechancellor@gmail.com
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.