New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization and language list / names not quite working correctly #319

Closed
nylen opened this Issue Dec 27, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@nylen
Copy link
Member

nylen commented Dec 27, 2018

From #295 (comment):

The list of available languages is working as intended, but it looks like there are some issues with the format of the language packs. For example, I can select English or Italian during the install, but the installation process is not translated. Then, when I finish the install and visit the settings screen, it looks like this:

2018-12-17t22 43 14-05 00

I think this is something we need to fix in the translations API. One possible cause is different filenames between the WordPress and ClassicPress translation zipfiles (WP has it_IT.po, ClassicPress has core-it_IT.po).

@Mte90 asked:

For the installation page can you share what is not localized?

When I tested this a few days ago, I saw that nothing in the installation process was localized.

After the installation process completed, core strings were localized as expected, but the languages list looked wrong (core-it_IT should be the same as Italian but both entries appeared instead).

@nylen

This comment has been minimized.

Copy link
Member Author

nylen commented Dec 27, 2018

Also:

For example, I can select English or Italian during the install

[screenshot shows English and Italian]

This probably shows 10 non-English locales available now, according to the data at https://api-v1.classicpress.net/translations/core/1.0.0/translations.json . If anything else has changed, that would be good to know.

@nylen nylen changed the title Localization not quite working correctly Localization and language list / names not quite working correctly Dec 27, 2018

@Mte90

This comment has been minimized.

Copy link
Collaborator

Mte90 commented Dec 28, 2018

Just a little update fromn slack seems a problem of prefixes in the generation of the files

@ginsterbusch

This comment has been minimized.

Copy link

ginsterbusch commented Jan 6, 2019

@Mte90 I agree (with the prefix issue). There is this screenshot from the initial thread in the German support forum:

Errors in the JS console

@nylen

This comment has been minimized.

Copy link
Member Author

nylen commented Jan 8, 2019

This is causing more problems: #323, #325

@nylen nylen added the high priority label Jan 8, 2019

@Mte90

This comment has been minimized.

Copy link
Collaborator

Mte90 commented Jan 8, 2019

on ClassicPress/ClassicPress-Network#29 I explained the issue, how the 2 pr will fix that problem and how to handle for other installation with wrong files

@nylen

This comment has been minimized.

Copy link
Member Author

nylen commented Jan 9, 2019

Fixed in ClassyBot/i18n-scripts#1 and ClassicPress/ClassicPress-Network#29.

If your site is affected by this issue, you'll need to select your desired language in the settings and save the changes. See ClassicPress/ClassicPress-Network#29 (comment) for details.

@nylen nylen closed this Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment