Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WordPress events in dashboard with feature votes #40

Closed
nylen opened this issue Sep 7, 2018 · 35 comments

Comments

Projects
None yet
10 participants
@nylen
Copy link
Member

commented Sep 7, 2018

Let's decide what to do about the WordPress events feed that comes through in the admin dashboard.

I think we should remove it from ClassicPress, because these are officially sponsored WordPress events, and it doesn't seem fair to encourage people to "crash the party" so to speak.

This will also eliminate some calls to the WordPress.org APIs.

@senlin

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

I'm also for removing the lot.

@KTS915

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2018

That makes sense to me too.

@scottybo

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

I vote for removing - ClassicPress branding will be everywhere apart from in the events, and I think this will lead to confusion.

RE: The events themselves, I've been using WordPress for 10+ years and have never found this area on the dashboard useful.

@scottybo

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

Idea: Replace the events feed with a feed of feature requests from vote.classicpress.net - a big personal goal of mine is to get the average user involved in the process of moving ClassicPress forward. Having this on the dashboard goes a long way to achieving that goal

@nylen

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2018

It seems like we have a consensus here. Let's use an API endpoint under https://api.classicpress.net for this, so that we can modify the implementation later if needed. See: ClassicPress/ClassicPress-APIs#3

It would also be nice to have users search for their feature request before they submit it - we are already seeing some duplicate requests coming up on https://vote.classicpress.net.

@nylen nylen changed the title WordPress events in dashboard Replace WordPress events in dashboard with feature vots Sep 11, 2018

@nylen nylen changed the title Replace WordPress events in dashboard with feature vots Replace WordPress events in dashboard with feature votes Sep 11, 2018

@dsnid3r

This comment has been minimized.

Copy link

commented Sep 16, 2018

Forgot to comment here but I support the decision of replacing WordPress events tab in the dashboard but on a multisite install it should only show up in the Network Admin panel. The way it currently works if I recall properly is it shows up on the Network panel and the primary site, I move to strike it from the primary sites dashboard and go exclusively to the Network panel.

@dsnid3r

This comment has been minimized.

Copy link

commented Sep 16, 2018

Once we get lock down the confirmation of how we're moving forward with voting and our own ClassicPress website I can handle this. (already have the code ready from one of my multisites)

@nylen

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2018

Hi @dsnid3r, let's go ahead with the implementation (removing all code related to WP events, and replacing it with ClassicPress feature requests). Here is the first step in implementing this:

Let's use an API endpoint under https://api.classicpress.net for this, so that we can modify the implementation later if needed. See: ClassicPress/ClassicPress-APIs#3

@dsnid3r

This comment has been minimized.

Copy link

commented Sep 17, 2018

Hi @dsnid3r, let's go ahead with the implementation (removing all code related to WP events, and replacing it with ClassicPress feature requests). Here is the first step in implementing this:

Let's use an API endpoint under https://api.classicpress.net for this, so that we can modify the implementation later if needed. See: ClassicPress/ClassicPress-APIs#3

You got it.

@dsnid3r

This comment has been minimized.

Copy link

commented Sep 23, 2018

I will get back to this on Monday.

@dsnid3r

This comment has been minimized.

Copy link

commented Oct 8, 2018

Dropped the ball on this, if anyone wants to take this over that would be great.

@nylen nylen added this to the v1.0.0 milestone Oct 17, 2018

@nylen

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

Milestoning for our final release for now, as this is likely to be a significant amount of work. Hopefully we can get it done in a beta release though!

@brettvan

This comment has been minimized.

Copy link

commented Oct 25, 2018

I am taking a look at this issue. Will be at WC Philly this weekend though.

@mikeschinkel

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

Somewhat related (since they are about revamping the admin):

@dikiyforester

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2018

Can I help with this ticket?

@nylen

This comment has been minimized.

Copy link
Member Author

commented Nov 20, 2018

Hi @dikiyforester, yes, definitely!

You can use this API endpoint to pull the needed data from within ClassicPress: https://api-v1.classicpress.net/features/1.0/
More info here: ClassicPress/ClassicPress-APIs#3

@dikiyforester

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

The widget "Events and News" actually includes two separated parts: News and Events.
See here

wp_print_community_events_markup();
?>
<div class="wordpress-news hide-if-no-js">
<?php wp_dashboard_primary(); ?>
</div>

Should we leave the News part or remove it along with Events? We actually can connect it to ClassicPress blog endpoint and to the RSS feed.

@nylen

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2018

We actually can connect it to ClassicPress blog endpoint and to the RSS feed.

This sounds good to me.

dikiyforester added a commit to dikiyforester/ClassicPress that referenced this issue Nov 25, 2018

@bahiirwa

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@mikeschinkel Done with request.

@mikeschinkel

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@bahiirwa

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

I have done a prototype plugin on https://github.com/bahiirwa/ClassicPressPetitionsDashboard Kindly check and advise if this is a step forward or backwards

With the help of @mikeschinkel @striebwj I think, the plugin is now good for a proper review.

screenshot-1

@dikiyforester

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

@bahiirwa Why don't you create a PR which can be reviewed?

@bahiirwa bahiirwa referenced this issue Dec 4, 2018

Closed

Add Petitions Dashboard widget #259

2 of 6 tasks complete
@bahiirwa

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2018

PR done.

@nylen nylen closed this in 3967e00 Dec 12, 2018

@dikiyforester

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

@nylen Could you please reopen since it still needs to remove Events code.
I was planning to do that in the next PR (after #268).

@bahiirwa

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

Do you really want to do that, there was a request in slack to have this remain as some folks want to attend these events for learning sake. Will it be deprecated into a plugin at least?

@dikiyforester

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

Do you really want to do that, there was a request in slack to have this remain as some folks want to attend these events for learning sake. Will it be deprecated into a plugin at least?

Ohhh, I wasn't aware of this. Just following the original ticket task.
@nylen could you clarify this?

nylen added a commit that referenced this issue Dec 13, 2018

Updates to dashboard petitions feature (#276)
Follow-up to #40 and #268.

- List Trending petitions first; improve indentation
- Improve comments
- Handle JSON decode errors
- Whitespace fix
@nylen

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

Reopening this issue. I meant to reopen after I merged that PR but forgot.

I still think we should remove the rest of this feature, because WP events are not our events, and we don't want to encourage people to "crash the party" so to speak. Instead, we want to focus on our petitions list and the news feed from our site (getting people involved in our project online).

Will it be deprecated into a plugin at least?

I'd love to be able to do this :) However, we don't really have a good place to put this plugin right now.

If someone wants to write a plugin for this and submit it to the WP plugin directory, that would work. In that case, probably best to write it as a plugin that can disable the events feed too, so that it has value for WP users.

@nylen nylen reopened this Dec 14, 2018

@nylen nylen modified the milestones: v1.0.0, v1.0.0-beta3 Jan 8, 2019

@ruiguerreiro79

This comment has been minimized.

Copy link
Collaborator

commented Feb 11, 2019

what need's to be done on this one?

@nylen

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

@ruiguerreiro79 the WP events feed needs to be removed from the ClassicPress dashboard until we have something similar that can replace it.

We already have blog posts from www.classicpress.net/blog coming through, as well as feature votes from the petitions site. That is good enough for v1.

@ruiguerreiro79

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

@nylen So is it ok to remove the red areas of the following image? The News at the bottom point to the classicpress.net/blog
image

@nylen

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

@ruiguerreiro79 yes, remove the red boxes in your screenshot, and also change the title to just "ClassicPress News".

@nylen

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

PR for this issue: #367

@nylen nylen closed this in #367 Feb 19, 2019

nylen added a commit that referenced this issue Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.