Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Issues with source strings #109

Closed
nylen opened this issue Mar 4, 2020 · 16 comments
Closed

Translations: Issues with source strings #109

nylen opened this issue Mar 4, 2020 · 16 comments

Comments

@nylen
Copy link
Contributor

nylen commented Mar 4, 2020

A screenshot from Crowdin showing the context (file and line number) should be sufficient to track these for later investigation and correction.

Should be consistent in whether the source string has a . at the end:
2020-03-04T21-48-09Z

@nylen
Copy link
Contributor Author

nylen commented Mar 4, 2020

Wrong type of quotes:
2020-03-04T21-51-45Z

@nylen
Copy link
Contributor Author

nylen commented Mar 4, 2020

"ClassicPress theme directory":
2020-03-04T22-12-16Z

Also that "Live a little!" could probably be removed.

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

Wrong kind of quotes:
2020-03-05T20-32-03Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

ClassicPress.net plugin and theme directories:
2020-03-05T20-38-59Z
2020-03-05T22-56-37Z
2020-03-05T23-00-40Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

ClassicPress should probably be changed back to WordPress here:
2020-03-05T20-52-58Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

We should not be translating this string in any languages since we don't localize wp-config-sample.php:
2020-03-05T21-01-17Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

"URL" should be capitalized:
2020-03-05T21-25-17Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

"CSV" should be capitalized:
2020-03-05T21-28-28Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

’ is the standard entity used for contractions:
2020-03-05T21-33-35Z
2020-03-05T21-42-06Z
2020-03-05T23-15-17Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

Missing plural form:
2020-03-05T22-53-32Z

@nylen nylen added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 5, 2020
@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

The singular form of this string is duplicated:
2020-03-05T23-06-57Z

@nylen
Copy link
Contributor Author

nylen commented Mar 5, 2020

We should check the translations of this string to make sure it's not translated literally, as it was in Spanish:

2020-03-05T23-09-16Z

Here is how this can be done instead (note these two strings are a pair):

2020-03-05T23-10-34Z

We should probably also improve the translator comments to be more clear (and both strings should have comments). Code link:

https://github.com/ClassicPress/ClassicPress/blob/f765dbfa00cf74fd51cae45ffb13cd2536417e4b/src/wp-includes/formatting.php#L128-L136

@ClassyBot
Copy link
Collaborator

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/approving-and-cleaning-existing-strings-on-crowdin/2210/2

@ClassyBot
Copy link
Collaborator

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/how-to-deal-with-weird-things-in-translations/3589/12

@ClassyBot
Copy link
Collaborator

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/call-for-volunteers-to-translate-classicpress/1894/58

@viktorix
Copy link
Member

Translations will be redone in v2.0, so this issue will be closed.

@viktorix viktorix removed help wanted Extra attention is needed good first issue Good for newcomers labels Jun 19, 2023
@viktorix viktorix transferred this issue from ClassicPress/ClassicPress Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants