New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass EXIF Data to the wp_read_image_metadata filter #904 #1020
Conversation
…Type` variable to `$image_type` to match coding standards. Merges https://core.trac.wordpress.org/changeset/42878 to the 5.0 branch. See https://core.trac.wordpress.org/ticket/43624. --- Merges https://core.trac.wordpress.org/changeset/43749 / WordPress/wordpress-develop@f74570d139 to ClassicPress.
WP:Props desrosj. Merges https://core.trac.wordpress.org/changeset/42879 to the 5.0 branch. Fixes https://core.trac.wordpress.org/ticket/43624. Conflicts: - src/wp-admin/includes/image.php --- Merges https://core.trac.wordpress.org/changeset/43750 / WordPress/wordpress-develop@56b7476d7a to ClassicPress.
Changeset 43749 added $image_type and 43750 adds $exif requested in the issue #904.
With just the changes to add |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good even after the whitespace. Same result as Simone.
Description
Changeset 43750 passes EXIF Data to the wp_read_image_metadata filter and changeset 43749 fixes a merge conflict by replacing sourceImageType with image_type.
Motivation and context
Fixes ClassicPress/ClassicPress-v1#38. See ticket ticket 43624 for details.
How has this been tested?
A quick way to test it is to add the following code to your functions.php. Make sure to upload a photo with exif data and replace the file path in the code. Load the website, it should show you exif data and the word "Yes!". See screenshot below.
Screenshots
Types of changes
Backport