addresses #171 (Missing img alt attributes in admin menu) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mte90
suggested changes
Nov 3, 2018
Mte90
approved these changes
Nov 3, 2018
mattyrob
added a commit
that referenced
this pull request
Nov 20, 2023
* Update template.php Following PR #197, there is no longer any need for the accordion script. This PR therefore removes it from the JS folder in `wp-admin` and removes the function calling it from `template.php` in `wp-admin/includes` * Remove jQuery accordion script from those registered in script-loader.php * Update script-loader.php Remove more references to the accordion script * Reverting earlier commit because it targeted the wrong 'accordion' script Confusingly, there are two accordion scripts in the CP admin: one is part of jQuery UI and should not be removed. This commit reverts its removal. * Deatils and summary tags added to class-wp-customize-nav-menus.php This replicates the changes made to the regular `nav menus` screen in that it adds the `details` and `summary` tags to the Add Menus section in the Customizer. This change both improves accessibility and enables the `accordion` script to be removed. * Update common.css This deletes `display: none;` from the `.accordion-section-content` class and so enables the relevant sections to become visible when toggled using the `details` tag. * Coding standards and docblock corrections * Fix for failing unit test * Delete src/wp-admin/js/accordion.js Delete file as it is no longer used --------- Co-authored-by: mattyrob <mattyrobuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing alt tags:
alt="ClassicPress"for the primary onealt=""for the multisite blogs listTypes of changes
Checklist: