Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Redesign of install process and screens for improved branding and consistency. #265
This PR pertains to issue #210 and implements a redesign of the installation process and views.
The goals achieved with this PR are several:
About the Install Process
This update breaks the install process into several main views, each of which have a CTA-stlye button:
There are also quite a few supporting views for the many various errors that might occur during installation. These are handled and branded, as well.
About the Logo File
I've added png/svg logo files to
About the Texts
Most of the install and error texts have been rewritten. The goal was to remove verbosity, yet remain informative. I feel a nice balance has been struck, but am open to suggestions as few of these have been discussed. A notable exception is in the case of database errors - this markup is provided to the install process, not generated within it, so it is used as-is.
Probably the biggest change code-wise is the removal of the on/off PHP tags. My syntax highlighting was ineffective with it and my IDE's code collapse was "dancing"... I hope this is not a problem. In some places, I've outputted tabs and newlines to make the source markup readable; these aren't really needed and can be removed.
The "Alright Sparky" step is removed in support of this petition. This petition has decent support, but does not reach the 50 vote threshold. As we are pre-1.0, perhaps a committee decision can be made to allow it. This step can be added back in, if absolutely necessary.
How has this been tested?
Manual, localhost, painstakingly. That said, it will be good to get a bunch of eyes on it.
Types of changes
There are more views, as well, such as when the user tries to add wonky characters to the table prefix... or uses unsupported characters in their email address. Those are also accounted for. I've just run short on time and need to get this posted.
Excellent work @johnalarcon! I will test this out more thoroughly, but for now I've left a few minor comments on the code.
The build failure is because a new image was added without being minified:
If you can run
This can also wait until we organize the images a bit better.
I will give this some more thought, but for now, one consideration is that we need to keep the filenames of the old WordPress logo images the same, so that plugins/themes/sites can reference them the same way.
This means we either need to fit new images into the existing naming scheme, or make copies of any new images. I'm not sure which is the best way, but so far we have been fitting things in as best we can.
Thanks! I've addressed some of the comments and updated the PR accordingly. I'll get to the remaining items soon.
I've created issue #266 with a proposal to get this in order.
I think removing the Alright Sparky step qualifies, and it's a clear improvement with (as far as I know) no backwards compatibility implications.
It's also already implemented, so even better.
The code looks good at a glance, but I agree this needs a thorough review. I haven't forgotten about it, and we'll get to it as soon as we can.
Thanks for the update.
After reviewing Beta2, I notice the initial step of the installation – the language picker – is showing a lot of white space due to there being fewer languages. I think there were 11 of them. It's not clear when there will be additional languages added, so I was thinking it should be reduced in height to fit, so it doesn't give the impression that something is missing. What say you?
Thanks for doing this @johnalarcon, it took a while but we are finishing it.
There were more button styles and colors here than you might expect, so I've modified them to look like the buttons in #223:
This darker color scheme also has a better contrast ratio, and I've added some fixes for disabled buttons and other edge cases.
I was able to test this including all the progress / error / secondary screens. Tomorrow I'll merge #366 first and then update this PR to use the new filename.