Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Integrate bugfix from 5.0.2 #320
Hi, this isn't going to work as it currently stands. The way this is set up is almost impossible to review and verify that these are actually things we want.
What bugs are we fixing here? Each one needs to go into a separate PR with an explanation and links to relevant Trac tickets.
The most urgent type of fix from other WP branches is PHP 7.3 compatibility. I am not sure if we even want to accept other things right now.
I followed the guide on discourse, for the title this happened because I merged 4 commits that require a manual fix because of conflicts in the code.
No, not really :) Please include the original commit messages, and links to the original commits on both Trac and https://github.com/WordPress/wordpress-develop.
Creating a PR with multiple unrelated changes and no explanation of what is being changed is not a good idea. Someone who wants to review this PR cannot know what it is about, how to test it, or whether the changes are something we want to accept. If some changes are good, but not others, there is no way to sort that out because they are all bundled together.
I'm closing this PR. Please open a new one for each specific change and include an explanation of what you are changing and why, with links to the original change in WP. I'd suggest starting with the PHP 7.3 fix.