New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-r44297: PHP 7.3 Compatibility: Fix compact related notices #332

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@Mte90
Copy link
Collaborator

Mte90 commented Jan 15, 2019

PR to test https://gist.github.com/Mte90/a8c06567855ecde19db245e64d96f739


In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

See https://core.trac.wordpress.org/ticket/44416.

Fixes https://core.trac.wordpress.org/ticket/45483


Merges https://core.trac.wordpress.org/changeset/44185 / WordPress/wordpress-develop@7cda240 to ClassicPress.

@Mte90 Mte90 referenced this pull request Jan 15, 2019

Closed

Integrate patch from 5.0.2 #301

@nylen

This comment has been minimized.

Copy link
Member

nylen commented Jan 16, 2019

This changeset ID is also incorrect. The linked GitHub commit says 44297:

git-svn-id: https://develop.svn.wordpress.org/trunk@44297 602fd350-edb4-49c9-b593-d223f7449a82

@Mte90

This comment has been minimized.

Copy link
Collaborator Author

Mte90 commented Jan 16, 2019

Yes I made that change manually in the commit because this was first the second script that add that part.

@nylen

This comment has been minimized.

Copy link
Member

nylen commented Jan 16, 2019

Please pay closer attention to the WP ticket and changeset numbers you are using. This is getting closer to what we need in order to track backports from WP, but it is still broken.

As I mentioned in Slack, I'd suggest posting your script as a PR against this repository so that we can work on it.

@Mte90

This comment has been minimized.

Copy link
Collaborator Author

Mte90 commented Jan 16, 2019

Ok, I was thinking in the meantime to fix the commit message of this 2 pr so we can move on them and later to work more on the scripts.

@nylen

This comment has been minimized.

Copy link
Member

nylen commented Jan 16, 2019

This PR could probably be cleaned up and merged, but since we still don't have the information we need here (WP changeset + git commit hash), it's probably going to be quicker to fix the script and then re-do these PRs.

@Mte90 Mte90 referenced this pull request Jan 16, 2019

Merged

Backport scripts #335

@nylen

This comment has been minimized.

Copy link
Member

nylen commented Jan 27, 2019

@Mte90 can you re-run our new backport script against this PR?

WP-r44297: PHP 7.3 Compatibility: Fix compact related notices.
In PHP 7.3, the `compact()` function has been changed to issue an `E_NOTICE` level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

See https://core.trac.wordpress.org/ticket/44416.

Merges https://core.trac.wordpress.org/changeset/44185 into trunk.

Fixes https://core.trac.wordpress.org/ticket/45483.

Conflicts:
  src/wp-admin/includes/post.php
----
Merges https://core.trac.wordpress.org/changeset/44297 / WordPress/wordpress-develop@7cda240 to ClassicPress.

@Mte90 Mte90 force-pushed the Mte90:merge/wp-r45483 branch from 9972666 to f54a66b Jan 28, 2019

@Mte90

This comment has been minimized.

Copy link
Collaborator Author

Mte90 commented Jan 28, 2019

generated with the new script :-)

@nylen nylen changed the title #WP-45483: PHP 7.3 Compatibility: Fix compact related notices. WP-r44297: PHP 7.3 Compatibility: Fix compact related notices Jan 28, 2019

@nylen

nylen approved these changes Jan 28, 2019

Copy link
Member

nylen left a comment

Thanks!

@nylen nylen merged commit ce080b2 into ClassicPress:develop Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment