Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width issue with petitions widget #338

Merged
merged 1 commit into from Jan 18, 2019
Merged

Fix width issue with petitions widget #338

merged 1 commit into from Jan 18, 2019

Conversation

striebwj
Copy link
Member

Fixed an issue where the width of the petitions table wouldn't fit the widget box.

@striebwj striebwj requested a review from nylen January 17, 2019 22:00
@nylen
Copy link
Contributor

nylen commented Jan 18, 2019

In the future it would be nice to have steps to reproduce the issue and before/after screenshots.

I think I figured this one out, though - for me, the issue only appears at smaller screen widths where the dashboard drops to 1 column of widgets:

2019-01-17t19 17 30-05 00

The fix looks good, I'll merge this now.

Copy link
Contributor

@nylen nylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@nylen nylen merged commit 617dc87 into ClassicPress:develop Jan 18, 2019
@nylen
Copy link
Contributor

nylen commented Jan 18, 2019

I think I figured this one out, though - for me, the issue only appears at smaller screen widths where the dashboard drops to 1 column of widgets:

Confirmed - I looked on GitHub first, then I saw the related chat discussion here: https://classicpress.slack.com/archives/CCNEEH86P/p1547760333841400

@striebwj
Copy link
Member Author

That was my bad, I even had the screenshots ready to post but was in a rush to submit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants