Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Security page #368
A placeholder security page.
Motivation and context
This shows intent, and gives authors a chance to update their plugins/themes to support ClassicPress.
How has this been tested?
Observation (yes, the new page is there), and a quick test plugin.
Screenshots (if appropriate):
Types of changes
Why do we have both horizontal tabs in the main content area, and vertical submenu items in the admin menu?
If we're going to keep both of those, I think the tabs should be the same as the submenu items, but I think it would probably be even better to just pick one.
@invisnet this is something we'll want to continue building on in the future, so I'm going to merge it as
Then we can submit further PRs against that branch (e.g. to add the first options to this screen), and merge into
When building menu pages we have always had particular priority numbers/set apart for each of the menu pages that come by default. Is this still to be respected? What number will be set for security pages if so? We would add this to documentation so that developers can respect that space.
This is a bad idea for several reasons. Firstly, you're insinuating that Security is a setting for users to turn on or off and be done with it (obviously, that's not how security works).
Secondly, it's stumbling right into what I feared for ClassicPress which is not appreciating how the vast ecosystem of WordPress works -- the CMS cannot and should not overstep its bounds. If you want to create an ecosystem of plugins, themes, agencies, web hosts (etc) then you need to know your place and integrate with other industry players.