Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain default themes better #385

Merged
merged 3 commits into from Feb 27, 2019

Conversation

Projects
None yet
1 participant
@nylen
Copy link
Member

commented Feb 27, 2019

The blue notices are new:

2019-02-26t22 38 45-05 00

Closes #299. Other solutions are more complicated with lots of edge cases (even more edge cases).

Note, there are three places where this notice needs to be rendered:

  • /wp-admin/themes.php, JavaScript disabled
  • /wp-admin/themes.php, JavaScript enabled
  • /wp-admin/customize.php, after clicking the Change button next to the active theme

Also, the new notice should only appear if both the child theme and the parent theme for a given year are present.

@nylen nylen added this to the v1.0.0-rc2 milestone Feb 27, 2019

@nylen

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

@nylen nylen merged commit 2c11dc4 into develop Feb 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nylen nylen deleted the update/explain-themes-better branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.